Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just set evil-want-integration to nil doesn't prevent it set keybindings in dired mode. #15

Closed
AmaiKinono opened this issue Apr 26, 2019 · 2 comments

Comments

@AmaiKinono
Copy link

Hi. I've read in the guide that:

In evil-integration.el, evil-make-overriding-map is used for dired and ibuffer. If you want to prevent evil-integration.el from being loaded, you can set evil-want-integration to nil before loading evil.

I have SPC as my prefix key in normal state. But having evil-want-integration set to nil, SPC still calls dired-next-line. It turns out that evil-integration doesn't make the overriding map, but evil-keybindings does. You have to set evil-want-keybinding to nil to prevent that.

I am not so familiar with evil, so I think it's best for you to add some information about this. But I would be happy to (try to) create a PR if you like that.

@AmaiKinono
Copy link
Author

Actually I found evil-integration doesn't make any overriding map, and it's pretty useful. For example, it makes . doesn't break some things. Here's what happened when I press M-x C-g . with evil-want-integration set to nil:

Peek 2019-04-27 02-18

It splits the frame, and my modeline is ruined. But with evil-integration, it actually knows I didn't do anything so that won't happen.

@noctuid
Copy link
Owner

noctuid commented Apr 26, 2019

Yes there were some changes in evil, and I never updated the guide. I'll fix this.

@noctuid noctuid closed this as completed in 12db7f9 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants