Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report all passing & failing contract checks #265

Open
anna-carroll opened this issue Apr 28, 2022 · 0 comments
Open

feat: report all passing & failing contract checks #265

anna-carroll opened this issue Apr 28, 2022 · 0 comments

Comments

@anna-carroll
Copy link
Member

anna-carroll commented Apr 28, 2022

Motivation

Right now, contract deploy checks throw an error and stop when the first check fails.

This makes it difficult to take stock of ALL of the checks which are not passing, and often, the errors thrown are not very informative.

Solution

  • run all of the contract tests (even if some of them fail; don't throw an error and halt the process)
  • push test results to an object
  • separate passing tests & failing tests
  • print the object at the end of the process
  • throw an error if any failing tests are present
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant