Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #22

Open
2 of 6 tasks
noryb009 opened this issue Nov 27, 2017 · 0 comments
Open
2 of 6 tasks

Code cleanup #22

noryb009 opened this issue Nov 27, 2017 · 0 comments
Labels

Comments

@noryb009
Copy link
Owner

noryb009 commented Nov 27, 2017

There are a few changes I want to make to clean up the code:

  • Switch to 2 spaces for indents.
  • Don't use relative paths in includes (and rename utils.*).
  • Rename C++ files to use a more common extension (either cpp or cc).
  • Use a better plugin style (ideally just dropping in a cpp file would be enough to add it). This makes it really easy to add extensions, it's not a game of trying to figure out what lines need to be added where.
  • Use bools instead of ints.
  • Where we can't use ints, standardize what ints mean (eg. sometimes 0 is an error, sometimes -1 is an error).
noryb009 added a commit that referenced this issue Mar 26, 2018
noryb009 added a commit that referenced this issue Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant