Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPIO: Don't rely on embedded-hal-traits #349

Open
David-OConnor opened this issue Aug 15, 2021 · 1 comment
Open

GPIO: Don't rely on embedded-hal-traits #349

David-OConnor opened this issue Aug 15, 2021 · 1 comment

Comments

@David-OConnor
Copy link

David-OConnor commented Aug 15, 2021

Ie, remove unwrap() requirement when setting pins in both internal and external code. Note how other peripheral modules like SPIM and TWIM add the embedded-hal impls as add-ons, vice primary API.

I'll submit a PR if you agree.

@jonas-schievink
Copy link
Contributor

Yeah, we can probably add inherent methods for controlling the pins. Note that there's also a pending redesign of the whole GPIO module in #301.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants