forked from palantir/tslint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
noNamespaceRule.ts
81 lines (72 loc) · 3.1 KB
/
noNamespaceRule.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
/**
* @license
* Copyright 2016 Palantir Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { hasModifier, isNodeFlagSet } from "tsutils";
import * as ts from "typescript";
import * as Lint from "../index";
const OPTION_ALLOW_DECLARATIONS = "allow-declarations";
interface Options {
allowDeclarations: boolean;
}
export class Rule extends Lint.Rules.AbstractRule {
/* tslint:disable:object-literal-sort-keys */
public static metadata: Lint.IRuleMetadata = {
ruleName: "no-namespace",
description: "Disallows use of internal \`module\`s and \`namespace\`s.",
descriptionDetails: "This rule still allows the use of `declare module ... {}`",
rationale: Lint.Utils.dedent`
ES6-style external modules are the standard way to modularize code.
Using \`module {}\` and \`namespace {}\` are outdated ways to organize TypeScript code.`,
optionsDescription: Lint.Utils.dedent`
One argument may be optionally provided:
* \`${OPTION_ALLOW_DECLARATIONS}\` allows \`declare namespace ... {}\` to describe external APIs.`,
options: {
type: "array",
items: {
type: "string",
enum: [OPTION_ALLOW_DECLARATIONS],
},
minLength: 0,
maxLength: 1,
},
optionExamples: [true, [true, OPTION_ALLOW_DECLARATIONS]],
type: "typescript",
typescriptOnly: true,
};
/* tslint:enable:object-literal-sort-keys */
public static FAILURE_STRING = "'namespace' and 'module' are disallowed";
public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
return this.applyWithFunction(sourceFile, walk, {
allowDeclarations: this.ruleArguments.indexOf(OPTION_ALLOW_DECLARATIONS) !== -1,
});
}
}
function walk(ctx: Lint.WalkContext<Options>) {
// Ignore all .d.ts files by returning and not walking their ASTs.
// .d.ts declarations do not have the Ambient flag set, but are still declarations.
if (ctx.sourceFile.isDeclarationFile && ctx.options.allowDeclarations) {
return;
}
for (const node of ctx.sourceFile.statements) {
if (node.kind === ts.SyntaxKind.ModuleDeclaration) {
if ((node as ts.ModuleDeclaration).name.kind !== ts.SyntaxKind.StringLiteral &&
!isNodeFlagSet(node, ts.NodeFlags.GlobalAugmentation) &&
(!ctx.options.allowDeclarations || !hasModifier(node.modifiers, ts.SyntaxKind.DeclareKeyword))) {
ctx.addFailureAtNode(node, Rule.FAILURE_STRING);
}
}
}
}