Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional "realm" OAuth parameter #33

Open
nicklangridge-amtivo opened this issue Mar 21, 2024 · 2 comments
Open

Support optional "realm" OAuth parameter #33

nicklangridge-amtivo opened this issue Mar 21, 2024 · 2 comments

Comments

@nicklangridge-amtivo
Copy link
Contributor

nicklangridge-amtivo commented Mar 21, 2024

Web::API is great, thanks for your efforts 🙏

It would be handy if it could support the optional "realm" parameter for OAuth 1.0, see the spec section 5.4.1. point 4: https://oauth.net/core/1.0a/#rfc.section.5.4.1. The parameter is required by some web services, e.g. the NetSuite REST API.

A solution might be to add a new optional realm attribute to the Web::API class and include it in the OAuth options if it has been supplied.

Is it something you would consider adding? or failing that, would you be willing to accept a pull request?

@nicklangridge-amtivo
Copy link
Contributor Author

nicklangridge-amtivo commented Mar 22, 2024

Although, it seems even with the realm parameter added to Web::API, later Net::OAuth does not make use of it, so there may be additional work needed there.

@nupfel
Copy link
Owner

nupfel commented Apr 7, 2024

I totally accept PRs feel free to make one and sorry for the huge delay in responding! I don't have time to add this feature myself, but I will happily audit and merge a PR.

Thank you so much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants