Issue geerlingguy#169: Various fixes for typos and outdated usage.

Author: geerlingguy

drupal/provisioning/playbook.yml

@@ -93,9 +93,6 @@
         state: present
       notify: restart apache
 
-    - name: Remove the MySQL test database.
-      mysql_db: db=test state=absent
-
     - name: Create a MySQL database for Drupal.
       mysql_db: "db={{ domain }} state=present"
 
@@ -120,7 +117,7 @@
         creates=/usr/local/bin/composer
 
     - name: Move Composer into globally-accessible location.
-      shell: >
+      command: >
         mv /tmp/composer.phar /usr/local/bin/composer
         creates=/usr/local/bin/composer
 
@@ -131,7 +128,7 @@
         dest: /opt/drush
 
     - name: Install Drush dependencies with Composer.
-      shell: >
+      command: >
         /usr/local/bin/composer install
         chdir=/opt/drush
         creates=/opt/drush/vendor/autoload.php
@@ -149,7 +146,7 @@
         dest: "{{ drupal_core_path }}"
 
     - name: Install Drupal dependencies with Composer.
-      shell: >
+      command: >
         /usr/local/bin/composer install
         chdir={{ drupal_core_path }}
         creates={{ drupal_core_path }}/vendor/autoload.php

includes/provisioning/tasks/composer.yml

@@ -12,6 +12,6 @@
     creates=/usr/local/bin/composer
 
 - name: Move Composer into globally-accessible location.
-  shell: >
+  command: >
     mv /tmp/composer.phar /usr/local/bin/composer
     creates=/usr/local/bin/composer

includes/provisioning/tasks/drupal.yml

@@ -6,7 +6,7 @@
     dest: "{{ drupal_core_path }}"
 
 - name: Install Drupal dependencies with Composer.
-  shell: >
+  command: >
     /usr/local/bin/composer install
     chdir={{ drupal_core_path }}
     creates={{ drupal_core_path }}/vendor/autoload.php

includes/provisioning/tasks/drush.yml

@@ -6,7 +6,7 @@
     dest: /opt/drush
 
 - name: Install Drush dependencies with Composer.
-  shell: >
+  command: >
     /usr/local/bin/composer install
     chdir=/opt/drush
     creates=/opt/drush/vendor/autoload.php

includes/provisioning/tasks/mysql.yml

@@ -1,7 +1,4 @@
 ---
-- name: Remove the MySQL test database.
-  mysql_db: db=test state=absent
-
 - name: Create a MySQL database for Drupal.
   mysql_db: "db={{ domain }} state=present"
 

nodejs-role/playbook.yml

@@ -5,16 +5,16 @@
     node_apps_location: /usr/local/opt/node
 
   pre_tasks:
-    - name: Install Remi repo.
-      yum:
-        name: "https://rpms.remirepo.net/enterprise/remi-release-7.rpm"
-        state: present
-
     - name: Import Remi GPG key.
       rpm_key:
         key: "https://rpms.remirepo.net/RPM-GPG-KEY-remi"
         state: present
 
+    - name: Install Remi repo.
+      yum:
+        name: "https://rpms.remirepo.net/enterprise/remi-release-7.rpm"
+        state: present
+
     - name: Install EPEL repo.
       yum: name=epel-release state=present
 

nodejs/provisioning/playbook.yml

@@ -3,20 +3,19 @@
   become: yes
 
   vars:
-    # Vars can also be passed in via CLI with `--extra-vars="name=value"`.
     node_apps_location: /usr/local/opt/node
 
   tasks:
-    - name: Install Remi repo.
-      yum:
-        name: "https://rpms.remirepo.net/enterprise/remi-release-7.rpm"
-        state: present
-
     - name: Import Remi GPG key.
       rpm_key:
         key: "https://rpms.remirepo.net/RPM-GPG-KEY-remi"
         state: present
 
+    - name: Install Remi repo.
+      yum:
+        name: "https://rpms.remirepo.net/enterprise/remi-release-7.rpm"
+        state: present
+
     - name: Install EPEL repo.
       yum: name=epel-release state=present
 

solr/Vagrantfile

@@ -16,6 +16,5 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
   # Ansible provisioner.
   config.vm.provision :ansible do |ansible|
     ansible.playbook = "provisioning/playbook.yml"
-    ansible.become = true
   end
 end

solr/provisioning/playbook.yml

@@ -1,12 +1,13 @@
 ---
 - hosts: all
+  become: true
 
   vars_files:
     - vars.yml
 
   pre_tasks:
     - name: Update apt cache if needed.
-      apt: update_cache=yes cache_valid_time=3600
+      apt: update_cache=true cache_valid_time=3600
 
   handlers:
     - name: restart solr
@@ -30,7 +31,7 @@
         creates: "{{ download_dir }}/solr-{{ solr_version }}/README.txt"
 
     - name: Run Solr installation script.
-      shell: >
+      command: >
         {{ download_dir }}/solr-{{ solr_version }}/bin/install_solr_service.sh
         {{ download_dir }}/solr-{{ solr_version }}.tgz
         -i /opt

solr/provisioning/vars.yml

@@ -6,5 +6,5 @@ download_dir: /tmp
 solr_dir: /opt/solr
 
 # Solr version and download information.
-solr_version: 6.5.1
-solr_checksum: sha1:2cc43b837743949a46bd7efbab14b43f6d92b4b8
+solr_version: 8.2.0
+solr_checksum: sha512:beb4e37fc21bf483e3b6bae43cb06a49bc420a0f2b920c97909a69a5efeacba1e7d2ff09ae8018446c87bf007f88f06a59de73cd1923f0967e8206629b0509b6