You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function scatter_reduce_ has an optional argument include_self=True. In this case, it makes the max computation include a zero tensor that was just created by create_scatter_output. I don't think this was intended.
I noticed that the mesh quality is slightly worse in v1.1 compared to v1.0. After investigating to find the source of this difference, I discovered something in this file:
https://github.com/nv-tlabs/NKSR/blob/91b7e53f9f510b279070753d4c0ca952cd7b22c5/package/nksr/scatter.py#L51C1-L52C63
The function
scatter_reduce_
has an optional argumentinclude_self=True
. In this case, it makes the max computation include a zero tensor that was just created bycreate_scatter_output
. I don't think this was intended.I've made a fix here: jinhwanlazy@bf3c6eb#diff-3b9859e163f3217bc4b5d39dfede4b345d32ad1720a66fc2a077a070680c1bc5R48
I wanted to create a PR for this, but I couldn't because v1.1 isn't on any branch. So I'm leaving this issue here instead.
The text was updated successfully, but these errors were encountered: