Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Mesh quality degradation in v1.1 due to incorrect zero tensor inclusion in scatter_reduce_ #85

Open
jinhwanlazy opened this issue Dec 13, 2024 · 0 comments

Comments

@jinhwanlazy
Copy link

I noticed that the mesh quality is slightly worse in v1.1 compared to v1.0. After investigating to find the source of this difference, I discovered something in this file:
https://github.com/nv-tlabs/NKSR/blob/91b7e53f9f510b279070753d4c0ca952cd7b22c5/package/nksr/scatter.py#L51C1-L52C63

The function scatter_reduce_ has an optional argument include_self=True. In this case, it makes the max computation include a zero tensor that was just created by create_scatter_output. I don't think this was intended.

I've made a fix here: jinhwanlazy@bf3c6eb#diff-3b9859e163f3217bc4b5d39dfede4b345d32ad1720a66fc2a077a070680c1bc5R48

I wanted to create a PR for this, but I couldn't because v1.1 isn't on any branch. So I'm leaving this issue here instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant