Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid comment regarding the type of vertex data #34

Closed
mateuszradomski opened this issue Aug 28, 2021 · 2 comments
Closed

Invalid comment regarding the type of vertex data #34

mateuszradomski opened this issue Aug 28, 2021 · 2 comments

Comments

@mateuszradomski
Copy link

Hi,

I think it should be vec4 since we are defining a VK_FORMAT_R32G32B32A32_SFLOAT with 4 components. And because of that the comment is somewhat misleading.

triangles.vertexFormat = VK_FORMAT_R32G32B32A32_SFLOAT; // vec3 vertex position data.

@mklefrancois
Copy link
Collaborator

Thank you for reporting this. The vertex position is really a vec3, and therefore the vertexFormat should be VK_FORMAT_R32G32B32_SFLOAT. Fortunately the fourth component is ignored. I will fix this in this tutorial and the other ones as well.

@NBickford-NV
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants