Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raytrace.rgen in ray_tracing__advance #44

Closed
lukelmy opened this issue Nov 22, 2022 · 1 comment
Closed

Fix raytrace.rgen in ray_tracing__advance #44

lukelmy opened this issue Nov 22, 2022 · 1 comment

Comments

@lukelmy
Copy link

lukelmy commented Nov 22, 2022

According to ray_tracing_jitter_cam, we should write directly to the image if the frame number is equal to 0 in "raytrace.rgen".
ray_tracing_jitter_cam_shaders_raytrace rgen
However, there is an equal sign in "raytrace.rgen" of ray_tracing__advance, which may cause corruption.
ray_tracing__advance_shaders_raytrace rgen

@mklefrancois
Copy link
Collaborator

Thanks for reporting the issue. It works because when pcRay.frame ==0, a will be equal to 1.0F and the image will store only prd.hitValue. But to avoid any confusion and the unnecessary imageLoad, the code will be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants