Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify task-specific overrides. #604

Closed
sleepinyourhat opened this issue Apr 26, 2019 · 0 comments
Closed

Simplify task-specific overrides. #604

sleepinyourhat opened this issue Apr 26, 2019 · 0 comments
Assignees
@pruksmhc
Labels
cleanup This should be fairly easy jiant-v1-legacy Relevant to versions <= v1.3.2

Comments

@sleepinyourhat
Copy link
Contributor

The overrides of the form rte_classifier_hid_dim = 128 aren't really necessary, since we have the more general syntax seen here:

mnli-diagnostic { use_classifier = "mnli" }

Having both, especially having both in defaults.conf, is needlessly confusing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pruksmhc pruksmhc

Labels
cleanup This should be fairly easy jiant-v1-legacy Relevant to versions <= v1.3.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sleepinyourhat @pruksmhc @jeswan