Skip to content

Commit aafd758

Browse files
committed
util: Clean up includes
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
1 parent 9c05833 commit aafd758

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+50
-72
lines changed

util/acl.c

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
*/
2424

2525

26+
#include "qemu/osdep.h"
2627
#include "qemu-common.h"
2728
#include "qemu/acl.h"
2829

util/base64.c

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*
1919
*/
2020

21+
#include "qemu/osdep.h"
2122
#include <config-host.h>
2223

2324
#include "qemu/base64.h"

util/bitmap.c

+1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
* Version 2.
1010
*/
1111

12+
#include "qemu/osdep.h"
1213
#include "qemu/bitops.h"
1314
#include "qemu/bitmap.h"
1415
#include "qemu/atomic.h"

util/bitops.c

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
* 2 of the License, or (at your option) any later version.
1212
*/
1313

14+
#include "qemu/osdep.h"
1415
#include "qemu/bitops.h"
1516

1617
#define BITOP_WORD(nr) ((nr) / BITS_PER_LONG)

util/buffer.c

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*
1919
*/
2020

21+
#include "qemu/osdep.h"
2122
#include "qemu/buffer.h"
2223
#include "trace.h"
2324

util/compatfd.c

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* GNU GPL, version 2 or (at your option) any later version.
1414
*/
1515

16+
#include "qemu/osdep.h"
1617
#include "qemu-common.h"
1718
#include "qemu/compatfd.h"
1819
#include "qemu/thread.h"

util/coroutine-gthread.c

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
1919
*/
2020

21+
#include "qemu/osdep.h"
2122
#include <glib.h>
2223
#include "qemu-common.h"
2324
#include "qemu/coroutine_int.h"

util/coroutine-sigaltstack.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@
2525
#ifdef _FORTIFY_SOURCE
2626
#undef _FORTIFY_SOURCE
2727
#endif
28-
#include <stdlib.h>
28+
#include "qemu/osdep.h"
2929
#include <setjmp.h>
30-
#include <stdint.h>
3130
#include <pthread.h>
32-
#include <signal.h>
3331
#include "qemu-common.h"
3432
#include "qemu/coroutine_int.h"
3533

util/coroutine-ucontext.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@
2222
#ifdef _FORTIFY_SOURCE
2323
#undef _FORTIFY_SOURCE
2424
#endif
25-
#include <stdlib.h>
25+
#include "qemu/osdep.h"
2626
#include <setjmp.h>
27-
#include <stdint.h>
2827
#include <ucontext.h>
2928
#include "qemu-common.h"
3029
#include "qemu/coroutine_int.h"

util/coroutine-win32.c

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
* THE SOFTWARE.
2323
*/
2424

25+
#include "qemu/osdep.h"
2526
#include "qemu-common.h"
2627
#include "qemu/coroutine_int.h"
2728

util/crc32c.c

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
*
2626
*/
2727

28+
#include "qemu/osdep.h"
2829
#include "qemu-common.h"
2930
#include "qemu/crc32c.h"
3031

util/cutils.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,10 @@
2121
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2222
* THE SOFTWARE.
2323
*/
24+
#include "qemu/osdep.h"
2425
#include "qemu-common.h"
2526
#include "qemu/host-utils.h"
2627
#include <math.h>
27-
#include <limits.h>
28-
#include <errno.h>
2928

3029
#include "qemu/sockets.h"
3130
#include "qemu/iov.h"

util/envlist.c

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#include "qemu/osdep.h"
12
#include "qemu-common.h"
23
#include "qemu/queue.h"
34
#include "qemu/envlist.h"

util/error.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
* the COPYING.LIB file in the top-level directory.
1313
*/
1414

15+
#include "qemu/osdep.h"
1516
#include "qemu-common.h"
16-
#include "qapi/error.h"
1717
#include "qemu/error-report.h"
1818

1919
struct Error

util/event_notifier-posix.c

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
* See the COPYING file in the top-level directory.
1111
*/
1212

13+
#include "qemu/osdep.h"
1314
#include "qemu-common.h"
1415
#include "qemu/event_notifier.h"
1516
#include "sysemu/char.h"

util/event_notifier-win32.c

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
* See the COPYING file in the top-level directory.
1111
*/
1212

13+
#include "qemu/osdep.h"
1314
#include "qemu-common.h"
1415
#include "qemu/event_notifier.h"
1516
#include "qemu/main-loop.h"

util/fifo8.c

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
* with this program; if not, see <http://www.gnu.org/licenses/>.
1313
*/
1414

15+
#include "qemu/osdep.h"
1516
#include "qemu-common.h"
1617
#include "qemu/fifo8.h"
1718

util/getauxval.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
* THE SOFTWARE.
2323
*/
2424

25-
#include "qemu-common.h"
2625
#include "qemu/osdep.h"
26+
#include "qemu-common.h"
2727

2828
#ifdef CONFIG_GETAUXVAL
2929
/* Don't inline this in qemu/osdep.h, because pulling in <sys/auxv.h> for

util/hbitmap.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@
99
* later. See the COPYING file in the top-level directory.
1010
*/
1111

12-
#include <string.h>
13-
#include <glib.h>
14-
#include <assert.h>
1512
#include "qemu/osdep.h"
13+
#include <glib.h>
1614
#include "qemu/hbitmap.h"
1715
#include "qemu/host-utils.h"
1816
#include "trace.h"

util/hexdump.c

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* GNU GPL, version 2 or (at your option) any later version.
1414
*/
1515

16+
#include "qemu/osdep.h"
1617
#include "qemu-common.h"
1718

1819
void qemu_hexdump(const char *buf, FILE *fp, const char *prefix, size_t size)

util/host-utils.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
* THE SOFTWARE.
2424
*/
2525

26-
#include <stdlib.h>
27-
#include <stdint.h>
26+
#include "qemu/osdep.h"
2827
#include "qemu/host-utils.h"
2928

3029
/* Long integer helpers */

util/id.c

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
* or later. See the COPYING.LIB file in the top-level directory.
1111
*/
1212

13+
#include "qemu/osdep.h"
1314
#include "qemu-common.h"
1415

1516
bool id_wellformed(const char *id)

util/iov.c

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
* GNU GPL, version 2 or (at your option) any later version.
1717
*/
1818

19+
#include "qemu/osdep.h"
1920
#include "qemu/iov.h"
2021
#include "qemu/sockets.h"
2122

util/mmap-alloc.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@
99
* This work is licensed under the terms of the GNU GPL, version 2 or
1010
* later. See the COPYING file in the top-level directory.
1111
*/
12+
#include "qemu/osdep.h"
1213
#include <qemu/mmap-alloc.h>
13-
#include <sys/types.h>
1414
#include <sys/mman.h>
15-
#include <assert.h>
1615

1716
#define HUGETLBFS_MAGIC 0x958458f6
1817

util/module.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* GNU GPL, version 2 or (at your option) any later version.
1414
*/
1515

16-
#include <stdlib.h>
16+
#include "qemu/osdep.h"
1717
#include "qemu-common.h"
1818
#ifdef CONFIG_MODULES
1919
#include <gmodule.h>

util/notify.c

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* GNU GPL, version 2 or (at your option) any later version.
1414
*/
1515

16+
#include "qemu/osdep.h"
1617
#include "qemu-common.h"
1718
#include "qemu/notify.h"
1819

util/osdep.c

+1-10
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,15 @@
2121
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2222
* THE SOFTWARE.
2323
*/
24-
#include <stdlib.h>
25-
#include <stdio.h>
26-
#include <stdarg.h>
27-
#include <stdbool.h>
28-
#include <string.h>
29-
#include <errno.h>
30-
#include <unistd.h>
31-
#include <fcntl.h>
24+
#include "qemu/osdep.h"
3225

3326
/* Needed early for CONFIG_BSD etc. */
34-
#include "config-host.h"
3527

3628
#if defined(CONFIG_MADVISE) || defined(CONFIG_POSIX_MADVISE)
3729
#include <sys/mman.h>
3830
#endif
3931

4032
#ifdef CONFIG_SOLARIS
41-
#include <sys/types.h>
4233
#include <sys/statvfs.h>
4334
/* See MySQL bug #7156 (http://bugs.mysql.com/bug.php?id=7156) for
4435
discussion about Solaris header problems */

util/oslib-posix.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,12 @@ extern int daemon(int, int);
4747
# define QEMU_VMALLOC_ALIGN getpagesize()
4848
#endif
4949

50+
#include "qemu/osdep.h"
5051
#include <termios.h>
51-
#include <unistd.h>
5252
#include <termios.h>
5353

5454
#include <glib/gprintf.h>
5555

56-
#include "config-host.h"
5756
#include "sysemu/sysemu.h"
5857
#include "trace.h"
5958
#include "qemu/sockets.h"

util/oslib-win32.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,9 @@
2929
* this file are based on code from GNOME glib-2 and use a different license,
3030
* see the license comment there.
3131
*/
32+
#include "qemu/osdep.h"
3233
#include <windows.h>
3334
#include <glib.h>
34-
#include <stdlib.h>
35-
#include "config-host.h"
3635
#include "sysemu/sysemu.h"
3736
#include "qemu/main-loop.h"
3837
#include "trace.h"

util/path.c

+1-6
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,9 @@
33
44
The assumption is that this area does not change.
55
*/
6-
#include <sys/types.h>
6+
#include "qemu/osdep.h"
77
#include <sys/param.h>
88
#include <dirent.h>
9-
#include <unistd.h>
10-
#include <stdlib.h>
11-
#include <string.h>
12-
#include <errno.h>
13-
#include <stdio.h>
149
#include "qemu-common.h"
1510

1611
struct pathelem

util/qemu-config.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1+
#include "qemu/osdep.h"
12
#include "qemu-common.h"
23
#include "qemu/error-report.h"
34
#include "qemu/option.h"
45
#include "qemu/config-file.h"
5-
#include "qapi/error.h"
66
#include "qmp-commands.h"
77

88
static QemuOptsList *vm_config_groups[48];

util/qemu-coroutine-io.c

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2323
* THE SOFTWARE.
2424
*/
25+
#include "qemu/osdep.h"
2526
#include "qemu-common.h"
2627
#include "qemu/sockets.h"
2728
#include "qemu/coroutine.h"

util/qemu-coroutine-lock.c

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
* THE SOFTWARE.
2323
*/
2424

25+
#include "qemu/osdep.h"
2526
#include "qemu-common.h"
2627
#include "qemu/coroutine.h"
2728
#include "qemu/coroutine_int.h"

util/qemu-coroutine-sleep.c

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
*
1212
*/
1313

14+
#include "qemu/osdep.h"
1415
#include "qemu/coroutine.h"
1516
#include "qemu/timer.h"
1617
#include "block/aio.h"

util/qemu-coroutine.c

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
*
1313
*/
1414

15+
#include "qemu/osdep.h"
1516
#include "trace.h"
1617
#include "qemu-common.h"
1718
#include "qemu/thread.h"

util/qemu-error.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* See the COPYING file in the top-level directory.
1111
*/
1212

13-
#include <stdio.h>
13+
#include "qemu/osdep.h"
1414
#include "monitor/monitor.h"
1515
#include "qemu/error-report.h"
1616

util/qemu-openpty.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
* linked with -lutil.
3333
*/
3434

35-
#include "config-host.h"
35+
#include "qemu/osdep.h"
3636
#include "qemu-common.h"
3737

3838
#if defined(__GLIBC__)

util/qemu-option.c

+1-3
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@
2323
* THE SOFTWARE.
2424
*/
2525

26-
#include <stdio.h>
27-
#include <string.h>
26+
#include "qemu/osdep.h"
2827

2928
#include "qemu-common.h"
3029
#include "qemu/error-report.h"
3130
#include "qapi/qmp/types.h"
32-
#include "qapi/error.h"
3331
#include "qapi/qmp/qerror.h"
3432
#include "qemu/option_int.h"
3533

util/qemu-progress.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@
2222
* THE SOFTWARE.
2323
*/
2424

25-
#include "qemu-common.h"
2625
#include "qemu/osdep.h"
27-
#include <stdio.h>
26+
#include "qemu-common.h"
2827

2928
struct progress_state {
3029
float current;

0 commit comments

Comments
 (0)