From 0ce271c581e615a6f1bfbe092b0975b82c0190ea Mon Sep 17 00:00:00 2001
From: Ludwig Thufjell <ludwig.thurfjell@gmail.com>
Date: Tue, 10 Dec 2024 12:03:28 +0100
Subject: [PATCH] add missing for attributes to form inputs (#1303)

---
 .../[categoryId]/create-subcategory/page.tsx  | 12 ++++---
 .../[subcategoryId]/create-item/page.tsx      | 36 +++++++++++++++----
 2 files changed, 38 insertions(+), 10 deletions(-)

diff --git a/apps/dashboard-admin/app/[locale]/categories/[categoryId]/create-subcategory/page.tsx b/apps/dashboard-admin/app/[locale]/categories/[categoryId]/create-subcategory/page.tsx
index ace423143..9f83431e0 100644
--- a/apps/dashboard-admin/app/[locale]/categories/[categoryId]/create-subcategory/page.tsx
+++ b/apps/dashboard-admin/app/[locale]/categories/[categoryId]/create-subcategory/page.tsx
@@ -102,14 +102,16 @@ export default async function CreateItem(props: {
             {tForm("title")}
           </legend>
           <TextInput
-            label={{ text: tForm("en") }}
+            label={{ text: tForm("en"), htmlFor: "title_en" }}
             name='title_en'
+            id='title_en'
             required
             aria-label={tForm("titleLabelEn")}
           />
           <TextInput
-            label={{ text: tForm("ga") }}
+            label={{ text: tForm("ga"), htmlFor: "title_ga" }}
             name='title_ga'
+            id='title_ga'
             required
             aria-label={tForm("titleLabelGa")}
           />
@@ -128,13 +130,15 @@ export default async function CreateItem(props: {
           </legend>
 
           <TextInput
-            label={{ text: tForm("en") }}
+            label={{ text: tForm("en"), htmlFor: "text_en" }}
             name='text_en'
+            id='text_en'
             aria-label={tForm("textLabelEn")}
           />
           <TextInput
-            label={{ text: tForm("ga") }}
+            label={{ text: tForm("ga"), htmlFor: "text_ga" }}
             name='text_ga'
+            id='text_ga'
             aria-label={tForm("textLabelGa")}
           />
         </fieldset>
diff --git a/apps/dashboard-admin/app/[locale]/subcategories/[subcategoryId]/create-item/page.tsx b/apps/dashboard-admin/app/[locale]/subcategories/[subcategoryId]/create-item/page.tsx
index 70a12882c..ab3dc6cc8 100644
--- a/apps/dashboard-admin/app/[locale]/subcategories/[subcategoryId]/create-item/page.tsx
+++ b/apps/dashboard-admin/app/[locale]/subcategories/[subcategoryId]/create-item/page.tsx
@@ -287,9 +287,21 @@ export default async function CreateItem(props: {
           <legend style={{ fontSize: "18px", fontWeight: 600 }}>
             {tForm("link2")}
           </legend>
-          <TextInput label={{ text: tForm("en") }} name='1_link_name_en' />
-          <TextInput label={{ text: tForm("ga") }} name='1_link_name_ga' />
-          <TextInput label={{ text: tForm("href") }} name='1_link_href' />
+          <TextInput
+            label={{ text: tForm("en"), htmlFor: "1_link_name_en" }}
+            name='1_link_name_en'
+            id='1_link_name_en'
+          />
+          <TextInput
+            label={{ text: tForm("ga"), htmlFor: "1_link_name_ga" }}
+            name='1_link_name_ga'
+            id='1_link_name_ga'
+          />
+          <TextInput
+            label={{ text: tForm("href"), htmlFor: "1_link_href" }}
+            name='1_link_href'
+            id='1_link_href'
+          />
           <div className='govie-form-group'>
             <fieldset className='govie-fieldset'>
               <div className='govie-checkboxes govie-checkboxes--small'>
@@ -325,9 +337,21 @@ export default async function CreateItem(props: {
           <legend style={{ fontSize: "18px", fontWeight: 600 }}>
             {tForm("link3")}
           </legend>
-          <TextInput label={{ text: tForm("en") }} name='2_link_name_en' />
-          <TextInput label={{ text: tForm("ga") }} name='2_link_name_ga' />
-          <TextInput label={{ text: tForm("href") }} name='2_link_href' />
+          <TextInput
+            label={{ text: tForm("en"), htmlFor: "2_link_name_en" }}
+            name='2_link_name_en'
+            id='2_link_name_en'
+          />
+          <TextInput
+            label={{ text: tForm("ga"), htmlFor: "2_link_name_ga" }}
+            name='2_link_name_ga'
+            id='2_link_name_ga'
+          />
+          <TextInput
+            label={{ text: tForm("href"), htmlFor: "2_link_href" }}
+            name='2_link_href'
+            id='2_link_href'
+          />
           <div className='govie-form-group'>
             <fieldset className='govie-fieldset'>
               <div className='govie-checkboxes govie-checkboxes--small'>