test_lightningd.py

from concurrent import futures
from decimal import Decimal
from ephemeral_port_reserve import reserve as reserve_port
from flaky import flaky
from utils import wait_for

import copy
import json
import logging
import queue
import os
import random
import re
import shutil
import socket
import sqlite3
import stat
import string
import subprocess
import sys
import tempfile
import threading
import time
import unittest

import utils
from lightning import LightningRpc

with open('config.vars') as configfile:
    config = dict([(line.rstrip().split('=', 1)) for line in configfile])

bitcoind = None
TEST_DIR = tempfile.mkdtemp(prefix='lightning-')
VALGRIND = os.getenv("VALGRIND", config['VALGRIND']) == "1"
DEVELOPER = os.getenv("DEVELOPER", config['DEVELOPER']) == "1"
TEST_DEBUG = os.getenv("TEST_DEBUG", "0") == "1"


if TEST_DEBUG:
    logging.basicConfig(level=logging.DEBUG, stream=sys.stdout)
logging.info("Tests running in '%s'", TEST_DIR)


def to_json(arg):
    return json.loads(json.dumps(arg))


def setupBitcoind(directory):
    global bitcoind
    bitcoind = utils.BitcoinD(bitcoin_dir=directory, rpcport=None)

    try:
        bitcoind.start()
    except Exception:
        teardown_bitcoind()
        raise

    info = bitcoind.rpc.getnetworkinfo()

    if info['version'] < 160000:
        bitcoind.rpc.stop()
        raise ValueError("bitcoind is too old. At least version 16000 (v0.16.0)"
                         " is needed, current version is {}".format(info['version']))

    info = bitcoind.rpc.getblockchaininfo()
    # Make sure we have some spendable funds
    if info['blocks'] < 101:
        bitcoind.generate_block(101 - info['blocks'])
    elif bitcoind.rpc.getwalletinfo()['balance'] < 1:
        logging.debug("Insufficient balance, generating 1 block")
        bitcoind.generate_block(1)


def wait_forget_channels(node):
    """This node is closing all of its channels, check we are forgetting them
    """
    node.daemon.wait_for_log(r'onchaind complete, forgetting peer')
    # May have reconnected, but should merely be gossiping.
    for peer in node.rpc.listpeers()['peers']:
        assert peer['state'] == 'GOSSIPING'
    assert node.db_query("SELECT * FROM channels") == []


def sync_blockheight(nodes):
    target = bitcoind.rpc.getblockcount()
    for n in nodes:
        wait_for(lambda: n.rpc.getinfo()['blockheight'] == target)


def teardown_bitcoind():
    global bitcoind
    try:
        bitcoind.rpc.stop()
    except Exception:
        bitcoind.proc.kill()
    bitcoind.proc.wait()


class NodeFactory(object):
    """A factory to setup and start `lightningd` daemons.
    """
    def __init__(self, testname, bitcoind, executor, directory=None):
        self.testname = testname
        self.next_id = 1
        self.nodes = []
        self.executor = executor
        self.bitcoind = bitcoind
        if directory is not None:
            self.directory = directory
        else:
            self.directory = os.path.join(TEST_DIR, testname)
        self.lock = threading.Lock()

    def split_options(self, opts):
        """Split node options from cli options

        Some options are used to instrument the node wrapper and some are passed
        to the daemon on the command line. Split them so we know where to use
        them.
        """
        node_opt_keys = [
            'disconnect',
            'may_fail',
            'may_reconnect',
            'random_hsm',
            'fake_bitcoin_cli'
        ]
        node_opts = {k: v for k, v in opts.items() if k in node_opt_keys}
        cli_opts = {k: v for k, v in opts.items() if k not in node_opt_keys}
        return node_opts, cli_opts

    def get_next_port(self):
        with self.lock:
            return reserve_port()

    def get_nodes(self, num_nodes, opts=None):
        """Start a number of nodes in parallel, each with its own options
        """
        if opts is None:
            # No opts were passed in, give some dummy opts
            opts = [{} for _ in range(num_nodes)]
        elif isinstance(opts, dict):
            # A single dict was passed in, so we use these opts for all nodes
            opts = [opts] * num_nodes

        assert len(opts) == num_nodes

        jobs = []
        for i in range(num_nodes):
            node_opts, cli_opts = self.split_options(opts[i])
            jobs.append(self.executor.submit(self.get_node, options=cli_opts, **node_opts))

        return [j.result() for j in jobs]

    def get_node(self, disconnect=None, options=None, may_fail=False, may_reconnect=False, random_hsm=False, fake_bitcoin_cli=False):
        with self.lock:
            node_id = self.next_id
            self.next_id += 1
        port = self.get_next_port()

        lightning_dir = os.path.join(
            self.directory, "lightning-{}/".format(node_id))

        if os.path.exists(lightning_dir):
            shutil.rmtree(lightning_dir)

        socket_path = os.path.join(lightning_dir, "lightning-rpc").format(node_id)
        daemon = utils.LightningD(
            lightning_dir, self.bitcoind.bitcoin_dir,
            port=port, random_hsm=random_hsm, node_id=node_id
        )
        # If we have a disconnect string, dump it to a file for daemon.
        if disconnect:
            with open(os.path.join(lightning_dir, "dev_disconnect"), "w") as f:
                f.write("\n".join(disconnect))
            daemon.opts["dev-disconnect"] = "dev_disconnect"
        if DEVELOPER:
            daemon.opts["dev-fail-on-subdaemon-fail"] = None
            daemon.env["LIGHTNINGD_DEV_MEMLEAK"] = "1"
            if VALGRIND:
                daemon.env["LIGHTNINGD_DEV_NO_BACKTRACE"] = "1"
            if not may_reconnect:
                daemon.opts["dev-no-reconnect"] = None

        if fake_bitcoin_cli:
            cli = os.path.join(lightning_dir, "fake-bitcoin-cli")
            with open(cli, "w") as text_file:
                print("""#! /bin/sh
                ! [ -f bitcoin-cli-fail ] || exit `cat bitcoin-cli-fail`
                exec bitcoin-cli "$@"
                """, file=text_file)
            os.chmod(cli, os.stat(cli).st_mode | stat.S_IEXEC)
            daemon.opts['bitcoin-cli'] = cli

        if options is not None:
            daemon.opts.update(options)

        rpc = LightningRpc(socket_path, self.executor)

        node = utils.LightningNode(daemon, rpc, self.bitcoind, self.executor, may_fail=may_fail, may_reconnect=may_reconnect)
        self.nodes.append(node)
        if VALGRIND:
            node.daemon.cmd_prefix = [
                'valgrind',
                '-q',
                '--trace-children=yes',
                '--trace-children-skip=*bitcoin-cli*',
                '--error-exitcode=7',
                '--log-file={}/valgrind-errors.%p'.format(node.daemon.lightning_dir)
            ]

        try:
            node.start()
        except Exception:
            node.daemon.stop()
            raise

        # Cache `getinfo`, we'll be using it a lot
        node.info = node.rpc.getinfo()
        return node

    def killall(self, expected_successes):
        """Returns true if every node we expected to succeed actually succeeded"""
        unexpected_fail = False
        for i in range(len(self.nodes)):
            leaks = None
            # leak detection upsets VALGRIND by reading uninitialized mem.
            # If it's dead, we'll catch it below.
            if not VALGRIND:
                try:
                    # This also puts leaks in log.
                    leaks = self.nodes[i].rpc.dev_memleak()['leaks']
                except Exception:
                    pass

            try:
                self.nodes[i].stop()
            except Exception:
                if expected_successes[i]:
                    unexpected_fail = True

            if leaks is not None and len(leaks) != 0:
                raise Exception("Node {} has memory leaks: {}"
                                .format(self.nodes[i].daemon.lightning_dir, leaks))

        return not unexpected_fail


class BaseLightningDTests(unittest.TestCase):
    def setUp(self):
        bitcoin_dir = os.path.join(TEST_DIR, self._testMethodName, "bitcoind")
        setupBitcoind(bitcoin_dir)
        # Most of the executor threads will be waiting for IO, so
        # let's have a few of them
        self.executor = futures.ThreadPoolExecutor(max_workers=20)
        self.node_factory = NodeFactory(self._testMethodName, bitcoind, self.executor)

    def getValgrindErrors(self, node):
        for error_file in os.listdir(node.daemon.lightning_dir):
            if not re.fullmatch("valgrind-errors.\d+", error_file):
                continue
            with open(os.path.join(node.daemon.lightning_dir, error_file), 'r') as f:
                errors = f.read().strip()
                if errors:
                    return errors, error_file
        return None, None

    def printValgrindErrors(self, node):
        errors, fname = self.getValgrindErrors(node)
        if errors:
            print("-" * 31, "Valgrind errors", "-" * 32)
            print("Valgrind error file:", fname)
            print(errors)
            print("-" * 80)
        return 1 if errors else 0

    def getCrashLog(self, node):
        if node.may_fail:
            return None, None
        try:
            crashlog = os.path.join(node.daemon.lightning_dir, 'crash.log')
            with open(crashlog, 'r') as f:
                return f.readlines(), crashlog
        except Exception:
            return None, None

    def printCrashLog(self, node):
        errors, fname = self.getCrashLog(node)
        if errors:
            print("-" * 10, "{} (last 50 lines)".format(fname), "-" * 10)
            for l in errors[-50:]:
                print(l, end='')
            print("-" * 80)
        return 1 if errors else 0

    def checkReconnect(self, node):
        # Without DEVELOPER, we can't suppress reconnection.
        if node.may_reconnect or not DEVELOPER:
            return 0
        if node.daemon.is_in_log('Peer has reconnected'):
            return 1
        return 0

    def checkBadGossipOrder(self, node):
        # We can have a race where we notice a channel deleted and someone
        # sends an update, and we can get unknown channel updates in errors.
        if node.daemon.is_in_log('Bad gossip order from (?!error)') and not node.daemon.is_in_log('Deleting channel'):
            return 1
        return 0

    def tearDown(self):
        ok = self.node_factory.killall([not n.may_fail for n in self.node_factory.nodes])
        self.executor.shutdown(wait=False)

        teardown_bitcoind()
        err_count = 0
        # Do not check for valgrind error files if it is disabled
        if VALGRIND:
            for node in self.node_factory.nodes:
                err_count += self.printValgrindErrors(node)
            if err_count:
                raise ValueError("{} nodes reported valgrind errors".format(err_count))

        for node in self.node_factory.nodes:
            err_count += self.printCrashLog(node)
        if err_count:
            raise ValueError("{} nodes had crash.log files".format(err_count))

        for node in self.node_factory.nodes:
            err_count += self.checkReconnect(node)
        if err_count:
            raise ValueError("{} nodes had unexpected reconnections".format(err_count))

        for node in self.node_factory.nodes:
            err_count += self.checkBadGossipOrder(node)
        if err_count:
            raise ValueError("{} nodes had bad gossip order".format(err_count))

        if not ok:
            raise Exception("At least one lightning exited with unexpected non-zero return code")

        shutil.rmtree(self.node_factory.directory)


class LightningDTests(BaseLightningDTests):
    def connect(self, may_reconnect=False):
        l1, l2 = self.node_factory.get_nodes(2, opts={'may_reconnect': may_reconnect})
        ret = l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        assert ret['id'] == l2.info['id']

        l1.daemon.wait_for_log('Handing back peer .* to master')
        l2.daemon.wait_for_log('Handing back peer .* to master')
        return l1, l2

    # Waits until l1 notices funds
    def give_funds(self, l1, satoshi):
        addr = l1.rpc.newaddr()['address']
        bitcoind.rpc.sendtoaddress(addr, satoshi / 10**8)

        numfunds = len(l1.rpc.listfunds()['outputs'])
        bitcoind.generate_block(1)
        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) > numfunds)

    # Returns the short channel-id: <blocknum>:<txnum>:<outnum>
    def fund_channel(self, l1, l2, amount):
        return l1.fund_channel(l2, amount)

    def pay(self, lsrc, ldst, amt, label=None, async=False):
        if not label:
            label = ''.join(random.choice(string.ascii_letters + string.digits) for _ in range(20))

        rhash = ldst.rpc.invoice(amt, label, label)['payment_hash']
        assert ldst.rpc.listinvoices(label)['invoices'][0]['status'] == 'unpaid'

        routestep = {
            'msatoshi': amt,
            'id': ldst.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        def wait_pay():
            # Up to 10 seconds for payment to succeed.
            start_time = time.time()
            while ldst.rpc.listinvoices(label)['invoices'][0]['status'] != 'paid':
                if time.time() > start_time + 10:
                    raise TimeoutError('Payment timed out')
                time.sleep(0.1)
        # sendpay is async now
        lsrc.rpc.sendpay(to_json([routestep]), rhash)
        if async:
            return self.executor.submit(wait_pay)
        else:
            # wait for sendpay to comply
            lsrc.rpc.waitsendpay(rhash)

    # This waits until gossipd sees channel_update in both directions
    # (or for local channels, at least a local announcement)
    def wait_for_routes(self, l1, channel_ids):
        bitcoind.generate_block(5)
        # Could happen in any order...
        l1.daemon.wait_for_logs(['Received channel_update for channel {}\\(0\\)'.format(c)
                                 for c in channel_ids] +
                                ['Received channel_update for channel {}\\(1\\)'.format(c)
                                 for c in channel_ids])

    def fake_bitcoind_fail(self, l1, exitcode):
        # Create and rename, for atomicity.
        f = os.path.join(l1.daemon.lightning_dir, "bitcoin-cli-fail.tmp")
        with open(f, "w") as text_file:
            print(exitcode, file=text_file)
        os.rename(f, os.path.join(l1.daemon.lightning_dir, "bitcoin-cli-fail"))

    def fake_bitcoind_unfail(self, l1):
        os.remove(os.path.join(l1.daemon.lightning_dir, "bitcoin-cli-fail"))

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_shutdown(self):
        # Fail, in that it will exit before cleanup.
        l1 = self.node_factory.get_node(may_fail=True)
        if not VALGRIND:
            leaks = l1.rpc.dev_memleak()['leaks']
            if len(leaks):
                raise Exception("Node {} has memory leaks: {}"
                                .format(l1.daemon.lightning_dir, leaks))
        l1.rpc.stop()

    def test_autocleaninvoice(self):
        l1 = self.node_factory.get_node()

        start_time = time.time()
        l1.rpc.autocleaninvoice(cycle_seconds=8, expired_by=2)

        l1.rpc.invoice(msatoshi=12300, label='inv1', description='1', expiry=4)
        l1.rpc.invoice(msatoshi=12300, label='inv2', description='2', expiry=12)

        # time 0
        # Both should still be there.
        assert len(l1.rpc.listinvoices('inv1')['invoices']) == 1
        assert len(l1.rpc.listinvoices('inv2')['invoices']) == 1

        time.sleep(start_time - time.time() + 6)   # total 6
        # Both should still be there - auto clean cycle not started.
        # inv1 should be expired
        assert len(l1.rpc.listinvoices('inv1')['invoices']) == 1
        assert l1.rpc.listinvoices('inv1')['invoices'][0]['status'] == 'expired'
        assert len(l1.rpc.listinvoices('inv2')['invoices']) == 1
        assert l1.rpc.listinvoices('inv2')['invoices'][0]['status'] != 'expired'

        time.sleep(start_time - time.time() + 10)   # total 10
        # inv1 should have deleted, inv2 still there and unexpired.
        assert len(l1.rpc.listinvoices('inv1')['invoices']) == 0
        assert len(l1.rpc.listinvoices('inv2')['invoices']) == 1
        assert l1.rpc.listinvoices('inv2')['invoices'][0]['status'] != 'expired'

        time.sleep(start_time - time.time() + 14)   # total 14
        # inv2 should still be there, but expired
        assert len(l1.rpc.listinvoices('inv1')['invoices']) == 0
        assert len(l1.rpc.listinvoices('inv2')['invoices']) == 1
        assert l1.rpc.listinvoices('inv2')['invoices'][0]['status'] == 'expired'

        time.sleep(start_time - time.time() + 18)   # total 18
        # Everything deleted
        assert len(l1.rpc.listinvoices('inv1')['invoices']) == 0
        assert len(l1.rpc.listinvoices('inv2')['invoices']) == 0

    def test_invoice_preimage(self):
        """Test explicit invoice 'preimage'.
        """
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)

        # I promise the below number is randomly generated
        invoice_preimage = "17b08f669513b7379728fc1abcea5eaf3448bc1eba55a68ca2cd1843409cdc04"

        # Make invoice and pay it
        inv = l2.rpc.invoice(msatoshi=123456, label="inv", description="?", preimage=invoice_preimage)
        payment = l1.rpc.pay(inv['bolt11'])

        # Check preimage was given.
        payment_preimage = payment['payment_preimage']
        assert invoice_preimage == payment_preimage

        # Creating a new invoice with same preimage should error.
        self.assertRaisesRegex(ValueError,
                               "preimage already used",
                               l2.rpc.invoice, 123456, 'inv2', '?',
                               None, None, invoice_preimage)

    def test_names(self):
        for key, alias, color in [('0266e4598d1d3c415f572a8488830b60f7e744ed9235eb0b1ba93283b315c03518', 'JUNIORBEAM', '0266e4'),
                                  ('022d223620a359a47ff7f7ac447c85c46c923da53389221a0054c11c1e3ca31d59', 'SILENTARTIST', '022d22'),
                                  ('035d2b1192dfba134e10e540875d366ebc8bc353d5aa766b80c090b39c3a5d885d', 'HOPPINGFIRE', '035d2b'),
                                  ('0382ce59ebf18be7d84677c2e35f23294b9992ceca95491fcf8a56c6cb2d9de199', 'JUNIORFELONY', '0382ce'),
                                  ('032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e', 'SOMBERFIRE', '032cf1'),
                                  ('0265b6ab5ec860cd257865d61ef0bbf5b3339c36cbda8b26b74e7f1dca490b6518', 'LOUDPHOTO', '0265b6')]:
            n = self.node_factory.get_node()
            assert n.daemon.is_in_log('public key {}, alias {}.* \(color #{}\)'
                                      .format(key, alias, color))

    def test_invoice(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()

        addr1 = l2.rpc.newaddr('bech32')['address']
        addr2 = l2.rpc.newaddr('p2sh-segwit')['address']
        before = int(time.time())
        inv = l1.rpc.invoice(123000, 'label', 'description', '3700', [addr1, addr2])
        after = int(time.time())
        b11 = l1.rpc.decodepay(inv['bolt11'])
        assert b11['currency'] == 'bcrt'
        assert b11['created_at'] >= before
        assert b11['created_at'] <= after
        assert b11['payment_hash'] == inv['payment_hash']
        assert b11['description'] == 'description'
        assert b11['expiry'] == 3700
        assert b11['payee'] == l1.info['id']
        assert len(b11['fallbacks']) == 2
        assert b11['fallbacks'][0]['addr'] == addr1
        assert b11['fallbacks'][0]['type'] == 'P2WPKH'
        assert b11['fallbacks'][1]['addr'] == addr2
        assert b11['fallbacks'][1]['type'] == 'P2SH'

        # Check pay_index is null
        outputs = l1.db_query('SELECT pay_index IS NULL AS q FROM invoices WHERE label="label";')
        assert len(outputs) == 1 and outputs[0]['q'] != 0

        # Check any-amount invoice
        inv = l1.rpc.invoice("any", 'label2', 'description2')
        b11 = inv['bolt11']
        # Amount usually comes after currency (bcrt in our case),
        # but an any-amount invoices will have no amount
        assert b11.startswith("lnbcrt1")
        # By bech32 rules, the last '1' digit is the separator
        # between the human-readable and data parts. We want
        # to match the "lnbcrt1" above with the '1' digit as the
        # separator, and not for example "lnbcrt1m1....".
        assert b11.count('1') == 1

    def test_invoice_weirdstring(self):
        l1 = self.node_factory.get_node()

        weird_label = 'label \\ " \t \n'
        weird_desc = 'description \\ " \t \n'
        l1.rpc.invoice(123000, weird_label, weird_desc)
        # FIXME: invoice RPC should return label!

        # Can find by this label.
        inv = l1.rpc.listinvoices(weird_label)['invoices'][0]
        assert inv['label'] == weird_label

        # Can find this in list.
        inv = l1.rpc.listinvoices()['invoices'][0]
        assert inv['label'] == weird_label

        b11 = l1.rpc.decodepay(inv['bolt11'])
        assert b11['description'] == weird_desc

        # Can delete by weird label.
        l1.rpc.delinvoice(weird_label, "unpaid")

        # We can also use numbers as labels.
        weird_label = 25
        weird_desc = '"'
        l1.rpc.invoice(123000, weird_label, weird_desc)
        # FIXME: invoice RPC should return label!

        # Can find by this label.
        inv = l1.rpc.listinvoices(weird_label)['invoices'][0]
        assert inv['label'] == str(weird_label)

        # Can find this in list.
        inv = l1.rpc.listinvoices()['invoices'][0]
        assert inv['label'] == str(weird_label)

        b11 = l1.rpc.decodepay(inv['bolt11'])
        assert b11['description'] == weird_desc

        # Can delete by weird label.
        l1.rpc.delinvoice(weird_label, "unpaid")

    def test_invoice_expiry(self):
        l1, l2 = self.connect()

        chanid = self.fund_channel(l1, l2, 10**6)

        # Wait for route propagation.
        self.wait_for_routes(l1, [chanid])

        inv = l2.rpc.invoice(msatoshi=123000, label='test_pay', description='description', expiry=1)['bolt11']
        time.sleep(2)
        self.assertRaises(ValueError, l1.rpc.pay, inv)
        assert l2.rpc.listinvoices('test_pay')['invoices'][0]['status'] == 'expired'
        assert l2.rpc.listinvoices('test_pay')['invoices'][0]['expires_at'] < time.time()

        # Try deleting it.
        self.assertRaisesRegex(ValueError,
                               'Invoice status is expired not unpaid',
                               l2.rpc.delinvoice,
                               'test_pay', 'unpaid')
        self.assertRaisesRegex(ValueError,
                               'Invoice status is expired not paid',
                               l2.rpc.delinvoice,
                               'test_pay', 'paid')
        l2.rpc.delinvoice('test_pay', 'expired')

        self.assertRaisesRegex(ValueError,
                               'Unknown invoice',
                               l2.rpc.delinvoice,
                               'test_pay', 'expired')

        # Test expiration waiting.
        # The second invoice created expires first.
        l2.rpc.invoice('any', 'inv1', 'description', 10)
        l2.rpc.invoice('any', 'inv2', 'description', 4)
        l2.rpc.invoice('any', 'inv3', 'description', 16)
        creation = int(time.time())
        # Check waitinvoice correctly waits
        w1 = self.executor.submit(l2.rpc.waitinvoice, 'inv1')
        w2 = self.executor.submit(l2.rpc.waitinvoice, 'inv2')
        w3 = self.executor.submit(l2.rpc.waitinvoice, 'inv3')
        time.sleep(2)  # total 2
        assert not w1.done()
        assert not w2.done()
        assert not w3.done()
        time.sleep(4)  # total 6
        assert not w1.done()
        self.assertRaises(ValueError, w2.result)
        assert not w3.done()
        time.sleep(6)  # total 12
        self.assertRaises(ValueError, w1.result)
        assert not w3.done()
        time.sleep(8)  # total 20
        self.assertRaises(ValueError, w3.result)

        # Test delexpiredinvoice
        l2.rpc.delexpiredinvoice(maxexpirytime=creation + 8)
        # only inv2 should have been deleted
        assert len(l2.rpc.listinvoices()['invoices']) == 2
        assert len(l2.rpc.listinvoices('inv2')['invoices']) == 0
        # Test delexpiredinvoice all
        l2.rpc.delexpiredinvoice()
        # all invoices are expired and should be deleted
        assert len(l2.rpc.listinvoices()['invoices']) == 0

    def test_connect(self):
        l1, l2 = self.connect()

        # These should be in gossipd.
        assert l1.rpc.getpeer(l2.info['id'])['state'] == 'GOSSIPING'
        assert l2.rpc.getpeer(l1.info['id'])['state'] == 'GOSSIPING'

        # Both gossipds will have them as new peers once handed back.
        l1.daemon.wait_for_log('hand_back_peer {}: now local again'.format(l2.info['id']))
        l2.daemon.wait_for_log('hand_back_peer {}: now local again'.format(l1.info['id']))

        # Reconnect should be a noop
        ret = l1.rpc.connect(l2.info['id'], 'localhost', port=l2.port)
        assert ret['id'] == l2.info['id']

        ret = l2.rpc.connect(l1.info['id'], host='localhost', port=l1.port)
        assert ret['id'] == l1.info['id']

        # Should still only have one peer!
        assert len(l1.rpc.listpeers()) == 1
        assert len(l2.rpc.listpeers()) == 1

        # Should get reasonable error if unknown addr for peer.
        self.assertRaisesRegex(ValueError,
                               "No address known",
                               l1.rpc.connect, '032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e')

        # Should get reasonable error if connection refuse.
        self.assertRaisesRegex(ValueError,
                               "Connection establishment: Connection refused",
                               l1.rpc.connect, '032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e', 'localhost', 1)

        # Should get reasonable error if wrong key for peer.
        self.assertRaisesRegex(ValueError,
                               "Cryptographic handshake: ",
                               l1.rpc.connect, '032cf15d1ad9c4a08d26eab1918f732d8ef8fdc6abb9640bf3db174372c491304e', 'localhost', l2.port)

    @unittest.skipIf(not DEVELOPER, "needs --dev-allow-localhost")
    def test_connect_by_gossip(self):
        """Test connecting to an unknown peer using node gossip
        """
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()

        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)

        # Nodes are gossiped only if they have channels
        chanid = self.fund_channel(l2, l3, 10**6)
        # Let channel reach announcement depth
        self.wait_for_routes(l2, [chanid])
        # Make sure l3 has given node announcement to l2.
        l2.daemon.wait_for_logs(['Received node_announcement for node {}'.format(l3.info['id'])])

        # Let l1 learn of l3 by node gossip
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.daemon.wait_for_logs(['Received node_announcement for node {}'.format(l3.info['id'])])

        # Have l1 connect to l3 without explicit host and port.
        l1.rpc.connect(l3.info['id'])

    def test_connect_standard_addr(self):
        """Test standard node@host:port address
        """
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()

        # node@host
        ret = l1.rpc.connect("{}@{}".format(l2.info['id'], 'localhost'), port=l2.port)
        assert ret['id'] == l2.info['id']

        # node@host:port
        ret = l1.rpc.connect("{}@localhost:{}".format(l3.info['id'], l3.port))
        assert ret['id'] == l3.info['id']

        # node@[ipv6]:port --- not supported by our CI
        # ret = l1.rpc.connect("{}@[::1]:{}".format(l3.info['id'], l3.port))
        # assert ret['id'] == l3.info['id']

    def test_reconnect_channel_peers(self):
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)
        l2.restart()

        # Should reconnect.
        wait_for(lambda: l1.rpc.listpeers(l2.info['id'])['peers'][0]['connected'])
        wait_for(lambda: l2.rpc.listpeers(l1.info['id'])['peers'][0]['connected'])
        # Connect command should succeed.
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Stop l2 and wait for l1 to notice.
        l2.stop()
        wait_for(lambda: not l1.rpc.listpeers(l2.info['id'])['peers'][0]['connected'])

        # Now should fail.
        self.assertRaisesRegex(ValueError,
                               "Connection refused",
                               l1.rpc.connect, l2.info['id'], 'localhost', l2.port)

        # Wait for exponential backoff to give us a 2 second window.
        l1.daemon.wait_for_log('...will try again in 2 seconds')

        # It should now succeed when it restarts.
        l2.start()

        # Multiples should be fine!
        fut1 = self.executor.submit(l1.rpc.connect, l2.info['id'], 'localhost', l2.port)
        fut2 = self.executor.submit(l1.rpc.connect, l2.info['id'], 'localhost', l2.port)
        fut3 = self.executor.submit(l1.rpc.connect, l2.info['id'], 'localhost', l2.port)
        fut1.result(10)
        fut2.result(10)
        fut3.result(10)

    def test_balance(self):
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)
        p1 = l1.rpc.getpeer(peer_id=l2.info['id'], level='info')['channels'][0]
        p2 = l2.rpc.getpeer(l1.info['id'], 'info')['channels'][0]
        assert p1['msatoshi_to_us'] == 10**6 * 1000
        assert p1['msatoshi_total'] == 10**6 * 1000
        assert p2['msatoshi_to_us'] == 0
        assert p2['msatoshi_total'] == 10**6 * 1000

    def test_decodepay(self):
        l1 = self.node_factory.get_node()

        # BOLT #11:
        # > ### Please make a donation of any amount using payment_hash 0001020304050607080900010203040506070809000102030405060708090102 to me @03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad
        # > lnbc1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdpl2pkx2ctnv5sxxmmwwd5kgetjypeh2ursdae8g6twvus8g6rfwvs8qun0dfjkxaq8rkx3yf5tcsyz3d73gafnh3cax9rn449d9p5uxz9ezhhypd0elx87sjle52x86fux2ypatgddc6k63n7erqz25le42c4u4ecky03ylcqca784w
        #
        # Breakdown:
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash
        #   * `p5`: `data_length` (`p` = 1, `5` = 20. 1 * 32 + 20 == 52)
        #   * `qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypq`: payment hash 0001020304050607080900010203040506070809000102030405060708090102
        # * `d`: short description
        #   * `pl`: `data_length` (`p` = 1, `l` = 31. 1 * 32 + 31 == 63)
        #   * `2pkx2ctnv5sxxmmwwd5kgetjypeh2ursdae8g6twvus8g6rfwvs8qun0dfjkxaq`: 'Please consider supporting this project'
        # * `32vjcgqxyuj7nqphl3xmmhls2rkl3t97uan4j0xa87gj5779czc8p0z58zf5wpt9ggem6adl64cvawcxlef9djqwp2jzzfvs272504sp`: signature
        # * `0lkg3c`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdpl2pkx2ctnv5sxxmmwwd5kgetjypeh2ursdae8g6twvus8g6rfwvs8qun0dfjkxaq8rkx3yf5tcsyz3d73gafnh3cax9rn449d9p5uxz9ezhhypd0elx87sjle52x86fux2ypatgddc6k63n7erqz25le42c4u4ecky03ylcqca784w')
        assert b11['currency'] == 'bc'
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['description'] == 'Please consider supporting this project'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'

        # BOLT #11:
        # > ### Please send $3 for a cup of coffee to the same peer, within 1 minute
        # > lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpuaztrnwngzn3kdzw5hydlzf03qdgm2hdq27cqv3agm2awhz5se903vruatfhq77w3ls4evs3ch9zw97j25emudupq63nyw24cg27h2rspfj9srp
        #
        # Breakdown:
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `2500u`: amount (2500 micro-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `d`: short description
        #   * `q5`: `data_length` (`q` = 0, `5` = 20. 0 * 32 + 20 == 20)
        #   * `xysxxatsyp3k7enxv4js`: '1 cup coffee'
        # * `x`: expiry time
        #   * `qz`: `data_length` (`q` = 0, `z` = 2. 0 * 32 + 2 == 2)
        #   * `pu`: 60 seconds (`p` = 1, `u` = 28.  1 * 32 + 28 == 60)
        # * `azh8qt5w7qeewkmxtv55khqxvdfs9zzradsvj7rcej9knpzdwjykcq8gv4v2dl705pjadhpsc967zhzdpuwn5qzjm0s4hqm2u0vuhhqq`: signature
        # * `7vc09u`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc2500u1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqdq5xysxxatsyp3k7enxv4jsxqzpuaztrnwngzn3kdzw5hydlzf03qdgm2hdq27cqv3agm2awhz5se903vruatfhq77w3ls4evs3ch9zw97j25emudupq63nyw24cg27h2rspfj9srp')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 2500 * 10**11 // 1000000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['description'] == '1 cup coffee'
        assert b11['expiry'] == 60
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'

        # BOLT #11:
        # > ### Now send $24 for an entire list of things (hashed)
        # > lnbc20m1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqscc6gd6ql3jrc5yzme8v4ntcewwz5cnw92tz0pc8qcuufvq7khhr8wpald05e92xw006sq94mg8v2ndf4sefvf9sygkshp5zfem29trqq2yxxz7
        #
        # Breakdown:
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `h`: tagged field: hash of description
        # * `p5`: `data_length` (`p` = 1, `5` = 20. 1 * 32 + 20 == 52)
        # * `8yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqs`: SHA256 of 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon'
        # * `vjfls3ljx9e93jkw0kw40yxn4pevgzflf83qh2852esjddv4xk4z70nehrdcxa4fk0t6hlcc6vrxywke6njenk7yzkzw0quqcwxphkcp`: signature
        # * `vam37w`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc20m1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqscc6gd6ql3jrc5yzme8v4ntcewwz5cnw92tz0pc8qcuufvq7khhr8wpald05e92xw006sq94mg8v2ndf4sefvf9sygkshp5zfem29trqq2yxxz7', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'

        # > ### The same, on testnet, with a fallback address mk2QpYatsKicvFVuTAQLBryyccRXMUaGHP
        # > lntb20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfpp3x9et2e20v6pu37c5d9vax37wxq72un98kmzzhznpurw9sgl2v0nklu2g4d0keph5t7tj9tcqd8rexnd07ux4uv2cjvcqwaxgj7v4uwn5wmypjd5n69z2xm3xgksg28nwht7f6zspwp3f9t
        #
        # Breakdown:
        #
        # * `lntb`: prefix, lightning on bitcoin testnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `f`: tagged field: fallback address
        # * `pp`: `data_length` (`p` = 1. 1 * 32 + 1 == 33)
        # * `3x9et2e20v6pu37c5d9vax37wxq72un98`: `3` = 17, so P2PKH address
        # * `h`: tagged field: hash of description...
        # * `qh84fmvn2klvglsjxfy0vq2mz6t9kjfzlxfwgljj35w2kwa60qv49k7jlsgx43yhs9nuutllkhhnt090mmenuhp8ue33pv4klmrzlcqp`: signature
        # * `us2s2r`: Bech32 checksum
        b11 = l1.rpc.decodepay('lntb20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfpp3x9et2e20v6pu37c5d9vax37wxq72un98kmzzhznpurw9sgl2v0nklu2g4d0keph5t7tj9tcqd8rexnd07ux4uv2cjvcqwaxgj7v4uwn5wmypjd5n69z2xm3xgksg28nwht7f6zspwp3f9t', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'tb'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'
        assert b11['fallbacks'][0]['type'] == 'P2PKH'
        assert b11['fallbacks'][0]['addr'] == 'mk2QpYatsKicvFVuTAQLBryyccRXMUaGHP'

        # > ### On mainnet, with fallback address 1RustyRX2oai4EYYDpQGWvEL62BBGqN9T with extra routing info to go via nodes 029e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255 then 039e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255
        # > lnbc20m1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqsfpp3qjmp7lwpagxun9pygexvgpjdc4jdj85fr9yq20q82gphp2nflc7jtzrcazrra7wwgzxqc8u7754cdlpfrmccae92qgzqvzq2ps8pqqqqqqpqqqqq9qqqvpeuqafqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqgqqqqq7qqzqj9n4evl6mr5aj9f58zp6fyjzup6ywn3x6sk8akg5v4tgn2q8g4fhx05wf6juaxu9760yp46454gpg5mtzgerlzezqcqvjnhjh8z3g2qqdhhwkj
        #
        # Breakdown:
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `h`: tagged field: hash of description...
        # * `f`: tagged field: fallback address
        #   * `pp`: `data_length` (`p` = 1. 1 * 32 + 1 == 33)
        #   * `3` = 17, so P2PKH address
        #   * `qjmp7lwpagxun9pygexvgpjdc4jdj85f`: 160 bit P2PKH address
        # * `r`: tagged field: route information
        #   * `9y`: `data_length` (`9` = 5, `y` = 4.  5 * 32 + 4 = 164)
        #     `q20q82gphp2nflc7jtzrcazrra7wwgzxqc8u7754cdlpfrmccae92qgzqvzq2ps8pqqqqqqqqqqqq9qqqvpeuqafqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqqqqqqq7qqzq`: pubkey `029e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255`, `short_channel_id` 0102030405060708, `fee_base_msat` 1 millisatoshi, `fee_proportional_millionths` 20, `cltv_expiry_delta` 3.  pubkey `039e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255`, `short_channel_id` 030405060708090a, `fee_base_msat` 2 millisatoshi, `fee_proportional_millionths` 30, `cltv_expiry_delta` 4.
        # * `j9n4evl6mr5aj9f58zp6fyjzup6ywn3x6sk8akg5v4tgn2q8g4fhx05wf6juaxu9760yp46454gpg5mtzgerlzezqcqvjnhjh8z3g2qq`: signature
        # * `dhhwkj`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc20m1pvjluezpp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqsfpp3qjmp7lwpagxun9pygexvgpjdc4jdj85fr9yq20q82gphp2nflc7jtzrcazrra7wwgzxqc8u7754cdlpfrmccae92qgzqvzq2ps8pqqqqqqpqqqqq9qqqvpeuqafqxu92d8lr6fvg0r5gv0heeeqgcrqlnm6jhphu9y00rrhy4grqszsvpcgpy9qqqqqqgqqqqq7qqzqj9n4evl6mr5aj9f58zp6fyjzup6ywn3x6sk8akg5v4tgn2q8g4fhx05wf6juaxu9760yp46454gpg5mtzgerlzezqcqvjnhjh8z3g2qqdhhwkj', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'
        assert b11['fallbacks'][0]['type'] == 'P2PKH'
        assert b11['fallbacks'][0]['addr'] == '1RustyRX2oai4EYYDpQGWvEL62BBGqN9T'
        assert len(b11['routes']) == 1
        assert len(b11['routes'][0]) == 2
        assert b11['routes'][0][0]['pubkey'] == '029e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255'
        # 0x010203:0x040506:0x0708
        assert b11['routes'][0][0]['short_channel_id'] == '66051:263430:1800'
        assert b11['routes'][0][0]['fee_base_msat'] == 1
        assert b11['routes'][0][0]['fee_proportional_millionths'] == 20
        assert b11['routes'][0][0]['cltv_expiry_delta'] == 3

        assert b11['routes'][0][1]['pubkey'] == '039e03a901b85534ff1e92c43c74431f7ce72046060fcf7a95c37e148f78c77255'
        # 0x030405:0x060708:0x090a
        assert b11['routes'][0][1]['short_channel_id'] == '197637:395016:2314'
        assert b11['routes'][0][1]['fee_base_msat'] == 2
        assert b11['routes'][0][1]['fee_proportional_millionths'] == 30
        assert b11['routes'][0][1]['cltv_expiry_delta'] == 4

        # > ### On mainnet, with fallback (P2SH) address 3EktnHQD7RiAE6uzMj2ZifT9YgRrkSgzQX
        # > lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfppj3a24vwu6r8ejrss3axul8rxldph2q7z9kmrgvr7xlaqm47apw3d48zm203kzcq357a4ls9al2ea73r8jcceyjtya6fu5wzzpe50zrge6ulk4nvjcpxlekvmxl6qcs9j3tz0469gq5g658y
        #
        # Breakdown:
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `f`: tagged field: fallback address.
        # * `pp`: `data_length` (`p` = 1. 1 * 32 + 1 == 33)
        # * `j3a24vwu6r8ejrss3axul8rxldph2q7z9`: `j` = 18, so P2SH address
        # * `h`: tagged field: hash of description...
        # * `2jhz8j78lv2jynuzmz6g8ve53he7pheeype33zlja5azae957585uu7x59w0f2l3rugyva6zpu394y4rh093j6wxze0ldsvk757a9msq`: signature
        # * `mf9swh`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfppj3a24vwu6r8ejrss3axul8rxldph2q7z9kmrgvr7xlaqm47apw3d48zm203kzcq357a4ls9al2ea73r8jcceyjtya6fu5wzzpe50zrge6ulk4nvjcpxlekvmxl6qcs9j3tz0469gq5g658y', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'
        assert b11['fallbacks'][0]['type'] == 'P2SH'
        assert b11['fallbacks'][0]['addr'] == '3EktnHQD7RiAE6uzMj2ZifT9YgRrkSgzQX'

        # > ### On mainnet, with fallback (P2WPKH) address bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4
        # > lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfppqw508d6qejxtdg4y5r3zarvary0c5xw7kepvrhrm9s57hejg0p662ur5j5cr03890fa7k2pypgttmh4897d3raaq85a293e9jpuqwl0rnfuwzam7yr8e690nd2ypcq9hlkdwdvycqa0qza8
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `f`: tagged field: fallback address.
        # * `pp`: `data_length` (`p` = 1. 1 * 32 + 1 == 33)
        # * `q`: 0, so witness version 0.
        # * `qw508d6qejxtdg4y5r3zarvary0c5xw7k`: 160 bits = P2WPKH.
        # * `h`: tagged field: hash of description...
        # * `gw6tk8z0p0qdy9ulggx65lvfsg3nxxhqjxuf2fvmkhl9f4jc74gy44d5ua9us509prqz3e7vjxrftn3jnk7nrglvahxf7arye5llphgq`: signature
        # * `qdtpa4`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfppqw508d6qejxtdg4y5r3zarvary0c5xw7kepvrhrm9s57hejg0p662ur5j5cr03890fa7k2pypgttmh4897d3raaq85a293e9jpuqwl0rnfuwzam7yr8e690nd2ypcq9hlkdwdvycqa0qza8', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'
        assert b11['fallbacks'][0]['type'] == 'P2WPKH'
        assert b11['fallbacks'][0]['addr'] == 'bc1qw508d6qejxtdg4y5r3zarvary0c5xw7kv8f3t4'

        # > ### On mainnet, with fallback (P2WSH) address bc1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3qccfmv3
        # > lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfp4qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3q28j0v3rwgy9pvjnd48ee2pl8xrpxysd5g44td63g6xcjcu003j3qe8878hluqlvl3km8rm92f5stamd3jw763n3hck0ct7p8wwj463cql26ava
        #
        # * `lnbc`: prefix, lightning on bitcoin mainnet
        # * `20m`: amount (20 milli-bitcoin)
        # * `1`: Bech32 separator
        # * `pvjluez`: timestamp (1496314658)
        # * `p`: payment hash...
        # * `f`: tagged field: fallback address.
        # * `p4`: `data_length` (`p` = 1, `4` = 21. 1 * 32 + 21 == 53)
        # * `q`: 0, so witness version 0.
        # * `rp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3q`: 260 bits = P2WSH.
        # * `h`: tagged field: hash of description...
        # * `5yps56lmsvgcrf476flet6js02m93kgasews8q3jhtp7d6cqckmh70650maq4u65tk53ypszy77v9ng9h2z3q3eqhtc3ewgmmv2grasp`: signature
        # * `akvd7y`: Bech32 checksum
        b11 = l1.rpc.decodepay('lnbc20m1pvjluezhp58yjmdan79s6qqdhdzgynm4zwqd5d7xmw5fk98klysy043l2ahrqspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypqfp4qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3q28j0v3rwgy9pvjnd48ee2pl8xrpxysd5g44td63g6xcjcu003j3qe8878hluqlvl3km8rm92f5stamd3jw763n3hck0ct7p8wwj463cql26ava', 'One piece of chocolate cake, one icecream cone, one pickle, one slice of swiss cheese, one slice of salami, one lollypop, one piece of cherry pie, one sausage, one cupcake, and one slice of watermelon')
        assert b11['currency'] == 'bc'
        assert b11['msatoshi'] == 20 * 10**11 // 1000
        assert b11['created_at'] == 1496314658
        assert b11['payment_hash'] == '0001020304050607080900010203040506070809000102030405060708090102'
        assert b11['expiry'] == 3600
        assert b11['payee'] == '03e7156ae33b0a208d0744199163177e909e80176e55d97a2f221ede0f934dd9ad'
        assert b11['fallbacks'][0]['type'] == 'P2WSH'
        assert b11['fallbacks'][0]['addr'] == 'bc1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3qccfmv3'

        self.assertRaises(ValueError, l1.rpc.decodepay, '1111111')

    def test_sendpay(self):
        l1, l2 = self.connect()

        self.fund_channel(l1, l2, 10**6)

        amt = 200000000
        rhash = l2.rpc.invoice(amt, 'testpayment2', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        routestep = {
            'msatoshi': amt,
            'id': l2.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        # Insufficient funds.
        rs = copy.deepcopy(routestep)
        rs['msatoshi'] = rs['msatoshi'] - 1
        l1.rpc.sendpay(to_json([rs]), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        # Gross overpayment (more than factor of 2)
        rs = copy.deepcopy(routestep)
        rs['msatoshi'] = rs['msatoshi'] * 2 + 1
        l1.rpc.sendpay(to_json([rs]), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        # Insufficient delay.
        rs = copy.deepcopy(routestep)
        rs['delay'] = rs['delay'] - 2
        l1.rpc.sendpay(to_json([rs]), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        # Bad ID.
        rs = copy.deepcopy(routestep)
        rs['id'] = '00000000000000000000000000000000'
        self.assertRaises(ValueError, l1.rpc.sendpay, to_json([rs]), rhash)
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        # FIXME: test paying via another node, should fail to pay twice.
        p1 = l1.rpc.getpeer(l2.info['id'], 'info')
        p2 = l2.rpc.getpeer(l1.info['id'], 'info')
        assert p1['channels'][0]['msatoshi_to_us'] == 10**6 * 1000
        assert p1['channels'][0]['msatoshi_total'] == 10**6 * 1000
        assert p2['channels'][0]['msatoshi_to_us'] == 0
        assert p2['channels'][0]['msatoshi_total'] == 10**6 * 1000

        # This works.
        before = int(time.time())
        details = l1.rpc.sendpay(to_json([routestep]), rhash)
        after = int(time.time())
        preimage = l1.rpc.waitsendpay(rhash)['payment_preimage']
        # Check details
        assert details['payment_hash'] == rhash
        assert details['destination'] == l2.info['id']
        assert details['msatoshi'] == amt
        assert details['created_at'] >= before
        assert details['created_at'] <= after
        # Check receiver
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'paid'
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['pay_index'] == 1
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['msatoshi_received'] == rs['msatoshi']

        # Balances should reflect it.
        def check_balances():
            p1 = l1.rpc.getpeer(l2.info['id'], 'info')
            p2 = l2.rpc.getpeer(l1.info['id'], 'info')
            return (
                p1['channels'][0]['msatoshi_to_us'] == 10**6 * 1000 - amt and
                p1['channels'][0]['msatoshi_total'] == 10**6 * 1000 and
                p2['channels'][0]['msatoshi_to_us'] == amt and
                p2['channels'][0]['msatoshi_total'] == 10**6 * 1000
            )
        wait_for(check_balances)

        # Repeat will "succeed", but won't actually send anything (duplicate)
        assert not l1.daemon.is_in_log('... succeeded')
        details = l1.rpc.sendpay(to_json([routestep]), rhash)
        assert details['status'] == "complete"
        preimage2 = details['payment_preimage']
        assert preimage == preimage2
        l1.daemon.wait_for_log('... succeeded')
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'paid'
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['msatoshi_received'] == rs['msatoshi']

        # Overpaying by "only" a factor of 2 succeeds.
        rhash = l2.rpc.invoice(amt, 'testpayment3', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('testpayment3')['invoices'][0]['status'] == 'unpaid'
        routestep = {'msatoshi': amt * 2, 'id': l2.info['id'], 'delay': 5, 'channel': '1:1:1'}
        l1.rpc.sendpay(to_json([routestep]), rhash)
        preimage3 = l1.rpc.waitsendpay(rhash)['payment_preimage']
        assert l2.rpc.listinvoices('testpayment3')['invoices'][0]['status'] == 'paid'
        assert l2.rpc.listinvoices('testpayment3')['invoices'][0]['msatoshi_received'] == amt * 2

        # Test listpayments
        payments = l1.rpc.listpayments()['payments']
        assert len(payments) == 2

        invoice2 = l2.rpc.listinvoices('testpayment2')['invoices'][0]
        payments = l1.rpc.listpayments(payment_hash=invoice2['payment_hash'])['payments']
        assert len(payments) == 1

        assert payments[0]['status'] == 'complete'
        assert payments[0]['payment_preimage'] == preimage2

        invoice3 = l2.rpc.listinvoices('testpayment3')['invoices'][0]
        payments = l1.rpc.listpayments(payment_hash=invoice3['payment_hash'])['payments']
        assert len(payments) == 1

        assert payments[0]['status'] == 'complete'
        assert payments[0]['payment_preimage'] == preimage3

    def test_sendpay_cant_afford(self):
        l1, l2 = self.connect()

        # Note, this is in SATOSHI, rest are in MILLISATOSHI!
        self.fund_channel(l1, l2, 10**6)

        # Can't pay more than channel capacity.
        self.assertRaises(ValueError, self.pay, l1, l2, 10**9 + 1)

        # This is the fee, which needs to be taken into account for l1.
        available = 10**9 - 6720
        # Reserve is 1%.
        reserve = 10**7

        # Can't pay past reserve.
        self.assertRaises(ValueError, self.pay, l1, l2, available)
        self.assertRaises(ValueError, self.pay, l1, l2, available - reserve + 1)

        # Can pay up to reserve (1%)
        self.pay(l1, l2, available - reserve)

        # And now it can't pay back, due to its own reserve.
        self.assertRaises(ValueError, self.pay, l2, l1, available - reserve)

        # But this should work.
        self.pay(l2, l1, available - reserve * 2)

    def test_pay0(self):
        """Test paying 0 amount
        """
        l1, l2 = self.connect()
        # Set up channel.
        chanid = self.fund_channel(l1, l2, 10**6)
        self.wait_for_routes(l1, [chanid])

        # Get any-amount invoice
        inv = l2.rpc.invoice("any", "any", 'description')
        rhash = inv['payment_hash']

        routestep = {
            'msatoshi': 0,
            'id': l2.info['id'],
            'delay': 10,
            'channel': chanid
        }

        # Amount must be nonzero!
        l1.rpc.sendpay(to_json([routestep]), rhash)
        self.assertRaisesRegex(ValueError, 'WIRE_AMOUNT_BELOW_MINIMUM',
                               l1.rpc.waitsendpay, rhash)

    def test_pay(self):
        l1, l2 = self.connect()
        chanid = self.fund_channel(l1, l2, 10**6)

        # Wait for route propagation.
        self.wait_for_routes(l1, [chanid])
        sync_blockheight([l1, l2])

        inv = l2.rpc.invoice(123000, 'test_pay', 'description')['bolt11']
        before = int(time.time())
        details = l1.rpc.pay(inv)
        after = int(time.time())
        preimage = details['payment_preimage']
        assert details['status'] == 'complete'
        assert details['msatoshi'] == 123000
        assert details['destination'] == l2.info['id']
        assert details['created_at'] >= before
        assert details['created_at'] <= after

        invoice = l2.rpc.listinvoices('test_pay')['invoices'][0]
        assert invoice['status'] == 'paid'
        assert invoice['paid_at'] >= before
        assert invoice['paid_at'] <= after

        # Repeat payments are NOPs (if valid): we can hand null.
        l1.rpc.pay(inv)
        # This won't work: can't provide an amount (even if correct!)
        self.assertRaises(ValueError, l1.rpc.pay, inv, 123000)
        self.assertRaises(ValueError, l1.rpc.pay, inv, 122000)

        # Check pay_index is not null
        outputs = l2.db_query('SELECT pay_index IS NOT NULL AS q FROM invoices WHERE label="label";')
        assert len(outputs) == 1 and outputs[0]['q'] != 0

        # Check payment of any-amount invoice.
        for i in range(5):
            label = "any{}".format(i)
            inv2 = l2.rpc.invoice("any", label, 'description')['bolt11']
            # Must provide an amount!
            self.assertRaises(ValueError, l1.rpc.pay, inv2)
            l1.rpc.pay(inv2, random.randint(1000, 999999))

        # Should see 6 completed payments
        assert len(l1.rpc.listpayments()['payments']) == 6

        # Test listpayments indexed by bolt11.
        assert len(l1.rpc.listpayments(inv)['payments']) == 1
        assert l1.rpc.listpayments(inv)['payments'][0]['payment_preimage'] == preimage

    def test_pay_optional_args(self):
        l1, l2 = self.connect()

        chanid = self.fund_channel(l1, l2, 10**6)

        # Wait for route propagation.
        self.wait_for_routes(l1, [chanid])

        inv1 = l2.rpc.invoice(123000, 'test_pay', '1000')['bolt11']
        l1.rpc.pay(inv1, description='1000')
        payment1 = l1.rpc.listpayments(inv1)['payments']
        assert len(payment1) == 1 and payment1[0]['msatoshi'] == 123000

        inv2 = l2.rpc.invoice(321000, 'test_pay2', 'description')['bolt11']
        l1.rpc.pay(inv2, riskfactor=5.0)
        payment2 = l1.rpc.listpayments(inv2)['payments']
        assert len(payment2) == 1 and payment2[0]['msatoshi'] == 321000

        anyinv = l2.rpc.invoice('any', 'any_pay', 'description')['bolt11']
        l1.rpc.pay(anyinv, description='1000', msatoshi='500')
        payment3 = l1.rpc.listpayments(anyinv)['payments']
        assert len(payment3) == 1 and payment3[0]['msatoshi'] == 500

        # Should see 3 completed transactions
        assert len(l1.rpc.listpayments()['payments']) == 3

    # Long test involving 4 lightningd instances.
    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_report_routing_failure(self):
        """Test routing failure and retrying of routing.
        """
        # The setup is as follows:
        #   l3-->l4
        #   ^   / |
        #   |  /  |
        #   | L   v
        #   l2<--l1
        #
        # l1 wants to pay to l4.
        # The shortest route is l1-l4, but l1 cannot
        # afford to pay to l1 because l4 has all the
        # funds.
        # This is a local failure.
        # The next shortest route is l1-l2-l4, but
        # l2 cannot afford to pay l4 for same reason.
        # This is a remote failure.
        # Finally the only possible path is
        # l1-l2-l3-l4.

        def fund_from_to_payer(lsrc, ldst, lpayer):
            lsrc.rpc.connect(ldst.info['id'], 'localhost', ldst.port)
            c = self.fund_channel(lsrc, ldst, 10000000)
            self.wait_for_routes(lpayer, [c])

        # Setup
        # Construct lightningd
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()
        l4 = self.node_factory.get_node()

        # Wire them up
        # The ordering below matters!
        # Particularly, l1 is payer and we will
        # wait for l1 to receive gossip for the
        # channel being made.
        fund_from_to_payer(l1, l2, l1)
        fund_from_to_payer(l2, l3, l1)
        fund_from_to_payer(l3, l4, l1)
        fund_from_to_payer(l4, l1, l1)
        fund_from_to_payer(l4, l2, l1)

        # Test
        inv = l4.rpc.invoice(1234567, 'inv', 'for testing')['bolt11']
        l1.rpc.pay(inv)

    def test_bad_opening(self):
        # l1 asks for a too-long locktime
        l1 = self.node_factory.get_node(options={'watchtime-blocks': 100})
        l2 = self.node_factory.get_node(options={'max-locktime-blocks': 99})
        ret = l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        assert ret['id'] == l2.info['id']

        l1.daemon.wait_for_log('Handing back peer .* to master')
        l2.daemon.wait_for_log('Handing back peer .* to master')

        self.give_funds(l1, 10**6 + 1000000)
        self.assertRaises(ValueError, l1.rpc.fundchannel, l2.info['id'], 10**6)

        l2.daemon.wait_for_log('to_self_delay 100 larger than 99')

    @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll")
    def test_closing(self):
        l1, l2 = self.connect()

        chan = self.fund_channel(l1, l2, 10**6)
        self.pay(l1, l2, 200000000)

        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 0

        billboard = l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status']
        assert billboard == ['CHANNELD_NORMAL:Funding transaction locked.']
        billboard = l2.rpc.listpeers(l1.info['id'])['peers'][0]['channels'][0]['status']
        assert billboard == ['CHANNELD_NORMAL:Funding transaction locked.']

        l1.bitcoin.rpc.generate(5)

        # Only wait for the channels to activate with DEVELOPER=1,
        # otherwise it's going to take too long because of the missing
        # --dev-broadcast-interval
        if DEVELOPER:
            wait_for(lambda: len(l1.getactivechannels()) == 2)
            wait_for(lambda: len(l2.getactivechannels()) == 2)
            billboard = l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status']
            # This may either be from a local_update or an announce, so just
            # check for the substring
            assert 'CHANNELD_NORMAL:Funding transaction locked.' in billboard[0]

        # This should return with an error, then close.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chan, False, 0)
        l1.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')
        l2.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')

        l1.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')
        l2.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')

        # And should put closing into mempool.
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # Both nodes should have disabled the channel in their view
        wait_for(lambda: len(l1.getactivechannels()) == 0)
        wait_for(lambda: len(l2.getactivechannels()) == 0)

        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 1

        # Now grab the close transaction
        closetxid = l1.bitcoin.rpc.getrawmempool(False)[0]

        billboard = l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status']
        assert billboard == ['CLOSINGD_SIGEXCHANGE:We agreed on a closing fee of 5430 satoshi']
        l1.bitcoin.rpc.generate(1)

        l1.daemon.wait_for_log(r'Owning output .* txid %s' % closetxid)
        l2.daemon.wait_for_log(r'Owning output .* txid %s' % closetxid)

        # Make sure both nodes have grabbed their close tx funds
        assert closetxid in set([o['txid'] for o in l1.rpc.listfunds()['outputs']])
        assert closetxid in set([o['txid'] for o in l2.rpc.listfunds()['outputs']])

        wait_for(lambda: l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status'] == ['CLOSINGD_SIGEXCHANGE:We agreed on a closing fee of 5430 satoshi', 'ONCHAIN:Tracking mutual close transaction', 'ONCHAIN:All outputs resolved: waiting 99 more blocks before forgetting channel'])

        l1.bitcoin.rpc.generate(9)
        wait_for(lambda: l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status'] == ['CLOSINGD_SIGEXCHANGE:We agreed on a closing fee of 5430 satoshi', 'ONCHAIN:Tracking mutual close transaction', 'ONCHAIN:All outputs resolved: waiting 90 more blocks before forgetting channel'])

        # Make sure both have forgotten about it
        l1.bitcoin.rpc.generate(90)
        wait_forget_channels(l1)
        wait_forget_channels(l2)

    def test_closing_while_disconnected(self):
        l1, l2 = self.connect(may_reconnect=True)

        chan = self.fund_channel(l1, l2, 10**6)
        self.pay(l1, l2, 200000000)

        l2.stop()

        # The close should still be triggered afterwards.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chan, False, 0)
        l1.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')

        l2.start()
        l1.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')
        l2.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')

        # And should put closing into mempool.
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.rpc.generate(101)
        wait_forget_channels(l1)
        wait_forget_channels(l2)

    def test_db_upgrade(self):
        l1 = self.node_factory.get_node()
        l1.stop()

        version = subprocess.check_output(['lightningd/lightningd',
                                           '--version']).decode('utf-8').splitlines()[0]

        upgrades = l1.db_query("SELECT * from db_upgrades;")
        assert len(upgrades) == 1
        assert(upgrades[0]['upgrade_from'] == -1)
        assert(upgrades[0]['lightning_version'] == version)

        # Try resetting to earlier db state.
        os.unlink(os.path.join(l1.daemon.lightning_dir, "lightningd.sqlite3"))
        l1.db_manip("CREATE TABLE version (version INTEGER);")
        l1.db_manip("INSERT INTO version VALUES (1);")

        l1.start()
        upgrades = l1.db_query("SELECT * from db_upgrades;")
        assert len(upgrades) == 1
        assert(upgrades[0]['upgrade_from'] == 1)
        assert(upgrades[0]['lightning_version'] == version)

    def test_bitcoin_failure(self):
        l1 = self.node_factory.get_node(fake_bitcoin_cli=True)

        # Make sure we're not failing it between getblockhash and getblock.
        sync_blockheight([l1])

        self.fake_bitcoind_fail(l1, 1)

        # This should cause both estimatefee and getblockhash fail
        l1.daemon.wait_for_logs(['estimatesmartfee .* exited with status 1',
                                 'getblockhash .* exited with status 1'])

        # And they should retry!
        l1.daemon.wait_for_logs(['estimatesmartfee .* exited with status 1',
                                 'getblockhash .* exited with status 1'])

        # Restore, then it should recover and get blockheight.
        self.fake_bitcoind_unfail(l1)
        bitcoind.generate_block(5)
        sync_blockheight([l1])

    @unittest.skipIf(not DEVELOPER, "needs dev-rescan-outputs")
    def test_closing_torture(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()

        amount = 10**6
        self.give_funds(l1, amount + 10**7)

        # The range below of 15 is unsatisfactory.
        # Before the fix was applied, 15 would often pass.
        # However, increasing the number of tries would
        # take longer in VALGRIND mode, triggering a CI
        # failure since the test does not print any
        # output.
        for i in range(15):
            # Reduce probability that spurious sendrawtx error will occur
            l1.rpc.dev_rescan_outputs()

            # Create a channel.
            l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
            l1.rpc.fundchannel(l2.info['id'], amount)
            l1.daemon.wait_for_log('sendrawtx exit 0')
            # Get it confirmed.
            l1.bitcoin.generate_block(6)
            # Wait for it to go to CHANNELD_NORMAL
            l1.daemon.wait_for_logs(['to CHANNELD_NORMAL'])
            l2.daemon.wait_for_logs(['to CHANNELD_NORMAL'])

            # Start closers.
            c1 = self.executor.submit(l1.rpc.close, l2.info['id'])
            c2 = self.executor.submit(l2.rpc.close, l1.info['id'])
            # Wait for close to finish
            c1.result(utils.TIMEOUT)
            c2.result(utils.TIMEOUT)
            l1.daemon.wait_for_log('sendrawtx exit 0')
            # Get close confirmed
            l1.bitcoin.generate_block(100)

    @unittest.skipIf(not DEVELOPER, "needs dev-override-feerates")
    def test_closing_different_fees(self):
        l1 = self.node_factory.get_node()

        # Default feerate = 15000/7500/1000
        # It will start at the second number, accepting anything above the first.
        feerates = [[20000, 15000, 7400], [8000, 1001, 100]]
        amounts = [0, 545999, 546000]
        num_peers = len(feerates) * len(amounts)
        self.give_funds(l1, (10**6) * num_peers + 10000 * num_peers)

        # Create them in a batch, for speed!
        peers = []
        for feerate in feerates:
            for amount in amounts:
                p = self.node_factory.get_node(options={
                    'dev-override-fee-rates': '{}/{}/{}'.format(feerate[0],
                                                                feerate[1],
                                                                feerate[2])
                })
                p.feerate = feerate
                p.amount = amount
                l1.rpc.connect(p.info['id'], 'localhost', p.port)
                peers.append(p)

        for p in peers:
            p.channel = l1.rpc.fundchannel(p.info['id'], 10**6)['channel_id']
            # Technically, this is async to fundchannel returning.
            l1.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.generate_block(6)

        # Now wait for them all to hit normal state, do payments
        l1.daemon.wait_for_logs(['update for channel .* now ACTIVE'] * num_peers +
                                ['to CHANNELD_NORMAL'] * num_peers)
        for p in peers:
            if p.amount != 0:
                self.pay(l1, p, 100000000)

        # Now close all channels
        # All closes occur in parallel, and on Travis,
        # ALL those lightningd are running on a single core,
        # so increase the timeout so that this test will pass
        # when valgrind is enabled.
        # (close timeout defaults to 30 as of this writing)
        closes = [self.executor.submit(l1.rpc.close, p.channel, False, 90) for p in peers]

        for c in closes:
            c.result(90)

        # close does *not* wait for the sendrawtransaction, so do that!
        # Note that since they disagree on the ideal fee, they may conflict
        # (first one in will win), so we cannot look at logs, we need to
        # wait for mempool.
        wait_for(lambda: bitcoind.rpc.getmempoolinfo()['size'] == num_peers)

        bitcoind.generate_block(1)
        for p in peers:
            p.daemon.wait_for_log(' to ONCHAIN')
            wait_for(lambda: p.rpc.listpeers(l1.info['id'])['peers'][0]['channels'][0]['status'][1] == 'ONCHAIN:Tracking mutual close transaction')
        l1.daemon.wait_for_logs([' to ONCHAIN'] * num_peers)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_permfail(self):
        l1, l2 = self.connect()

        self.fund_channel(l1, l2, 10**6)

        # The funding change should be confirmed and our only output
        assert [o['status'] for o in l1.rpc.listfunds()['outputs']] == ['confirmed']
        self.pay(l1, l2, 200000000)

        # Make sure l2 has received sig with 0 htlcs!
        l2.daemon.wait_for_log('Received commit_sig with 0 htlc sigs')

        # Make sure l1 has final revocation.
        l1.daemon.wait_for_log('Sending commit_sig with 0 htlc sigs')
        l1.daemon.wait_for_log('peer_in WIRE_REVOKE_AND_ACK')

        # We fail l2, so l1 will reconnect to it.
        l2.rpc.dev_fail(l1.info['id'])
        l2.daemon.wait_for_log('Failing due to dev-fail command')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 1

        # Now grab the close transaction
        closetxid = l1.bitcoin.rpc.getrawmempool(False)[0]

        # l2 will send out tx (l1 considers it a transient error)
        bitcoind.generate_block(1)

        l1.daemon.wait_for_log('Their unilateral tx, old commit point')
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET (.*) after 5 blocks')

        wait_for(lambda: l1.rpc.listpeers(l2.info['id'])['peers'][0]['channels'][0]['status'] ==
                 ['ONCHAIN:Tracking their unilateral close',
                  'ONCHAIN:All outputs resolved: waiting 99 more blocks before forgetting channel'])

        def check_billboard():
            billboard = l2.rpc.listpeers(l1.info['id'])['peers'][0]['channels'][0]['status']
            return (
                len(billboard) == 2 and
                billboard[0] == 'ONCHAIN:Tracking our own unilateral close' and
                re.fullmatch('ONCHAIN:.* outputs unresolved: in 4 blocks will spend DELAYED_OUTPUT_TO_US \(.*:0\) using OUR_DELAYED_RETURN_TO_WALLET', billboard[1])
            )
        wait_for(check_billboard)

        # Now, mine 4 blocks so it sends out the spending tx.
        bitcoind.generate_block(4)

        # It should send the to-wallet tx.
        l2.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # 100 after l1 sees tx, it should be done.
        bitcoind.generate_block(95)
        wait_forget_channels(l1)

        wait_for(lambda: l2.rpc.listpeers(l1.info['id'])['peers'][0]['channels'][0]['status'] == ['ONCHAIN:Tracking our own unilateral close', 'ONCHAIN:All outputs resolved: waiting 5 more blocks before forgetting channel'])

        # Now, 100 blocks l2 should be done.
        bitcoind.generate_block(5)
        wait_forget_channels(l2)

        # Only l1 has a direct output since all of l2's outputs are respent (it
        # failed). Also the output should now be listed as confirmed since we
        # generated some more blocks.
        assert (closetxid, "confirmed") in set([(o['txid'], o['status']) for o in l1.rpc.listfunds()['outputs']])

        addr = l1.bitcoin.rpc.getnewaddress()
        l1.rpc.withdraw(addr, "all")

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_first_commit(self):
        """Onchain handling where funder immediately drops to chain"""

        # HTLC 1->2, 1 fails just after funding.
        disconnects = ['+WIRE_FUNDING_LOCKED', 'permfail']
        l1 = self.node_factory.get_node(disconnect=disconnects)
        # Make locktime different, as we once had them reversed!
        l2 = self.node_factory.get_node(options={'watchtime-blocks': 10})

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.give_funds(l1, 10**6 + 1000000)

        l1.rpc.fundchannel(l2.info['id'], 10**6)
        l1.daemon.wait_for_log('sendrawtx exit 0')

        l1.bitcoin.generate_block(1)

        # l1 will drop to chain.
        l1.daemon.wait_for_log('permfail')
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # 10 later, l1 should collect its to-self payment.
        bitcoind.generate_block(10)
        l1.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_UNILATERAL/DELAYED_OUTPUT_TO_US')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # 94 later, l2 is done.
        bitcoind.generate_block(94)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Now, 100 blocks and l1 should be done.
        bitcoind.generate_block(6)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_unwatch(self):
        """Onchaind should not watch random spends"""
        l1, l2 = self.connect()

        self.fund_channel(l1, l2, 10**6)
        self.pay(l1, l2, 200000000)

        l1.rpc.dev_fail(l2.info['id'])
        l1.daemon.wait_for_log('Failing due to dev-fail command')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # 10 later, l1 should collect its to-self payment.
        bitcoind.generate_block(10)
        l1.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve '
                               'OUR_UNILATERAL/DELAYED_OUTPUT_TO_US')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # First time it sees it, onchaind cares.
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('Resolved OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by our proposal '
                               'OUR_DELAYED_RETURN_TO_WALLET')

        # Now test unrelated onchain churn.
        # Daemon gets told about wallet; says it doesn't care.
        l1.rpc.withdraw(l1.rpc.newaddr()['address'], 'all')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log("but we don't care")

        # And lightningd should respect that!
        assert not l1.daemon.is_in_log("Can't unwatch txid")

        # So these should not generate further messages
        for i in range(5):
            l1.rpc.withdraw(l1.rpc.newaddr()['address'], 'all')
            bitcoind.generate_block(1)
            # Make sure it digests the block
            sync_blockheight([l1])

        # We won't see this again.
        assert not l1.daemon.is_in_log("but we don't care",
                                       start=l1.daemon.logsearch_start)

        # Note: for this test we leave onchaind running, so we can detect
        # any leaks!

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchaind_replay(self):
        disconnects = ['+WIRE_REVOKE_AND_ACK', 'permfail']
        options = {'watchtime-blocks': 201, 'cltv-delta': 101}
        l1 = self.node_factory.get_node(options=options, disconnect=disconnects)
        l2 = self.node_factory.get_node(options=options)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        rhash = l2.rpc.invoice(10**8, 'onchaind_replay', 'desc')['payment_hash']
        routestep = {
            'msatoshi': 10**8 - 1,
            'id': l2.info['id'],
            'delay': 101,
            'channel': '1:1:1'
        }
        l1.rpc.sendpay(to_json([routestep]), rhash)
        l1.daemon.wait_for_log(r'Disabling channel')
        bitcoind.rpc.generate(1)

        # Wait for nodes to notice the failure, this seach needle is after the
        # DB commit so we're sure the tx entries in onchaindtxs have been added
        l1.daemon.wait_for_log("Deleting channel .* due to the funding outpoint being spent")
        l2.daemon.wait_for_log("Deleting channel .* due to the funding outpoint being spent")

        # We should at least have the init tx now
        assert len(l1.db_query("SELECT * FROM channeltxs;")) > 0
        assert len(l2.db_query("SELECT * FROM channeltxs;")) > 0

        # Generate some blocks so we restart the onchaind from DB (we rescan
        # last_height - 100)
        bitcoind.rpc.generate(100)
        sync_blockheight([l1, l2])

        # l1 should still have a running onchaind
        assert len(l1.db_query("SELECT * FROM channeltxs;")) > 0

        l2.rpc.stop()
        l1.restart()

        # Can't wait for it, it's after the "Server started" wait in restart()
        assert l1.daemon.is_in_log(r'Restarting onchaind for channel')

        # l1 should still notice that the funding was spent and that we should react to it
        l1.daemon.wait_for_log("Propose handling OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET")
        sync_blockheight([l1])
        bitcoind.rpc.generate(10)
        sync_blockheight([l1])

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_dust_out(self):
        """Onchain handling of outgoing dust htlcs (they should fail)"""
        # HTLC 1->2, 1 fails after it's irrevocably committed
        disconnects = ['@WIRE_REVOKE_AND_ACK', 'permfail']
        l1 = self.node_factory.get_node(disconnect=disconnects)
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        # Must be dust!
        rhash = l2.rpc.invoice(1, 'onchain_dust_out', 'desc')['payment_hash']
        routestep = {
            'msatoshi': 1,
            'id': l2.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        l1.rpc.sendpay(to_json([routestep]), rhash)
        payfuture = self.executor.submit(l1.rpc.waitsendpay, rhash)

        # l1 will drop to chain.
        l1.daemon.wait_for_log('permfail')
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # We use 3 blocks for "reasonable depth"
        bitcoind.generate_block(3)

        # It should fail.
        self.assertRaises(ValueError, payfuture.result, 5)

        l1.daemon.wait_for_log('WIRE_PERMANENT_CHANNEL_FAILURE: missing in commitment tx')

        # Retry payment, this should fail (and, as a side-effect, tickle a
        # bug).
        self.assertRaisesRegex(ValueError, 'WIRE_UNKNOWN_NEXT_PEER',
                               l1.rpc.sendpay, to_json([routestep]), rhash)

        # 6 later, l1 should collect its to-self payment.
        bitcoind.generate_block(6)
        l1.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_UNILATERAL/DELAYED_OUTPUT_TO_US')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # 94 later, l2 is done.
        bitcoind.generate_block(94)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Restart l1, it should not crash!
        l1.restart()

        # Now, 100 blocks and l1 should be done.
        bitcoind.generate_block(6)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Payment failed, BTW
        assert l2.rpc.listinvoices('onchain_dust_out')['invoices'][0]['status'] == 'unpaid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_timeout(self):
        """Onchain handling of outgoing failed htlcs"""
        # HTLC 1->2, 1 fails just after it's irrevocably committed
        disconnects = ['+WIRE_REVOKE_AND_ACK', 'permfail']
        l1 = self.node_factory.get_node(disconnect=disconnects)
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        rhash = l2.rpc.invoice(10**8, 'onchain_timeout', 'desc')['payment_hash']
        # We underpay, so it fails.
        routestep = {
            'msatoshi': 10**8 - 1,
            'id': l2.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        l1.rpc.sendpay(to_json([routestep]), rhash)
        payfuture = self.executor.submit(l1.rpc.waitsendpay, rhash)

        # l1 will drop to chain.
        l1.daemon.wait_for_log('permfail')
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # Wait for timeout.
        l1.daemon.wait_for_logs(['Propose handling OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks',
                                 'Propose handling OUR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TX .* after 6 blocks'])
        bitcoind.generate_block(4)

        l1.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # We use 3 blocks for "reasonable depth"
        bitcoind.generate_block(3)

        # It should fail.
        self.assertRaises(ValueError, payfuture.result, 5)

        l1.daemon.wait_for_log('WIRE_PERMANENT_CHANNEL_FAILURE: timed out')

        # 2 later, l1 spends HTLC (5 blocks total).
        bitcoind.generate_block(2)
        l1.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_HTLC_TIMEOUT_TX/DELAYED_OUTPUT_TO_US')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # 89 later, l2 is done.
        bitcoind.generate_block(89)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Now, 100 blocks and l1 should be done.
        bitcoind.generate_block(10)
        sync_blockheight([l1])
        assert not l1.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Payment failed, BTW
        assert l2.rpc.listinvoices('onchain_timeout')['invoices'][0]['status'] == 'unpaid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_middleman(self):
        # HTLC 1->2->3, 1->2 goes down after 2 gets preimage from 3.
        disconnects = ['-WIRE_UPDATE_FULFILL_HTLC', 'permfail']
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node(disconnect=disconnects)
        l3 = self.node_factory.get_node()

        # l2 connects to both, so l1 can't reconnect and thus l2 drops to chain
        l2.rpc.connect(l1.info['id'], 'localhost', l1.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        self.fund_channel(l2, l1, 10**6)
        c23 = self.fund_channel(l2, l3, 10**6)

        # Make sure routes finalized.
        self.wait_for_routes(l1, [c23])

        # Give l1 some money to play with.
        self.pay(l2, l1, 2 * 10**8)

        # Must be bigger than dust!
        rhash = l3.rpc.invoice(10**8, 'middleman', 'desc')['payment_hash']

        route = l1.rpc.getroute(l3.info['id'], 10**8, 1)["route"]
        assert len(route) == 2

        q = queue.Queue()

        def try_pay():
            try:
                l1.rpc.sendpay(to_json(route), rhash)
                l1.rpc.waitsendpay(rhash)
                q.put(None)
            except Exception as err:
                q.put(err)

        t = threading.Thread(target=try_pay)
        t.daemon = True
        t.start()

        # l2 will drop to chain.
        l2.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l2.daemon.wait_for_log(' to ONCHAIN')
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log('OUR_UNILATERAL/THEIR_HTLC')

        # l2 should fulfill HTLC onchain, and spend to-us (any order)
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/THEIR_HTLC by OUR_HTLC_SUCCESS_TX .* after 0 blocks')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # Payment should succeed.
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log('THEIR_UNILATERAL/OUR_HTLC gave us preimage')
        err = q.get(timeout=10)
        if err:
            print("Got err from sendpay thread")
            raise err
        t.join(timeout=1)
        assert not t.isAlive()

        # Three more, l2 can spend to-us.
        bitcoind.generate_block(3)
        l2.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_UNILATERAL/DELAYED_OUTPUT_TO_US')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # One more block, HTLC tx is now spendable.
        l1.bitcoin.generate_block(1)
        l2.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_HTLC_SUCCESS_TX/DELAYED_OUTPUT_TO_US')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # 100 blocks after last spend, l2 should be done.
        l1.bitcoin.generate_block(100)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_penalty_inhtlc(self):
        """Test penalty transaction with an incoming HTLC"""
        # We suppress each one after first commit; HTLC gets added not fulfilled.
        l1 = self.node_factory.get_node(disconnect=['=WIRE_COMMITMENT_SIGNED-nocommit'], may_fail=True)
        l2 = self.node_factory.get_node(disconnect=['=WIRE_COMMITMENT_SIGNED-nocommit'])

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        # Now, this will get stuck due to l1 commit being disabled..
        t = self.pay(l1, l2, 100000000, async=True)

        assert len(l1.getactivechannels()) == 2
        assert len(l2.getactivechannels()) == 2

        # They should both have commitments blocked now.
        l1.daemon.wait_for_log('=WIRE_COMMITMENT_SIGNED-nocommit')
        l2.daemon.wait_for_log('=WIRE_COMMITMENT_SIGNED-nocommit')

        # Make sure l1 got l2's commitment to the HTLC, and sent to master.
        l1.daemon.wait_for_log('UPDATE WIRE_CHANNEL_GOT_COMMITSIG')

        # Take our snapshot.
        tx = l1.rpc.dev_sign_last_tx(l2.info['id'])['tx']

        # Let them continue
        l1.rpc.dev_reenable_commit(l2.info['id'])
        l2.rpc.dev_reenable_commit(l1.info['id'])

        # Should fulfill.
        l1.daemon.wait_for_log('peer_in WIRE_UPDATE_FULFILL_HTLC')
        l1.daemon.wait_for_log('peer_out WIRE_REVOKE_AND_ACK')

        l2.daemon.wait_for_log('peer_out WIRE_UPDATE_FULFILL_HTLC')
        l1.daemon.wait_for_log('peer_in WIRE_REVOKE_AND_ACK')

        # Payment should now complete.
        t.result(timeout=10)

        # Now we really mess things up!
        bitcoind.rpc.sendrawtransaction(tx)
        bitcoind.generate_block(1)

        l2.daemon.wait_for_log(' to ONCHAIN')
        # FIXME: l1 should try to stumble along!
        wait_for(lambda: len(l2.getactivechannels()) == 0)

        # l2 should spend all of the outputs (except to-us).
        # Could happen in any order, depending on commitment tx.
        l2.daemon.wait_for_logs(['Propose handling THEIR_REVOKED_UNILATERAL/DELAYED_OUTPUT_TO_THEM by OUR_PENALTY_TX .* after 0 blocks',
                                 'sendrawtx exit 0',
                                 'Propose handling THEIR_REVOKED_UNILATERAL/THEIR_HTLC by OUR_PENALTY_TX .* after 0 blocks',
                                 'sendrawtx exit 0'])

        # FIXME: test HTLC tx race!

        # 100 blocks later, all resolved.
        bitcoind.generate_block(100)

        # FIXME: Test wallet balance...
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skip("flaky test causing CI fails too often")
    def test_penalty_outhtlc(self):
        """Test penalty transaction with an outgoing HTLC"""
        # First we need to get funds to l2, so suppress after second.
        l1 = self.node_factory.get_node(disconnect=['=WIRE_COMMITMENT_SIGNED*3-nocommit'], may_fail=True)
        l2 = self.node_factory.get_node(disconnect=['=WIRE_COMMITMENT_SIGNED*3-nocommit'])

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        # Move some across to l2.
        self.pay(l1, l2, 200000000)

        assert not l1.daemon.is_in_log('=WIRE_COMMITMENT_SIGNED')
        assert not l2.daemon.is_in_log('=WIRE_COMMITMENT_SIGNED')

        # Now, this will get stuck due to l1 commit being disabled..
        t = self.pay(l2, l1, 100000000, async=True)
        # Make sure we get signature from them.
        l1.daemon.wait_for_log('peer_in WIRE_UPDATE_ADD_HTLC')
        l1.daemon.wait_for_log('peer_in WIRE_COMMITMENT_SIGNED')

        # They should both have commitments blocked now.
        l1.daemon.wait_for_log('dev_disconnect: =WIRE_COMMITMENT_SIGNED')
        l2.daemon.wait_for_log('dev_disconnect: =WIRE_COMMITMENT_SIGNED')

        # Take our snapshot.
        tx = l1.rpc.dev_sign_last_tx(l2.info['id'])['tx']

        # Let the continue
        l1.rpc.dev_reenable_commit(l2.info['id'])
        l2.rpc.dev_reenable_commit(l1.info['id'])

        # Thread should complete.
        t.result(timeout=10)

        # Make sure both sides got revoke_and_ack for final.
        l1.daemon.wait_for_log('peer_in WIRE_REVOKE_AND_ACK')
        l2.daemon.wait_for_log('peer_in WIRE_REVOKE_AND_ACK')

        # Now we really mess things up!
        bitcoind.rpc.sendrawtransaction(tx)
        bitcoind.generate_block(1)

        l2.daemon.wait_for_log(' to ONCHAIN')
        # FIXME: l1 should try to stumble along!

        # l2 should spend all of the outputs (except to-us).
        # Could happen in any order, depending on commitment tx.
        l2.daemon.wait_for_logs(['Ignoring output.*: THEIR_REVOKED_UNILATERAL/OUTPUT_TO_US',
                                 'Propose handling THEIR_REVOKED_UNILATERAL/DELAYED_OUTPUT_TO_THEM by OUR_PENALTY_TX .* after 0 blocks',
                                 'sendrawtx exit 0',
                                 'Propose handling THEIR_REVOKED_UNILATERAL/OUR_HTLC by OUR_PENALTY_TX .* after 0 blocks',
                                 'sendrawtx exit 0'])

        # FIXME: test HTLC tx race!

        # 100 blocks later, all resolved.
        bitcoind.generate_block(100)

        # FIXME: Test wallet balance...
        wait_forget_channels(l2)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_onchain_feechange(self):
        """Onchain handling when we restart with different fees"""
        # HTLC 1->2, 2 fails just after they're both irrevocably committed
        # We need 2 to drop to chain, because then 1's HTLC timeout tx
        # is generated on-the-fly, and is thus feerate sensitive.
        disconnects = ['-WIRE_UPDATE_FAIL_HTLC', 'permfail']
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        rhash = l2.rpc.invoice(10**8, 'onchain_timeout', 'desc')['payment_hash']
        # We underpay, so it fails.
        routestep = {
            'msatoshi': 10**8 - 1,
            'id': l2.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        self.executor.submit(l1.rpc.sendpay, to_json([routestep]), rhash)

        # l2 will drop to chain.
        l2.daemon.wait_for_log('permfail')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # Wait for timeout.
        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TO_US .* after 6 blocks')
        bitcoind.generate_block(6)

        l1.daemon.wait_for_log('sendrawtx exit 0')

        # Make sure that gets included.

        bitcoind.generate_block(1)
        # Now we restart with different feerates.
        l1.stop()

        l1.daemon.cmd_line.append('--override-fee-rates=20000/9000/2000')
        l1.start()

        # We recognize different proposal as ours.
        l1.daemon.wait_for_log('Resolved THEIR_UNILATERAL/OUR_HTLC by our proposal OUR_HTLC_TIMEOUT_TO_US')

        # We use 3 blocks for "reasonable depth", so add two more
        bitcoind.generate_block(2)

        # Note that the very similar test_onchain_timeout looks for a
        # different string: that's because it sees the JSONRPC response,
        # and due to the l1 restart, there is none here.
        l1.daemon.wait_for_log('WIRE_PERMANENT_CHANNEL_FAILURE')

        # 90 later, l2 is done
        bitcoind.generate_block(89)
        sync_blockheight([l2])
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Now, 7 blocks and l1 should be done.
        bitcoind.generate_block(6)
        sync_blockheight([l1])
        assert not l1.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')

        # Payment failed, BTW
        assert l2.rpc.listinvoices('onchain_timeout')['invoices'][0]['status'] == 'unpaid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for dev-set-fees")
    def test_onchain_all_dust(self):
        """Onchain handling when we reduce output to all dust"""
        # HTLC 1->2, 2 fails just after they're both irrevocably committed
        # We need 2 to drop to chain, because then 1's HTLC timeout tx
        # is generated on-the-fly, and is thus feerate sensitive.
        disconnects = ['-WIRE_UPDATE_FAIL_HTLC', 'permfail']
        l1 = self.node_factory.get_node(options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node(disconnect=disconnects)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        rhash = l2.rpc.invoice(10**8, 'onchain_timeout', 'desc')['payment_hash']
        # We underpay, so it fails.
        routestep = {
            'msatoshi': 10**7 - 1,
            'id': l2.info['id'],
            'delay': 5,
            'channel': '1:1:1'
        }

        self.executor.submit(l1.rpc.sendpay, to_json([routestep]), rhash)

        # l2 will drop to chain.
        l2.daemon.wait_for_log('permfail')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # Make l1's fees really high.
        l1.rpc.dev_setfees('100000', '100000', '100000')

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # Wait for timeout.
        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/OUR_HTLC by DONATING_TO_MINERS .* after 6 blocks')
        bitcoind.generate_block(6)

        l1.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)

        l1.daemon.wait_for_log('Resolved THEIR_UNILATERAL/OUR_HTLC by our proposal DONATING_TO_MINERS')

        # 100 deep and l2 forgets.
        bitcoind.generate_block(91)
        sync_blockheight([l2])
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

        # l1 forgets 100 blocks after DONATING_TO_MINERS.
        bitcoind.generate_block(6)
        sync_blockheight([l1])
        assert not l1.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for dev_fail")
    def test_onchain_different_fees(self):
        """Onchain handling when we've had a range of fees"""

        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**7)

        l2.rpc.dev_ignore_htlcs(id=l1.info['id'], ignore=True)
        p1 = self.pay(l1, l2, 1000000000, async=True)
        l1.daemon.wait_for_log('htlc 0: RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION')

        l1.rpc.dev_setfees('14000')
        p2 = self.pay(l1, l2, 900000000, async=True)
        l1.daemon.wait_for_log('htlc 1: RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION')

        l1.rpc.dev_setfees('5000')
        p3 = self.pay(l1, l2, 800000000, async=True)
        l1.daemon.wait_for_log('htlc 2: RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION')

        # Drop to chain
        l1.rpc.dev_fail(l2.info['id'])
        l1.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # Both sides should have correct feerate
        assert l1.db_query('SELECT min_possible_feerate, max_possible_feerate FROM channels;') == [{'min_possible_feerate': 5000, 'max_possible_feerate': 14000}]
        assert l2.db_query('SELECT min_possible_feerate, max_possible_feerate FROM channels;') == [{'min_possible_feerate': 5000, 'max_possible_feerate': 14000}]

        bitcoind.generate_block(5)
        # Three HTLCs, and one for the to-us output.
        l1.daemon.wait_for_logs(['sendrawtx exit 0'] * 4)

        # We use 3 blocks for "reasonable depth"
        bitcoind.generate_block(3)

        self.assertRaises(TimeoutError, p1.result, 10)
        self.assertRaises(TimeoutError, p2.result, 10)
        self.assertRaises(TimeoutError, p3.result, 10)

        # Two more for HTLC timeout tx to be spent.
        bitcoind.generate_block(2)
        l1.daemon.wait_for_logs(['sendrawtx exit 0'] * 3)

        # Now, 100 blocks it should be done.
        bitcoind.generate_block(100)
        wait_forget_channels(l1)
        wait_forget_channels(l2)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_permfail_new_commit(self):
        # Test case where we have two possible commits: it will use new one.
        disconnects = ['-WIRE_REVOKE_AND_ACK', 'permfail']
        l1 = self.node_factory.get_node(options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node(disconnect=disconnects)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        # This will fail at l2's end.
        t = self.pay(l1, l2, 200000000, async=True)

        l2.daemon.wait_for_log('dev_disconnect permfail')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('Their unilateral tx, new commit point')
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/THEIR_HTLC by THEIR_HTLC_TIMEOUT_TO_THEM \\(IGNORING\\) after 6 blocks')
        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TO_US (.*) after 6 blocks')

        # OK, time out HTLC.
        bitcoind.generate_block(5)
        l1.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('Resolved THEIR_UNILATERAL/OUR_HTLC by our proposal OUR_HTLC_TIMEOUT_TO_US')
        l2.daemon.wait_for_log('Ignoring output.*: OUR_UNILATERAL/THEIR_HTLC')

        t.cancel()

        # Now, 100 blocks it should be done.
        bitcoind.generate_block(100)
        wait_forget_channels(l1)
        wait_forget_channels(l2)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_permfail_htlc_in(self):
        # Test case where we fail with unsettled incoming HTLC.
        disconnects = ['-WIRE_UPDATE_FULFILL_HTLC', 'permfail']
        l1 = self.node_factory.get_node(options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node(disconnect=disconnects)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)

        # This will fail at l2's end.
        t = self.pay(l1, l2, 200000000, async=True)

        l2.daemon.wait_for_log('dev_disconnect permfail')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('Their unilateral tx, old commit point')
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/THEIR_HTLC by THEIR_HTLC_TIMEOUT_TO_THEM \\(IGNORING\\) after 6 blocks')
        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TO_US (.*) after 6 blocks')
        # l2 then gets preimage, uses it instead of ignoring
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/THEIR_HTLC by OUR_HTLC_SUCCESS_TX .* after 0 blocks')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)

        # OK, l1 sees l2 fulfill htlc.
        l1.daemon.wait_for_log('THEIR_UNILATERAL/OUR_HTLC gave us preimage')
        l2.daemon.wait_for_log('Propose handling OUR_HTLC_SUCCESS_TX/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks')
        bitcoind.generate_block(6)

        l2.daemon.wait_for_log('sendrawtx exit 0')

        t.cancel()

        # Now, 100 blocks it should be done.
        bitcoind.generate_block(95)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(5)
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_permfail_htlc_out(self):
        # Test case where we fail with unsettled outgoing HTLC.
        disconnects = ['+WIRE_REVOKE_AND_ACK', 'permfail']
        l1 = self.node_factory.get_node(options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node(disconnect=disconnects)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l2, l1, 10**6)

        # This will fail at l2's end.
        t = self.pay(l2, l1, 200000000, async=True)

        l2.daemon.wait_for_log('dev_disconnect permfail')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('Their unilateral tx, old commit point')
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_logs(['Propose handling OUR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TX \\(.*\\) after 6 blocks',
                                 'Propose handling OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks'])

        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/THEIR_HTLC by THEIR_HTLC_TIMEOUT_TO_THEM \\(IGNORING\\) after 6 blocks')
        # l1 then gets preimage, uses it instead of ignoring
        l1.daemon.wait_for_log('Propose handling THEIR_UNILATERAL/THEIR_HTLC by THEIR_HTLC_FULFILL_TO_US .* after 0 blocks')
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # l2 sees l1 fulfill tx.
        bitcoind.generate_block(1)

        l2.daemon.wait_for_log('OUR_UNILATERAL/OUR_HTLC gave us preimage')
        t.cancel()

        # l2 can send OUR_DELAYED_RETURN_TO_WALLET after 3 more blocks.
        bitcoind.generate_block(3)
        l2.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET .* to resolve OUR_UNILATERAL/DELAYED_OUTPUT_TO_US')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # Now, 100 blocks they should be done.
        bitcoind.generate_block(95)
        sync_blockheight([l1, l2])
        assert not l1.daemon.is_in_log('onchaind complete, forgetting peer')
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        sync_blockheight([l2])
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(3)
        sync_blockheight([l2])
        assert not l2.daemon.is_in_log('onchaind complete, forgetting peer')
        bitcoind.generate_block(1)
        wait_forget_channels(l2)

    @unittest.skipIf(not DEVELOPER, "DEVELOPER=1 needed to speed up gossip propagation, would be too long otherwise")
    def test_gossip_jsonrpc(self):
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)

        # Shouldn't send announce signatures until 6 deep.
        assert not l1.daemon.is_in_log('peer_out WIRE_ANNOUNCEMENT_SIGNATURES')

        # Channels should be activated locally
        wait_for(lambda: len(l1.rpc.listchannels()['channels']) == 2)
        wait_for(lambda: len(l2.rpc.listchannels()['channels']) == 2)

        # Make sure we can route through the channel, will raise on failure
        l1.rpc.getroute(l2.info['id'], 100, 1)

        # Outgoing should be active, but not public.
        channels1 = l1.rpc.listchannels()['channels']
        channels2 = l2.rpc.listchannels()['channels']

        assert [c['active'] for c in channels1] == [True, True]
        assert [c['active'] for c in channels2] == [True, True]
        # The incoming direction will be considered public, hence check for out
        # outgoing only
        assert len([c for c in channels1 if not c['public']]) == 2
        assert len([c for c in channels2 if not c['public']]) == 2

        # Now proceed to funding-depth and do a full gossip round
        l1.bitcoin.generate_block(5)
        # Could happen in either order.
        l1.daemon.wait_for_logs(['peer_out WIRE_ANNOUNCEMENT_SIGNATURES',
                                 'peer_in WIRE_ANNOUNCEMENT_SIGNATURES'])

        # Just wait for the update to kick off and then check the effect
        needle = "Received channel_update for channel"
        l1.daemon.wait_for_log(needle)
        l2.daemon.wait_for_log(needle)
        # Need to increase timeout, intervals cannot be shortened with DEVELOPER=0
        wait_for(lambda: len(l1.getactivechannels()) == 2, timeout=60)
        wait_for(lambda: len(l2.getactivechannels()) == 2, timeout=60)

        nodes = l1.rpc.listnodes()['nodes']
        assert set([n['nodeid'] for n in nodes]) == set([l1.info['id'], l2.info['id']])

        # Test listnodes with an arg, while we're here.
        n1 = l1.rpc.listnodes(l1.info['id'])['nodes'][0]
        n2 = l1.rpc.listnodes(l2.info['id'])['nodes'][0]
        assert n1['nodeid'] == l1.info['id']
        assert n2['nodeid'] == l2.info['id']

        # Might not have seen other node-announce yet.
        assert n1['alias'].startswith('JUNIORBEAM')
        assert n1['color'] == '0266e4'
        if 'alias' not in n2:
            assert 'color' not in n2
            assert 'addresses' not in n2
        else:
            assert n2['alias'].startswith('SILENTARTIST')
            assert n2['color'] == '022d22'

        assert [c['active'] for c in l1.rpc.listchannels()['channels']] == [True, True]
        assert [c['public'] for c in l1.rpc.listchannels()['channels']] == [True, True]
        assert [c['active'] for c in l2.rpc.listchannels()['channels']] == [True, True]
        assert [c['public'] for c in l2.rpc.listchannels()['channels']] == [True, True]

    def test_gossip_weirdalias(self):
        weird_name = '\t \n \" \n \r \n \\'
        l1 = self.node_factory.get_node(options={'alias': weird_name})
        weird_name_json = json.encoder.JSONEncoder().encode(weird_name)[1:-1].replace('\\', '\\\\')
        aliasline = l1.daemon.is_in_log('Server started with public key .* alias')
        assert weird_name_json in str(aliasline)
        normal_name = 'Normal name'
        l2 = self.node_factory.get_node(options={'alias': normal_name})
        assert l2.daemon.is_in_log('Server started with public key .* alias {}'
                                   .format(normal_name))

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l2, l1, 10**6)
        bitcoind.rpc.generate(6)

        # They should gossip together.
        l1.daemon.wait_for_log('Received node_announcement for node {}'
                               .format(l2.info['id']))
        l2.daemon.wait_for_log('Received node_announcement for node {}'
                               .format(l1.info['id']))

        node = l1.rpc.listnodes(l1.info['id'])['nodes'][0]
        assert node['alias'] == weird_name
        node = l2.rpc.listnodes(l1.info['id'])['nodes'][0]
        assert node['alias'] == weird_name

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-no-reconnect")
    def test_gossip_persistence(self):
        """Gossip for a while, restart and it should remember.

        Also tests for funding outpoint spends, and they should be persisted
        too.
        """
        opts = {'dev-no-reconnect': None}
        l1 = self.node_factory.get_node(options=opts, may_reconnect=True)
        l2 = self.node_factory.get_node(options=opts, may_reconnect=True)
        l3 = self.node_factory.get_node(options=opts, may_reconnect=True)
        l4 = self.node_factory.get_node(options=opts, may_reconnect=True)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        l3.rpc.connect(l4.info['id'], 'localhost', l4.port)

        self.fund_channel(l1, l2, 10**6)
        self.fund_channel(l2, l3, 10**6)

        # Make channels public, except for l3 -> l4, which is kept local-only for now
        l1.bitcoin.rpc.generate(5)
        self.fund_channel(l3, l4, 10**6)
        l1.bitcoin.rpc.generate(1)

        def count_active(node):
            chans = node.rpc.listchannels()['channels']
            active = [c for c in chans if c['active']]
            return len(active)

        # Channels should be activated
        wait_for(lambda: count_active(l1) == 4)
        wait_for(lambda: count_active(l2) == 4)
        wait_for(lambda: count_active(l3) == 6)  # 4 public + 2 local

        # l1 restarts and doesn't connect, but loads from persisted store, all
        # local channels should be disabled, leaving only the two l2 <-> l3
        # directions
        l1.restart()
        wait_for(lambda: count_active(l1) == 2)

        # Now reconnect, they should re-enable the two l1 <-> l2 directions
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        wait_for(lambda: count_active(l1) == 4)

        # Now spend the funding tx, generate a block and see others deleting the
        # channel from their network view
        l1.rpc.dev_fail(l2.info['id'])
        time.sleep(1)
        l1.bitcoin.rpc.generate(1)

        sync_blockheight([l1, l2, l3, l4])

        wait_for(lambda: count_active(l1) == 2)
        wait_for(lambda: count_active(l2) == 2)
        wait_for(lambda: count_active(l3) == 4)  # 2 public + 2 local

        # We should have one local-only channel
        def count_non_public(node):
            chans = node.rpc.listchannels()['channels']
            nonpublic = [c for c in chans if not c['public']]
            return len(nonpublic)

        # The channel l3 -> l4 should be known only to them
        assert count_non_public(l1) == 0
        assert count_non_public(l2) == 0
        wait_for(lambda: count_non_public(l3) == 2)
        wait_for(lambda: count_non_public(l4) == 2)

        # Finally, it should also remember the deletion after a restart
        l3.restart()
        l4.restart()
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        l3.rpc.connect(l4.info['id'], 'localhost', l4.port)
        wait_for(lambda: count_active(l3) == 4)  # 2 public + 2 local

        # Both l3 and l4 should remember their local-only channel
        wait_for(lambda: count_non_public(l3) == 2)
        wait_for(lambda: count_non_public(l4) == 2)

    def ping_tests(self, l1, l2):
        # 0-byte pong gives just type + length field.
        ret = l1.rpc.dev_ping(l2.info['id'], 0, 0)
        assert ret['totlen'] == 4

        # 1000-byte ping, 0-byte pong.
        ret = l1.rpc.dev_ping(l2.info['id'], 1000, 0)
        assert ret['totlen'] == 4

        # 1000 byte pong.
        ret = l1.rpc.dev_ping(l2.info['id'], 1000, 1000)
        assert ret['totlen'] == 1004

        # Maximum length pong.
        ret = l1.rpc.dev_ping(l2.info['id'], 1000, 65531)
        assert ret['totlen'] == 65535

        # Overlength -> no reply.
        for s in range(65532, 65536):
            ret = l1.rpc.dev_ping(l2.info['id'], 1000, s)
            assert ret['totlen'] == 0

        # 65535 - type(2 bytes) - num_pong_bytes(2 bytes) - byteslen(2 bytes)
        # = 65529 max.
        self.assertRaisesRegex(ValueError, r'oversize ping',
                               l1.rpc.dev_ping, l2.info['id'], 65530, 1)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_ping(self):
        l1, l2 = self.connect()

        # Test gossip pinging.
        self.ping_tests(l1, l2)
        if DEVELOPER:
            l1.daemon.wait_for_log('Got pong 1000 bytes \({}\.\.\.\)'
                                   .format(l2.info['version']), timeout=1)

        self.fund_channel(l1, l2, 10**5)

        # channeld pinging
        self.ping_tests(l1, l2)
        if DEVELOPER:
            l1.daemon.wait_for_log('Got pong 1000 bytes \({}\.\.\.\)'
                                   .format(l2.info['version']))

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_gossip_query_channel_range(self):
        l1 = self.node_factory.get_node(options={'log-level': 'io'})
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()
        l4 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        l3.rpc.connect(l4.info['id'], 'localhost', l4.port)

        # Make public channels.
        scid12 = self.fund_channel(l1, l2, 10**5)
        block12 = int(scid12.split(':')[0])
        scid23 = self.fund_channel(l2, l3, 10**5)
        block23 = int(scid23.split(':')[0])
        bitcoind.generate_block(5)
        sync_blockheight([l2, l3])

        # Make sure l2 has received all the gossip.
        l2.daemon.wait_for_logs(['Received node_announcement for node ' + l1.info['id'],
                                 'Received node_announcement for node ' + l3.info['id']])

        # l1 asks for all channels, gets both.
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=1000000)

        assert ret['final_first_block'] == 0
        assert ret['final_num_blocks'] == 1000000
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 2
        assert ret['short_channel_ids'][0] == scid12
        assert ret['short_channel_ids'][1] == scid23

        # Does not include scid12
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=block12)
        assert ret['final_first_block'] == 0
        assert ret['final_num_blocks'] == block12
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 0

        # Does include scid12
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=block12 + 1)
        assert ret['final_first_block'] == 0
        assert ret['final_num_blocks'] == block12 + 1
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 1
        assert ret['short_channel_ids'][0] == scid12

        # Doesn't include scid23
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=block23)
        assert ret['final_first_block'] == 0
        assert ret['final_num_blocks'] == block23
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 1
        assert ret['short_channel_ids'][0] == scid12

        # Does include scid23
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=block12,
                                             num=block23 - block12 + 1)
        assert ret['final_first_block'] == block12
        assert ret['final_num_blocks'] == block23 - block12 + 1
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 2
        assert ret['short_channel_ids'][0] == scid12
        assert ret['short_channel_ids'][1] == scid23

        # Only includes scid23
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=block23,
                                             num=1)
        assert ret['final_first_block'] == block23
        assert ret['final_num_blocks'] == 1
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 1
        assert ret['short_channel_ids'][0] == scid23

        # Past both
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=block23 + 1,
                                             num=1000000)
        assert ret['final_first_block'] == block23 + 1
        assert ret['final_num_blocks'] == 1000000
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 0

        # Make l2 split reply into two.
        l2.rpc.dev_set_max_scids_encode_size(max=9)
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=1000000)

        # It should definitely have split
        assert ret['final_first_block'] != 0 or ret['final_num_blocks'] != 1000000
        assert ret['final_complete']
        assert len(ret['short_channel_ids']) == 2
        assert ret['short_channel_ids'][0] == scid12
        assert ret['short_channel_ids'][1] == scid23
        l2.daemon.wait_for_log('queue_channel_ranges full: splitting')

        # This should actually be large enough for zlib to kick in!
        self.fund_channel(l3, l4, 10**5)
        bitcoind.generate_block(5)
        l2.daemon.wait_for_log('Received node_announcement for node ' + l4.info['id'])

        # Turn on IO logging in l1 channeld.
        subprocess.run(['kill', '-USR1', l1.subd_pid('channeld')])

        # Restore infinite encode size.
        l2.rpc.dev_set_max_scids_encode_size(max=(2**32 - 1))
        ret = l1.rpc.dev_query_channel_range(id=l2.info['id'],
                                             first=0,
                                             num=65535)
        l1.daemon.wait_for_log(
            # WIRE_REPLY_CHANNEL_RANGE
            '\[IN\] 0108' +
            # chain_hash
            '................................................................' +
            # first_blocknum
            '00000000' +
            # number_of_blocks
            '0000ffff' +
            # complete
            '01' +
            # length
            '....' +
            # encoding
            '01'
        )

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_query_short_channel_id(self):
        l1 = self.node_factory.get_node(options={'log-level': 'io'})
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)

        # Need full IO logging so we can see gossip (from gossipd and channeld)
        subprocess.run(['kill', '-USR1', l1.subd_pid('gossipd')])

        # Empty result tests.
        reply = l1.rpc.dev_query_scids(l2.info['id'], ['1:1:1', '2:2:2'])
        # 0x0105 = query_short_channel_ids
        l1.daemon.wait_for_log('\[OUT\] 0105.*0000000100000100010000020000020002')
        assert reply['complete']

        # Make channels public.
        scid12 = self.fund_channel(l1, l2, 10**5)
        scid23 = self.fund_channel(l2, l3, 10**5)
        bitcoind.generate_block(5)
        sync_blockheight([l1, l2, l3])

        # It will know about everything.
        l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l3.info['id']))
        subprocess.run(['kill', '-USR1', l1.subd_pid('channeld')])

        # This query should get channel announcements, channel updates, and node announcements.
        reply = l1.rpc.dev_query_scids(l2.info['id'], [scid23])
        # 0x0105 = query_short_channel_ids
        l1.daemon.wait_for_log('\[OUT\] 0105')
        assert reply['complete']

        # 0x0100 = channel_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # 0x0102 = channel_update
        l1.daemon.wait_for_log('\[IN\] 0102')
        l1.daemon.wait_for_log('\[IN\] 0102')
        # 0x0101 = node_announcement
        l1.daemon.wait_for_log('\[IN\] 0101')
        l1.daemon.wait_for_log('\[IN\] 0101')

        reply = l1.rpc.dev_query_scids(l2.info['id'], [scid12, scid23])
        assert reply['complete']
        # Technically, this order could be different, but this matches code.
        # 0x0100 = channel_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # 0x0102 = channel_update
        l1.daemon.wait_for_log('\[IN\] 0102')
        l1.daemon.wait_for_log('\[IN\] 0102')
        # 0x0100 = channel_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # 0x0102 = channel_update
        l1.daemon.wait_for_log('\[IN\] 0102')
        l1.daemon.wait_for_log('\[IN\] 0102')
        # 0x0101 = node_announcement
        l1.daemon.wait_for_log('\[IN\] 0101')
        l1.daemon.wait_for_log('\[IN\] 0101')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_gossip_timestamp_filter(self):
        # Need full IO logging so we can see gossip (from gossipd and channeld)
        l1 = self.node_factory.get_node(options={'log-level': 'io'})
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()

        # Full IO logging for gossipds
        subprocess.run(['kill', '-USR1', l1.subd_pid('gossipd')])
        subprocess.run(['kill', '-USR1', l2.subd_pid('gossipd')])

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)

        before_anything = int(time.time() - 1.0)

        # Make a public channel.
        chan12 = self.fund_channel(l1, l2, 10**5)
        bitcoind.generate_block(5)
        sync_blockheight([l1, l2])

        self.wait_for_routes(l3, [chan12])
        after_12 = int(time.time())
        # Full IO logging for l1's channeld
        subprocess.run(['kill', '-USR1', l1.subd_pid('channeld')])

        # Make another one, different timestamp.
        chan23 = self.fund_channel(l2, l3, 10**5)
        bitcoind.generate_block(5)
        sync_blockheight([l2, l3])

        self.wait_for_routes(l1, [chan23])
        after_23 = int(time.time())

        # Make sure l1 has received all the gossip.
        wait_for(lambda: ['alias' in node for node in l1.rpc.listnodes()['nodes']] == [True, True, True])

        # l1 sets broad timestamp, will receive info about both channels again.
        l1.rpc.dev_send_timestamp_filter(id=l2.info['id'],
                                         first=0,
                                         range=0xFFFFFFFF)
        before_sendfilter = l1.daemon.logsearch_start

        # 0x0100 = channel_announcement
        # 0x0102 = channel_update
        # 0x0101 = node_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # The order of node_announcements relative to others is undefined.
        l1.daemon.wait_for_logs(['\[IN\] 0102',
                                 '\[IN\] 0102',
                                 '\[IN\] 0100',
                                 '\[IN\] 0102',
                                 '\[IN\] 0102',
                                 '\[IN\] 0101',
                                 '\[IN\] 0101',
                                 '\[IN\] 0101'])

        # Now timestamp which doesn't overlap (gives nothing).
        before_sendfilter = l1.daemon.logsearch_start
        l1.rpc.dev_send_timestamp_filter(id=l2.info['id'],
                                         first=0,
                                         range=before_anything)
        time.sleep(1)
        assert not l1.daemon.is_in_log('\[IN\] 0100', before_sendfilter)

        # Now choose range which will only give first update.
        l1.rpc.dev_send_timestamp_filter(id=l2.info['id'],
                                         first=before_anything,
                                         range=after_12 - before_anything + 1)
        # 0x0100 = channel_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # 0x0102 = channel_update
        # (Node announcement may have any timestamp)
        l1.daemon.wait_for_log('\[IN\] 0102')
        l1.daemon.wait_for_log('\[IN\] 0102')

        # Now choose range which will only give second update.
        l1.rpc.dev_send_timestamp_filter(id=l2.info['id'],
                                         first=after_12,
                                         range=after_23 - after_12 + 1)
        # 0x0100 = channel_announcement
        l1.daemon.wait_for_log('\[IN\] 0100')
        # 0x0102 = channel_update
        # (Node announcement may have any timestamp)
        l1.daemon.wait_for_log('\[IN\] 0102')
        l1.daemon.wait_for_log('\[IN\] 0102')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_routing_gossip_reconnect(self):
        # Connect two peers, reconnect and then see if we resume the
        # gossip.
        disconnects = ['-WIRE_CHANNEL_ANNOUNCEMENT']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l3 = self.node_factory.get_node()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.openchannel(l2, 20000)

        # Now open new channels and everybody should sync
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        l2.openchannel(l3, 20000)

        # Settle the gossip
        for n in [l1, l2, l3]:
            wait_for(lambda: len(n.rpc.listchannels()['channels']) == 4)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_gossip_no_empty_announcements(self):
        # Need full IO logging so we can see gossip
        l1 = self.node_factory.get_node(options={'log-level': 'io'})
        l2 = self.node_factory.get_node(options={'log-level': 'io',
                                                 'dev-no-reconnect': None})
        # l3 sends CHANNEL_ANNOUNCEMENT to l2, but not CHANNEL_UDPATE.
        l3 = self.node_factory.get_node(disconnect=['+WIRE_CHANNEL_ANNOUNCEMENT'])
        l4 = self.node_factory.get_node()

        # Turn on IO logging for gossipds
        subprocess.run(['kill', '-USR1', l1.subd_pid('gossipd')])
        subprocess.run(['kill', '-USR1', l2.subd_pid('gossipd')])

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        l3.rpc.connect(l4.info['id'], 'localhost', l4.port)

        # Make an announced-but-not-updated channel.
        self.fund_channel(l3, l4, 10**5)
        bitcoind.generate_block(5)
        sync_blockheight([l3, l4])
        # 0x0100 = channel_announcement, which goes to l2 before l3 dies.
        l2.daemon.wait_for_log('\[IN\] 0100')

        # But it never goes to l1, as there's no channel_update.
        time.sleep(2)
        assert not l1.daemon.is_in_log('\[IN\] 0100')
        assert len(l1.rpc.listchannels()['channels']) == 0

        # If we reconnect, gossip will now flow.
        l3.rpc.connect(l2.info['id'], 'localhost', l2.port)
        wait_for(lambda: len(l1.rpc.listchannels()['channels']) == 2)

    def test_second_channel(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.connect(l3.info['id'], 'localhost', l3.port)
        self.fund_channel(l1, l2, 10**6)
        self.fund_channel(l1, l3, 10**6)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_routing_gossip(self):
        nodes = [self.node_factory.get_node() for _ in range(5)]
        l1 = nodes[0]

        for i in range(len(nodes) - 1):
            src, dst = nodes[i], nodes[i + 1]
            src.rpc.connect(dst.info['id'], 'localhost', dst.port)
            src.openchannel(dst, 20000)

        # Allow announce messages.
        l1.bitcoin.generate_block(5)

        # Deep check that all channels are in there
        comb = []
        for i in range(len(nodes) - 1):
            comb.append((nodes[i].info['id'], nodes[i + 1].info['id']))
            comb.append((nodes[i + 1].info['id'], nodes[i].info['id']))

        def check_gossip(n):
            seen = []
            channels = n.rpc.listchannels()['channels']
            for c in channels:
                seen.append((c['source'], c['destination']))
            missing = set(comb) - set(seen)
            logging.debug("Node {id} is missing channels {chans}".format(
                id=n.info['id'],
                chans=missing)
            )
            return len(missing) == 0

        for n in nodes:
            wait_for(lambda: check_gossip(n), interval=1)

    @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll")
    def test_forward(self):
        # Connect 1 -> 2 -> 3.
        l1, l2 = self.connect()
        l3 = self.node_factory.get_node()
        ret = l2.rpc.connect(l3.info['id'], 'localhost', l3.port)

        assert ret['id'] == l3.info['id']

        l3.daemon.wait_for_log('Handing back peer .* to master')
        self.fund_channel(l1, l2, 10**6)
        self.fund_channel(l2, l3, 10**6)

        # Allow announce messages.
        l1.bitcoin.generate_block(5)

        # If they're at different block heights we can get spurious errors.
        sync_blockheight([l1, l2, l3])

        chanid1 = l1.rpc.getpeer(l2.info['id'])['channels'][0]['short_channel_id']
        chanid2 = l2.rpc.getpeer(l3.info['id'])['channels'][0]['short_channel_id']
        assert l2.rpc.getpeer(l1.info['id'])['channels'][0]['short_channel_id'] == chanid1
        assert l3.rpc.getpeer(l2.info['id'])['channels'][0]['short_channel_id'] == chanid2

        rhash = l3.rpc.invoice(100000000, 'testpayment1', 'desc')['payment_hash']
        assert l3.rpc.listinvoices('testpayment1')['invoices'][0]['status'] == 'unpaid'

        # Fee for node2 is 10 millionths, plus 1.
        amt = 100000000
        fee = amt * 10 // 1000000 + 1

        baseroute = [{'msatoshi': amt + fee,
                      'id': l2.info['id'],
                      'delay': 12,
                      'channel': chanid1},
                     {'msatoshi': amt,
                      'id': l3.info['id'],
                      'delay': 6,
                      'channel': chanid2}]

        # Unknown other peer
        route = copy.deepcopy(baseroute)
        route[1]['id'] = '031a8dc444e41bb989653a4501e11175a488a57439b0c4947704fd6e3de5dca607'
        l1.rpc.sendpay(to_json(route), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)

        # Delay too short (we always add one internally anyway, so subtract 2 here).
        route = copy.deepcopy(baseroute)
        route[0]['delay'] = 8
        l1.rpc.sendpay(to_json(route), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)

        # Final delay too short
        route = copy.deepcopy(baseroute)
        route[1]['delay'] = 3
        l1.rpc.sendpay(to_json(route), rhash)
        self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)

        # This one works
        route = copy.deepcopy(baseroute)
        l1.rpc.sendpay(to_json(route), rhash)
        l1.rpc.waitsendpay(rhash)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_forward_different_fees_and_cltv(self):
        # FIXME: Check BOLT quotes here too
        # BOLT #7:
        # ```
        #    B
        #   / \
        #  /   \
        # A     C
        #  \   /
        #   \ /
        #    D
        # ```
        #
        # Each advertises the following `cltv_expiry_delta` on its end of every
        # channel:
        #
        # 1. A: 10 blocks
        # 2. B: 20 blocks
        # 3. C: 30 blocks
        # 4. D: 40 blocks
        #
        # C also uses a minimum `cltv_expiry` of 9 (the default) when requesting
        # payments.
        #
        # Also, each node has the same fee scheme which it uses for each of its
        # channels:
        #
        # 1. A: 100 base + 1000 millionths
        # 1. B: 200 base + 2000 millionths
        # 1. C: 300 base + 3000 millionths
        # 1. D: 400 base + 4000 millionths

        # We don't do D yet.
        l1 = self.node_factory.get_node(options={'cltv-delta': 10, 'fee-base': 100, 'fee-per-satoshi': 1000})
        l2 = self.node_factory.get_node(options={'cltv-delta': 20, 'fee-base': 200, 'fee-per-satoshi': 2000})
        l3 = self.node_factory.get_node(options={'cltv-delta': 30, 'cltv-final': 9, 'fee-base': 300, 'fee-per-satoshi': 3000})

        ret = l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        assert ret['id'] == l2.info['id']

        l1.daemon.wait_for_log('Handing back peer .* to master')
        l2.daemon.wait_for_log('Handing back peer .* to master')

        ret = l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        assert ret['id'] == l3.info['id']

        l2.daemon.wait_for_log('Handing back peer .* to master')
        l3.daemon.wait_for_log('Handing back peer .* to master')

        c1 = self.fund_channel(l1, l2, 10**6)
        c2 = self.fund_channel(l2, l3, 10**6)

        # Make sure l1 has seen announce for all channels.
        self.wait_for_routes(l1, [c1, c2])

        # BOLT #7:
        #
        # If B were to send 4,999,999 millisatoshi directly to C, it wouldn't
        # charge itself a fee nor add its own `cltv_expiry_delta`, so it would
        # use C's requested `cltv_expiry` of 9.  We also assume it adds a
        # "shadow route" to give an extra CLTV of 42.  It could also add extra
        # cltv deltas at other hops, as these values are a minimum, but we don't
        # here for simplicity:

        # FIXME: Add shadow route
        shadow_route = 0
        route = l2.rpc.getroute(l3.info['id'], 4999999, 1)["route"]
        assert len(route) == 1

        # BOLT #7:
        #
        #    * `amount_msat`: 4999999
        #    * `cltv_expiry`: current-block-height + 9 + 42
        #    * `onion_routing_packet`:
        #      * `amt_to_forward` = 4999999
        #      * `outgoing_cltv_value` = current-block-height + 9 + 42
        #
        assert route[0]['msatoshi'] == 4999999
        assert route[0]['delay'] == 9 + shadow_route

        # BOLT #7:
        # If A were to send 4,999,999 millisatoshi to C via B, it needs to
        # pay B the fee it specified in the B->C `channel_update`, calculated as
        # per [HTLC Fees](#htlc_fees):
        #
        # 200 + 4999999 * 2000 / 1000000 = 10199
        #
        # Similarly, it would need to add the `cltv_expiry` from B->C's
        # `channel_update` (20), plus C's requested minimum (9), plus 42 for the
        # "shadow route".  Thus the `update_add_htlc` message from A to B would
        # be:
        #
        #    * `amount_msat`: 5010198
        #    * `cltv_expiry`: current-block-height + 20 + 9 + 42
        #    * `onion_routing_packet`:
        #      * `amt_to_forward` = 4999999
        #      * `outgoing_cltv_value` = current-block-height + 9 + 42
        route = l1.rpc.getroute(l3.info['id'], 4999999, 1)["route"]
        assert len(route) == 2

        assert route[0]['msatoshi'] == 5010198
        assert route[0]['delay'] == 20 + 9 + shadow_route
        assert route[1]['msatoshi'] == 4999999
        assert route[1]['delay'] == 9 + shadow_route

        rhash = l3.rpc.invoice(4999999, 'test_forward_different_fees_and_cltv', 'desc')['payment_hash']
        assert l3.rpc.listinvoices('test_forward_different_fees_and_cltv')['invoices'][0]['status'] == 'unpaid'

        # This should work.
        l1.rpc.sendpay(to_json(route), rhash)
        l1.rpc.waitsendpay(rhash)

        # We add one to the blockcount for a bit of fuzz (FIXME: Shadowroute would fix this!)
        shadow_route = 1
        l1.daemon.wait_for_log("Adding HTLC 0 msat=5010198 cltv={} gave CHANNEL_ERR_ADD_OK"
                               .format(bitcoind.rpc.getblockcount() + 20 + 9 + shadow_route))
        l2.daemon.wait_for_log("Adding HTLC 0 msat=4999999 cltv={} gave CHANNEL_ERR_ADD_OK"
                               .format(bitcoind.rpc.getblockcount() + 9 + shadow_route))
        l3.daemon.wait_for_log("test_forward_different_fees_and_cltv: Actual amount 4999999msat, HTLC expiry {}"
                               .format(bitcoind.rpc.getblockcount() + 9 + shadow_route))
        assert l3.rpc.listinvoices('test_forward_different_fees_and_cltv')['invoices'][0]['status'] == 'paid'

        # Check that we see all the channels
        shortids = set(c['short_channel_id'] for c in l2.rpc.listchannels()['channels'])
        for scid in shortids:
            c = l1.rpc.listchannels(scid)['channels']
            # We get one entry for each direction.
            assert len(c) == 2
            assert c[0]['short_channel_id'] == scid
            assert c[1]['short_channel_id'] == scid
            assert c[0]['source'] == c[1]['destination']
            assert c[1]['source'] == c[0]['destination']

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_forward_pad_fees_and_cltv(self):
        """Test that we are allowed extra locktime delta, and fees"""

        l1 = self.node_factory.get_node(options={'cltv-delta': 10, 'fee-base': 100, 'fee-per-satoshi': 1000})
        l2 = self.node_factory.get_node(options={'cltv-delta': 20, 'fee-base': 200, 'fee-per-satoshi': 2000})
        l3 = self.node_factory.get_node(options={'cltv-delta': 30, 'cltv-final': 9, 'fee-base': 300, 'fee-per-satoshi': 3000})

        ret = l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        assert ret['id'] == l2.info['id']

        l1.daemon.wait_for_log('Handing back peer .* to master')
        l2.daemon.wait_for_log('Handing back peer .* to master')

        ret = l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        assert ret['id'] == l3.info['id']

        l2.daemon.wait_for_log('Handing back peer .* to master')
        l3.daemon.wait_for_log('Handing back peer .* to master')

        c1 = self.fund_channel(l1, l2, 10**6)
        c2 = self.fund_channel(l2, l3, 10**6)

        # Make sure l1 has seen announce for all channels.
        self.wait_for_routes(l1, [c1, c2])

        route = l1.rpc.getroute(l3.info['id'], 4999999, 1)["route"]
        assert len(route) == 2

        assert route[0]['msatoshi'] == 5010198
        assert route[0]['delay'] == 20 + 9
        assert route[1]['msatoshi'] == 4999999
        assert route[1]['delay'] == 9

        # Modify so we overpay, overdo the cltv.
        route[0]['msatoshi'] += 2000
        route[0]['delay'] += 20
        route[1]['msatoshi'] += 1000
        route[1]['delay'] += 10

        # This should work.
        rhash = l3.rpc.invoice(4999999, 'test_forward_pad_fees_and_cltv', 'desc')['payment_hash']
        l1.rpc.sendpay(to_json(route), rhash)
        l1.rpc.waitsendpay(rhash)
        assert l3.rpc.listinvoices('test_forward_pad_fees_and_cltv')['invoices'][0]['status'] == 'paid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_htlc_sig_persistence(self):
        """Interrupt a payment between two peers, then fail and recover funds using the HTLC sig.
        """
        l1 = self.node_factory.get_node(options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node(disconnect=['+WIRE_COMMITMENT_SIGNED'])

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.fund_channel(l1, l2, 10**6)
        f = self.executor.submit(self.pay, l1, l2, 31337000)
        l1.daemon.wait_for_log(r'HTLC out 0 RCVD_ADD_ACK_COMMIT->SENT_ADD_ACK_REVOCATION')
        l1.stop()

        # `pay` call is lost
        self.assertRaises(ValueError, f.result)

        # We should have the HTLC sig
        assert(len(l1.db_query("SELECT * FROM htlc_sigs;")) == 1)

        # This should reload the htlc_sig
        l2.rpc.dev_fail(l1.info['id'])
        l2.stop()
        l1.bitcoin.rpc.generate(1)
        l1.start()

        assert l1.daemon.is_in_log(r'Loaded 1 HTLC signatures from DB')
        l1.daemon.wait_for_logs([
            r'Peer permanent failure in CHANNELD_NORMAL: Funding transaction spent',
            r'Propose handling THEIR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TO_US'
        ])
        l1.bitcoin.rpc.generate(5)
        l1.daemon.wait_for_log("Broadcasting OUR_HTLC_TIMEOUT_TO_US")
        time.sleep(3)
        l1.bitcoin.rpc.generate(1)
        l1.daemon.wait_for_logs([
            r'Owning output . (\d+) .SEGWIT. txid',
        ])

        # We should now have a) the change from funding, b) the
        # unilateral to us, and c) the HTLC respend to us
        assert len(l1.rpc.listfunds()['outputs']) == 3

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_htlc_out_timeout(self):
        """Test that we drop onchain if the peer doesn't time out HTLC"""

        # HTLC 1->2, 1 fails after it's irrevocably committed, can't reconnect
        disconnects = ['@WIRE_REVOKE_AND_ACK']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        chanid = self.fund_channel(l1, l2, 10**6)

        # Wait for route propagation.
        self.wait_for_routes(l1, [chanid])

        amt = 200000000
        inv = l2.rpc.invoice(amt, 'test_htlc_out_timeout', 'desc')['bolt11']
        assert l2.rpc.listinvoices('test_htlc_out_timeout')['invoices'][0]['status'] == 'unpaid'

        self.executor.submit(l1.rpc.pay, inv)

        # l1 will disconnect, and not reconnect.
        l1.daemon.wait_for_log('dev_disconnect: @WIRE_REVOKE_AND_ACK')

        # Takes 6 blocks to timeout (cltv-final + 1), but we also give grace period of 1 block.
        bitcoind.generate_block(5 + 1)
        assert not l1.daemon.is_in_log('hit deadline')
        bitcoind.generate_block(1)

        l1.daemon.wait_for_log('Offered HTLC 0 SENT_ADD_ACK_REVOCATION cltv .* hit deadline')
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        # L1 will timeout HTLC immediately
        l1.daemon.wait_for_logs(['Propose handling OUR_UNILATERAL/OUR_HTLC by OUR_HTLC_TIMEOUT_TX .* after 0 blocks',
                                 'Propose handling OUR_UNILATERAL/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks'])

        l1.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)

        l1.daemon.wait_for_log('Propose handling OUR_HTLC_TIMEOUT_TX/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks')
        bitcoind.generate_block(4)
        # It should now claim both the to-local and htlc-timeout-tx outputs.
        l1.daemon.wait_for_logs(['Broadcasting OUR_DELAYED_RETURN_TO_WALLET',
                                 'Broadcasting OUR_DELAYED_RETURN_TO_WALLET',
                                 'sendrawtx exit 0',
                                 'sendrawtx exit 0'])

        # Now, 100 blocks it should be done.
        bitcoind.generate_block(100)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_htlc_in_timeout(self):
        """Test that we drop onchain if the peer doesn't accept fulfilled HTLC"""

        # HTLC 1->2, 1 fails after 2 has sent committed the fulfill
        disconnects = ['-WIRE_REVOKE_AND_ACK*2']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        options={'dev-no-reconnect': None})
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        chanid = self.fund_channel(l1, l2, 10**6)

        self.wait_for_routes(l1, [chanid])
        sync_blockheight([l1, l2])

        amt = 200000000
        inv = l2.rpc.invoice(amt, 'test_htlc_in_timeout', 'desc')['bolt11']
        assert l2.rpc.listinvoices('test_htlc_in_timeout')['invoices'][0]['status'] == 'unpaid'

        self.executor.submit(l1.rpc.pay, inv)

        # l1 will disconnect and not reconnect.
        l1.daemon.wait_for_log('dev_disconnect: -WIRE_REVOKE_AND_ACK')

        # Deadline HTLC expiry minus 1/2 cltv-expiry delta (rounded up) (== cltv - 3).  ctlv is 5+1.
        bitcoind.generate_block(2)
        assert not l2.daemon.is_in_log('hit deadline')
        bitcoind.generate_block(1)

        l2.daemon.wait_for_log('Fulfilled HTLC 0 SENT_REMOVE_COMMIT cltv .* hit deadline')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        l2.bitcoin.generate_block(1)
        l2.daemon.wait_for_log(' to ONCHAIN')
        l1.daemon.wait_for_log(' to ONCHAIN')

        # L2 will collect HTLC
        l2.daemon.wait_for_log('Propose handling OUR_UNILATERAL/THEIR_HTLC by OUR_HTLC_SUCCESS_TX .* after 0 blocks')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)
        l2.daemon.wait_for_log('Propose handling OUR_HTLC_SUCCESS_TX/DELAYED_OUTPUT_TO_US by OUR_DELAYED_RETURN_TO_WALLET .* after 5 blocks')
        bitcoind.generate_block(4)
        l2.daemon.wait_for_log('Broadcasting OUR_DELAYED_RETURN_TO_WALLET')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        # Now, 100 blocks it should be both done.
        bitcoind.generate_block(100)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_disconnect(self):
        # These should all make us fail
        disconnects = ['-WIRE_INIT',
                       '@WIRE_INIT',
                       '+WIRE_INIT']
        l1 = self.node_factory.get_node(disconnect=disconnects)
        l2 = self.node_factory.get_node()

        self.assertRaises(ValueError, l1.rpc.connect,
                          l2.info['id'], 'localhost', l2.port)
        self.assertRaises(ValueError, l1.rpc.connect,
                          l2.info['id'], 'localhost', l2.port)
        self.assertRaises(ValueError, l1.rpc.connect,
                          l2.info['id'], 'localhost', l2.port)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Should have 3 connect fails.
        for d in disconnects:
            l1.daemon.wait_for_log('Failed connected out for {}'
                                   .format(l2.info['id']))

        # Should still only have one peer!
        assert len(l1.rpc.listpeers()) == 1
        assert len(l2.rpc.listpeers()) == 1

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_disconnect_funder(self):
        # Now error on funder side duringchannel open.
        disconnects = ['-WIRE_OPEN_CHANNEL',
                       '@WIRE_OPEN_CHANNEL',
                       '+WIRE_OPEN_CHANNEL',
                       '-WIRE_FUNDING_CREATED',
                       '@WIRE_FUNDING_CREATED']
        l1 = self.node_factory.get_node(disconnect=disconnects)
        l2 = self.node_factory.get_node()

        self.give_funds(l1, 2000000)

        for d in disconnects:
            l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
            self.assertRaises(ValueError, l1.rpc.fundchannel, l2.info['id'], 20000)
            assert l1.rpc.getpeer(l2.info['id']) is None

        # This one will succeed.
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.fundchannel(l2.info['id'], 20000)

        # Should still only have one peer!
        assert len(l1.rpc.listpeers()) == 1
        assert len(l2.rpc.listpeers()) == 1

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_disconnect_fundee(self):
        # Now error on fundee side during channel open.
        disconnects = ['-WIRE_ACCEPT_CHANNEL',
                       '@WIRE_ACCEPT_CHANNEL',
                       '+WIRE_ACCEPT_CHANNEL']
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node(disconnect=disconnects)

        self.give_funds(l1, 2000000)

        for d in disconnects:
            l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
            self.assertRaises(ValueError, l1.rpc.fundchannel, l2.info['id'], 20000)
            assert l1.rpc.getpeer(l2.info['id']) is None

        # This one will succeed.
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.fundchannel(l2.info['id'], 20000)

        # Should still only have one peer!
        assert len(l1.rpc.listpeers()) == 1
        assert len(l2.rpc.listpeers()) == 1

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_disconnect_half_signed(self):
        # Now, these are the corner cases.  Fundee sends funding_signed,
        # but funder doesn't receive it.
        disconnects = ['@WIRE_FUNDING_SIGNED']
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node(disconnect=disconnects)

        self.give_funds(l1, 2000000)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.assertRaises(ValueError, l1.rpc.fundchannel, l2.info['id'], 20000)

        # Fundee remembers, funder doesn't.
        assert l1.rpc.getpeer(l2.info['id']) is None
        assert l2.rpc.getpeer(l1.info['id'])['id'] == l1.info['id']

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_signed(self):
        # This will fail *after* both sides consider channel opening.
        disconnects = ['+WIRE_FUNDING_SIGNED']
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)

        self.give_funds(l1, 2000000)

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.fundchannel(l2.info['id'], 20000)

        # They haven't forgotten each other.
        assert l1.rpc.getpeer(l2.info['id'])['id'] == l2.info['id']
        assert l2.rpc.getpeer(l1.info['id'])['id'] == l1.info['id']

        # Technically, this is async to fundchannel (and could reconnect first)
        l1.daemon.wait_for_logs(['sendrawtx exit 0',
                                 'Peer has reconnected, state CHANNELD_AWAITING_LOCKIN'])

        l1.bitcoin.generate_block(6)

        l1.daemon.wait_for_log(' to CHANNELD_NORMAL')
        l2.daemon.wait_for_log(' to CHANNELD_NORMAL')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_openingd(self):
        # Openingd thinks we're still opening; funder reconnects..
        disconnects = ['0WIRE_ACCEPT_CHANNEL']
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.give_funds(l1, 2000000)

        # l2 closes on l1, l1 forgets.
        self.assertRaises(ValueError, l1.rpc.fundchannel, l2.info['id'], 20000)
        assert l1.rpc.getpeer(l2.info['id']) is None

        # Reconnect.
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # We should get a message about reconnecting, but order unsynced.
        l2.daemon.wait_for_logs(['gossipd.*reconnect for active peer',
                                 'openingd.*Error reading gossip msg'])

        # Should work fine.
        l1.rpc.fundchannel(l2.info['id'], 20000)
        l1.daemon.wait_for_log('sendrawtx exit 0')

        # Just to be sure, second openingd hand over to channeld.
        l2.daemon.wait_for_log('lightning_openingd.*REPLY WIRE_OPENING_FUNDEE_REPLY with 2 fds')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_normal(self):
        # Should reconnect fine even if locked message gets lost.
        disconnects = ['-WIRE_FUNDING_LOCKED',
                       '@WIRE_FUNDING_LOCKED',
                       '+WIRE_FUNDING_LOCKED']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_sender_add1(self):
        # Fail after add is OK, will cause payment failure though.
        disconnects = ['-WIRE_UPDATE_ADD_HTLC-nocommit',
                       '+WIRE_UPDATE_ADD_HTLC-nocommit',
                       '@WIRE_UPDATE_ADD_HTLC-nocommit']

        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)

        amt = 200000000
        rhash = l2.rpc.invoice(amt, 'test_reconnect_sender_add1', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('test_reconnect_sender_add1')['invoices'][0]['status'] == 'unpaid'

        route = [{'msatoshi': amt, 'id': l2.info['id'], 'delay': 5, 'channel': '1:1:1'}]

        for i in range(0, len(disconnects)):
            l1.rpc.sendpay(to_json(route), rhash)
            self.assertRaises(ValueError, l1.rpc.waitsendpay, rhash)
            # Wait for reconnection.
            l1.daemon.wait_for_log('Already have funding locked in')

        # This will send commit, so will reconnect as required.
        l1.rpc.sendpay(to_json(route), rhash)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_sender_add(self):
        disconnects = ['-WIRE_COMMITMENT_SIGNED',
                       '@WIRE_COMMITMENT_SIGNED',
                       '+WIRE_COMMITMENT_SIGNED',
                       '-WIRE_REVOKE_AND_ACK',
                       '@WIRE_REVOKE_AND_ACK',
                       '+WIRE_REVOKE_AND_ACK']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)

        amt = 200000000
        rhash = l2.rpc.invoice(amt, 'testpayment', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('testpayment')['invoices'][0]['status'] == 'unpaid'

        route = [{'msatoshi': amt, 'id': l2.info['id'], 'delay': 5, 'channel': '1:1:1'}]

        # This will send commit, so will reconnect as required.
        l1.rpc.sendpay(to_json(route), rhash)
        # Should have printed this for every reconnect.
        for i in range(0, len(disconnects)):
            l1.daemon.wait_for_log('Already have funding locked in')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_receiver_add(self):
        disconnects = ['-WIRE_COMMITMENT_SIGNED',
                       '@WIRE_COMMITMENT_SIGNED',
                       '+WIRE_COMMITMENT_SIGNED',
                       '-WIRE_REVOKE_AND_ACK',
                       '@WIRE_REVOKE_AND_ACK',
                       '+WIRE_REVOKE_AND_ACK']
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)

        amt = 200000000
        rhash = l2.rpc.invoice(amt, 'testpayment2', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        route = [{'msatoshi': amt, 'id': l2.info['id'], 'delay': 5, 'channel': '1:1:1'}]
        l1.rpc.sendpay(to_json(route), rhash)
        for i in range(len(disconnects)):
            l1.daemon.wait_for_log('Already have funding locked in')
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'paid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_reconnect_receiver_fulfill(self):
        # Ordering matters: after +WIRE_UPDATE_FULFILL_HTLC, channeld
        # will continue and try to send WIRE_COMMITMENT_SIGNED: if
        # that's the next failure, it will do two in one run.
        disconnects = ['@WIRE_UPDATE_FULFILL_HTLC',
                       '+WIRE_UPDATE_FULFILL_HTLC',
                       '-WIRE_UPDATE_FULFILL_HTLC',
                       '-WIRE_COMMITMENT_SIGNED',
                       '@WIRE_COMMITMENT_SIGNED',
                       '+WIRE_COMMITMENT_SIGNED',
                       '-WIRE_REVOKE_AND_ACK',
                       '@WIRE_REVOKE_AND_ACK',
                       '+WIRE_REVOKE_AND_ACK']
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 10**6)

        amt = 200000000
        rhash = l2.rpc.invoice(amt, 'testpayment2', 'desc')['payment_hash']
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'unpaid'

        route = [{'msatoshi': amt, 'id': l2.info['id'], 'delay': 5, 'channel': '1:1:1'}]
        l1.rpc.sendpay(to_json(route), rhash)
        for i in range(len(disconnects)):
            l1.daemon.wait_for_log('Already have funding locked in')
        assert l2.rpc.listinvoices('testpayment2')['invoices'][0]['status'] == 'paid'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_shutdown_reconnect(self):
        disconnects = ['-WIRE_SHUTDOWN',
                       '@WIRE_SHUTDOWN',
                       '+WIRE_SHUTDOWN']
        l1 = self.node_factory.get_node(disconnect=disconnects,
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        chan = self.fund_channel(l1, l2, 10**6)
        self.pay(l1, l2, 200000000)

        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 0

        # This should return with an error, then close.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chan, False, 0)
        l1.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')
        l2.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')

        l1.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')
        l2.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')

        # And should put closing into mempool (happens async, so
        # CLOSINGD_COMPLETE may come first).
        l1.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        l2.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 1

    def test_shutdown_awaiting_lockin(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node(options={'funding-confirms': 3})

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        self.give_funds(l1, 10**6 + 1000000)
        chanid = l1.rpc.fundchannel(l2.info['id'], 10**6)['channel_id']

        # Technically, this is async to fundchannel.
        l1.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)

        # This should return with an error, then close.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chanid, False, 0)
        l1.daemon.wait_for_log('CHANNELD_AWAITING_LOCKIN to CHANNELD_SHUTTING_DOWN')
        l2.daemon.wait_for_log('CHANNELD_AWAITING_LOCKIN to CHANNELD_SHUTTING_DOWN')

        l1.daemon.wait_for_log('CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE')
        l2.daemon.wait_for_log('CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE')

        # And should put closing into mempool (happens async, so
        # CLOSINGD_COMPLETE may come first).
        l1.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        l2.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        assert bitcoind.rpc.getmempoolinfo()['size'] == 1

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        bitcoind.generate_block(100)
        wait_forget_channels(l1)
        wait_forget_channels(l2)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_closing_negotiation_reconnect(self):
        disconnects = ['-WIRE_CLOSING_SIGNED',
                       '@WIRE_CLOSING_SIGNED',
                       '+WIRE_CLOSING_SIGNED']
        l1 = self.node_factory.get_node(disconnect=disconnects, may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        chan = self.fund_channel(l1, l2, 10**6)
        self.pay(l1, l2, 200000000)

        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 0

        # This should return with an error, then close.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chan, False, 0)
        l1.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')
        l2.daemon.wait_for_log(' to CHANNELD_SHUTTING_DOWN')

        l1.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')
        l2.daemon.wait_for_log(' to CLOSINGD_SIGEXCHANGE')

        # And should put closing into mempool (happens async, so
        # CLOSINGD_COMPLETE may come first).
        l1.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        l2.daemon.wait_for_logs(['sendrawtx exit 0', ' to CLOSINGD_COMPLETE'])
        assert l1.bitcoin.rpc.getmempoolinfo()['size'] == 1

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_bech32_funding(self):
        # Don't get any funds from previous runs.
        l1 = self.node_factory.get_node(random_hsm=True)
        l2 = self.node_factory.get_node(random_hsm=True)

        # connect
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # fund a bech32 address and then open a channel with it
        res = l1.openchannel(l2, 20000, 'bech32')
        address = res['address']
        assert address[0:4] == "bcrt"

        # probably overly paranoid checking
        wallettxid = res['wallettxid']

        wallettx = l1.bitcoin.rpc.getrawtransaction(wallettxid, True)
        fundingtx = l1.bitcoin.rpc.decoderawtransaction(res['fundingtx']['tx'])

        def is_p2wpkh(output):
            return output['type'] == 'witness_v0_keyhash' and \
                address == output['addresses'][0]

        assert any(is_p2wpkh(output['scriptPubKey']) for output in wallettx['vout'])
        assert fundingtx['vin'][0]['txid'] == res['wallettxid']

    def test_withdraw(self):
        amount = 1000000
        # Don't get any funds from previous runs.
        l1 = self.node_factory.get_node(random_hsm=True)
        l2 = self.node_factory.get_node(random_hsm=True)
        addr = l1.rpc.newaddr()['address']

        # Add some funds to withdraw later
        for i in range(10):
            l1.bitcoin.rpc.sendtoaddress(addr, amount / 10**8 + 0.01)

        bitcoind.generate_block(1)
        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) == 10)

        # Reach around into the db to check that outputs were added
        db = sqlite3.connect(os.path.join(l1.daemon.lightning_dir, "lightningd.sqlite3"))

        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=0')
        assert(c.fetchone()[0] == 10)

        waddr = l1.bitcoin.rpc.getnewaddress()
        # Now attempt to withdraw some (making sure we collect multiple inputs)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'not an address', amount)
        self.assertRaises(ValueError, l1.rpc.withdraw, waddr, 'not an amount')
        self.assertRaises(ValueError, l1.rpc.withdraw, waddr, -amount)

        out = l1.rpc.withdraw(waddr, 2 * amount)

        # Make sure bitcoind received the withdrawal
        unspent = l1.bitcoin.rpc.listunspent(0)
        withdrawal = [u for u in unspent if u['txid'] == out['txid']]
        assert(len(withdrawal) == 1)

        assert(withdrawal[0]['amount'] == Decimal('0.02'))

        # Now make sure two of them were marked as spent
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=2')
        assert(c.fetchone()[0] == 2)

        # Now send some money to l2.
        # lightningd uses P2SH-P2WPKH
        waddr = l2.rpc.newaddr('bech32')['address']
        l1.rpc.withdraw(waddr, 2 * amount)
        l1.bitcoin.rpc.generate(1)

        # Make sure l2 received the withdrawal.
        wait_for(lambda: len(l2.rpc.listfunds()['outputs']) == 1)
        outputs = l2.db_query('SELECT value FROM outputs WHERE status=0;')
        assert len(outputs) == 1 and outputs[0]['value'] == 2 * amount

        # Now make sure an additional two of them were marked as spent
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=2')
        assert(c.fetchone()[0] == 4)

        # Simple test for withdrawal to P2WPKH
        # Address from: https://bc-2.jp/tools/bech32demo/index.html
        waddr = 'bcrt1qw508d6qejxtdg4y5r3zarvary0c5xw7kygt080'
        self.assertRaises(ValueError, l1.rpc.withdraw, 'xx1qw508d6qejxtdg4y5r3zarvary0c5xw7kxpjzsx', 2 * amount)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1pw508d6qejxtdg4y5r3zarvary0c5xw7kdl9fad', 2 * amount)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1qw508d6qejxtdg4y5r3zarvary0c5xw7kxxxxxx', 2 * amount)
        l1.rpc.withdraw(waddr, 2 * amount)
        l1.bitcoin.rpc.generate(1)
        # Now make sure additional two of them were marked as spent
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=2')
        assert(c.fetchone()[0] == 6)

        # Simple test for withdrawal to P2WSH
        # Address from: https://bc-2.jp/tools/bech32demo/index.html
        waddr = 'bcrt1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3qzf4jry'
        self.assertRaises(ValueError, l1.rpc.withdraw, 'xx1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3q0sl5k7', 2 * amount)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1prp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3qsm03tq', 2 * amount)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3qxxxxxx', 2 * amount)
        l1.rpc.withdraw(waddr, 2 * amount)
        l1.bitcoin.rpc.generate(1)
        # Now make sure additional two of them were marked as spent
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=2')
        assert(c.fetchone()[0] == 8)

        # failure testing for invalid SegWit addresses, from BIP173
        # HRP character out of range
        self.assertRaises(ValueError, l1.rpc.withdraw, ' 1nwldj5', 2 * amount)
        # overall max length exceeded
        self.assertRaises(ValueError, l1.rpc.withdraw, 'an84characterslonghumanreadablepartthatcontainsthenumber1andtheexcludedcharactersbio1569pvx', 2 * amount)
        # No separator character
        self.assertRaises(ValueError, l1.rpc.withdraw, 'pzry9x0s0muk', 2 * amount)
        # Empty HRP
        self.assertRaises(ValueError, l1.rpc.withdraw, '1pzry9x0s0muk', 2 * amount)
        # Invalid witness version
        self.assertRaises(ValueError, l1.rpc.withdraw, 'BC13W508D6QEJXTDG4Y5R3ZARVARY0C5XW7KN40WF2', 2 * amount)
        # Invalid program length for witness version 0 (per BIP141)
        self.assertRaises(ValueError, l1.rpc.withdraw, 'BC1QR508D6QEJXTDG4Y5R3ZARVARYV98GJ9P', 2 * amount)
        # Mixed case
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3q0sL5k7', 2 * amount)
        # Non-zero padding in 8-to-5 conversion
        self.assertRaises(ValueError, l1.rpc.withdraw, 'tb1qrp33g0q5c5txsp9arysrx4k6zdkfs4nce4xj0gdcccefvpysxf3pjxtptv', 2 * amount)

        # Should have 6 outputs available.
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=0')
        assert(c.fetchone()[0] == 6)

        # Test withdrawal to self.
        l1.rpc.withdraw(l1.rpc.newaddr('bech32')['address'], 'all')
        bitcoind.rpc.generate(1)
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=0')
        assert(c.fetchone()[0] == 1)

        l1.rpc.withdraw(waddr, 'all')
        c = db.cursor()
        c.execute('SELECT COUNT(*) FROM outputs WHERE status=0')
        assert(c.fetchone()[0] == 0)

        # This should fail, can't even afford fee.
        self.assertRaises(ValueError, l1.rpc.withdraw, waddr, 'all')
        l1.daemon.wait_for_log('Cannot afford fee')

    def test_funding_change(self):
        """Add some funds, fund a channel, and make sure we remember the change
        """
        l1, l2 = self.connect()

        self.give_funds(l1, 0.1 * 10**8)

        outputs = l1.db_query('SELECT value FROM outputs WHERE status=0;')
        assert len(outputs) == 1 and outputs[0]['value'] == 10000000

        l1.rpc.fundchannel(l2.info['id'], 1000000)
        outputs = {r['status']: r['value'] for r in l1.db_query(
            'SELECT status, SUM(value) AS value FROM outputs GROUP BY status;')}

        # The 10m out is spent and we have a change output of 9m-fee
        assert outputs[0] > 8990000
        assert outputs[2] == 10000000

    def test_funding_all(self):
        """Add some funds, fund a channel using all funds, make sure no funds remain
        """
        l1, l2 = self.connect()

        self.give_funds(l1, 0.1 * 10**8)

        outputs = l1.db_query('SELECT value FROM outputs WHERE status=0;')
        assert len(outputs) == 1 and outputs[0]['value'] == 10000000

        l1.rpc.fundchannel(l2.info['id'], "all")

        outputs = l1.db_query('SELECT value FROM outputs WHERE status=0;')
        assert len(outputs) == 0

    def test_funding_fail(self):
        """Add some funds, fund a channel without enough funds"""
        # Previous runs with same bitcoind can leave funds!
        l1 = self.node_factory.get_node(random_hsm=True)
        max_locktime = 5 * 6 * 24
        l2 = self.node_factory.get_node(options={'watchtime-blocks': max_locktime + 1})
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        funds = 1000000

        addr = l1.rpc.newaddr()['address']
        l1.bitcoin.rpc.sendtoaddress(addr, funds / 10**8)
        bitcoind.generate_block(1)

        # Wait for it to arrive.
        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) > 0)

        # Fail because l1 dislikes l2's huge locktime.
        self.assertRaisesRegex(ValueError, r'to_self_delay \d+ larger than \d+',
                               l1.rpc.fundchannel, l2.info['id'], int(funds / 10))
        assert l1.rpc.listpeers()['peers'][0]['connected']
        assert l2.rpc.listpeers()['peers'][0]['connected']

        # Restart l2 without ridiculous locktime.
        del l2.daemon.opts['watchtime-blocks']
        l2.restart()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # We don't have enough left to cover fees if we try to spend it all.
        self.assertRaisesRegex(ValueError, r'Cannot afford funding transaction',
                               l1.rpc.fundchannel, l2.info['id'], funds)

        # Should still be connected.
        assert l1.rpc.listpeers()['peers'][0]['connected']
        assert l2.rpc.listpeers()['peers'][0]['connected']

        # This works.
        l1.rpc.fundchannel(l2.info['id'], int(funds / 10))

    def test_funding_toolarge(self):
        """Try to create a giant channel"""
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Send funds.
        amount = 2**24
        bitcoind.rpc.sendtoaddress(l1.rpc.newaddr()['address'], amount / 10**8 + 0.01)
        bitcoind.generate_block(1)

        # Wait for it to arrive.
        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) > 0)

        # Fail to open (too large)
        try:
            l1.rpc.fundchannel(l2.info['id'], amount)
            self.fail('Expected fundchannel to fail!')
        except ValueError as err:
            assert 'Funding satoshi must be <= 16777215' in str(err)

        # This should work.
        amount = amount - 1
        l1.rpc.fundchannel(l2.info['id'], amount)

    def test_lockin_between_restart(self):
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(options={'funding-confirms': 3},
                                        may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.give_funds(l1, 10**6 + 1000000)
        l1.rpc.fundchannel(l2.info['id'], 10**6)['tx']

        # l1 goes down.
        l1.stop()

        # Now 120 blocks go by...
        bitcoind.generate_block(120)

        # Restart
        l1.start()

        # All should be good.
        l1.daemon.wait_for_log(' to CHANNELD_NORMAL')
        l2.daemon.wait_for_log(' to CHANNELD_NORMAL')

    def test_funding_while_offline(self):
        l1 = self.node_factory.get_node()
        addr = l1.rpc.newaddr()['address']
        sync_blockheight([l1])

        # l1 goes down.
        l1.stop()

        # We send funds
        bitcoind.rpc.sendtoaddress(addr, (10**6 + 1000000) / 10**8)

        # Now 120 blocks go by...
        bitcoind.generate_block(120)

        # Restart
        l1.start()
        sync_blockheight([l1])

        assert len(l1.rpc.listfunds()['outputs']) == 1

    def test_addfunds_from_block(self):
        """Send funds to the daemon without telling it explicitly
        """
        # Previous runs with same bitcoind can leave funds!
        l1 = self.node_factory.get_node(random_hsm=True)

        addr = l1.rpc.newaddr()['address']
        l1.bitcoin.rpc.sendtoaddress(addr, 0.1)
        l1.bitcoin.rpc.generate(1)

        wait_for(lambda: len(l1.rpc.listfunds()['outputs']) == 1)

        outputs = l1.db_query('SELECT value FROM outputs WHERE status=0;')
        assert len(outputs) == 1 and outputs[0]['value'] == 10000000

        # The address we detect must match what was paid to.
        output = l1.rpc.listfunds()['outputs'][0]
        assert output['address'] == addr

        # Send all our money to a P2WPKH address this time.
        addr = l1.rpc.newaddr("bech32")['address']
        l1.rpc.withdraw(addr, "all")
        l1.bitcoin.rpc.generate(1)
        time.sleep(1)

        # The address we detect must match what was paid to.
        output = l1.rpc.listfunds()['outputs'][0]
        assert output['address'] == addr

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_channel_persistence(self):
        # Start two nodes and open a channel (to remember). l2 will
        # mysteriously die while committing the first HTLC so we can
        # check that HTLCs reloaded from the DB work.
        l1 = self.node_factory.get_node(may_reconnect=True)
        l2 = self.node_factory.get_node(disconnect=['=WIRE_COMMITMENT_SIGNED-nocommit'],
                                        may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Neither node should have a channel open, they are just connected
        for n in (l1, l2):
            assert(n.db_query('SELECT COUNT(id) as count FROM channels;')[0]['count'] == 0)

        self.fund_channel(l1, l2, 100000)

        peers = l1.rpc.listpeers()['peers']
        assert(len(peers) == 1 and peers[0]['channels'][0]['state'] == 'CHANNELD_NORMAL')

        # Both nodes should now have exactly one channel in the database
        for n in (l1, l2):
            assert(n.db_query('SELECT COUNT(id) as count FROM channels;')[0]['count'] == 1)

        # Fire off a sendpay request, it'll get interrupted by a restart
        self.executor.submit(self.pay, l1, l2, 10000)
        # Wait for it to be committed to, i.e., stored in the DB
        l1.daemon.wait_for_log('peer_in WIRE_COMMITMENT_SIGNED')

        # Stop l2, l1 will reattempt to connect
        print("Killing l2 in mid HTLC")
        l2.daemon.kill()

        # Clear the disconnect and timer stop so we can proceed normally
        del l2.daemon.opts['dev-disconnect']

        # Wait for l1 to notice
        wait_for(lambda: 'connected' not in l1.rpc.listpeers()['peers'][0]['channels'][0])

        # Now restart l2 and it should reload peers/channels from the DB
        l2.start()
        wait_for(lambda: len(l2.rpc.listpeers()['peers']) == 1)

        # Wait for the restored HTLC to finish
        wait_for(lambda: l1.rpc.listpeers()['peers'][0]['channels'][0]['msatoshi_to_us'] == 99990000, interval=1)

        wait_for(lambda: len([p for p in l1.rpc.listpeers()['peers'] if p['connected']]), interval=1)
        wait_for(lambda: len([p for p in l2.rpc.listpeers()['peers'] if p['connected']]), interval=1)

        # Now make sure this is really functional by sending a payment
        self.pay(l1, l2, 10000)
        time.sleep(1)
        assert l1.rpc.listpeers()['peers'][0]['channels'][0]['msatoshi_to_us'] == 99980000
        assert l2.rpc.listpeers()['peers'][0]['channels'][0]['msatoshi_to_us'] == 20000

        # Finally restart l1, and make sure it remembers
        l1.restart()
        assert l1.rpc.listpeers()['peers'][0]['channels'][0]['msatoshi_to_us'] == 99980000

        # Now make sure l1 is watching for unilateral closes
        l2.rpc.dev_fail(l1.info['id'])
        l2.daemon.wait_for_log('Failing due to dev-fail command')
        l2.daemon.wait_for_log('sendrawtx exit 0')
        bitcoind.generate_block(1)

        # L1 must notice.
        l1.daemon.wait_for_log(' to ONCHAIN')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_payment_success_persistence(self):
        # Start two nodes and open a channel.. die during payment.
        l1 = self.node_factory.get_node(disconnect=['+WIRE_COMMITMENT_SIGNED'],
                                        options={'dev-no-reconnect': None},
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        chanid = self.fund_channel(l1, l2, 100000)

        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')

        # Fire off a pay request, it'll get interrupted by a restart
        self.executor.submit(l1.rpc.pay, inv1['bolt11'])

        l1.daemon.wait_for_log('dev_disconnect: \+WIRE_COMMITMENT_SIGNED')

        print("Killing l1 in mid HTLC")
        l1.daemon.kill()

        # Restart l1, without disconnect stuff.
        del l1.daemon.opts['dev-no-reconnect']
        del l1.daemon.opts['dev-disconnect']

        # Should reconnect, and sort the payment out.
        l1.start()

        wait_for(lambda: l1.rpc.listpayments()['payments'][0]['status'] != 'pending')

        assert l1.rpc.listpayments()['payments'][0]['status'] == 'complete'
        assert l2.rpc.listinvoices('inv1')['invoices'][0]['status'] == 'paid'

        # FIXME: We should re-add pre-announced routes on startup!
        l1.bitcoin.rpc.generate(5)
        l1.wait_channel_active(chanid)

        # A duplicate should succeed immediately (nop) and return correct preimage.
        preimage = l1.rpc.pay(inv1['bolt11'])['payment_preimage']
        assert l1.rpc.dev_rhash(preimage)['rhash'] == inv1['payment_hash']

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_payment_failed_persistence(self):
        # Start two nodes and open a channel.. die during payment.
        l1 = self.node_factory.get_node(disconnect=['+WIRE_COMMITMENT_SIGNED'],
                                        options={'dev-no-reconnect': None},
                                        may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 100000)

        # Expires almost immediately, so it will fail.
        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1', 2)

        # Fire off a pay request, it'll get interrupted by a restart
        self.executor.submit(l1.rpc.pay, inv1['bolt11'])

        l1.daemon.wait_for_log('dev_disconnect: \+WIRE_COMMITMENT_SIGNED')

        print("Killing l1 in mid HTLC")
        l1.daemon.kill()

        # Restart l1, without disconnect stuff.
        del l1.daemon.opts['dev-no-reconnect']
        del l1.daemon.opts['dev-disconnect']

        # Make sure invoice has expired.
        time.sleep(3)

        # Should reconnect, and fail the payment
        l1.start()

        wait_for(lambda: l1.rpc.listpayments()['payments'][0]['status'] != 'pending')

        assert l2.rpc.listinvoices('inv1')['invoices'][0]['status'] == 'expired'
        assert l1.rpc.listpayments()['payments'][0]['status'] == 'failed'

        # Another attempt should also fail.
        self.assertRaises(ValueError, l1.rpc.pay, inv1['bolt11'])

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_payment_duplicate_uncommitted(self):
        # We want to test two payments at the same time, before we send commit
        l1 = self.node_factory.get_node(disconnect=['=WIRE_UPDATE_ADD_HTLC-nocommit'])
        l2 = self.node_factory.get_node()

        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        self.fund_channel(l1, l2, 100000)

        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')

        # Start first payment, but not yet in db.
        fut = self.executor.submit(l1.rpc.pay, inv1['bolt11'])

        # Make sure that's started...
        l1.daemon.wait_for_log('dev_disconnect: =WIRE_UPDATE_ADD_HTLC-nocommit')

        # We should see it in listpayments
        assert l1.rpc.listpayments()['payments'][0]['status'] == 'pending'
        assert l1.rpc.listpayments()['payments'][0]['payment_hash'] == inv1['payment_hash']

        # Second one will succeed eventually.
        fut2 = self.executor.submit(l1.rpc.pay, inv1['bolt11'])

        # Now, let it commit.
        l1.rpc.dev_reenable_commit(l2.info['id'])

        # These should succeed.
        fut.result(10)
        fut2.result(10)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_gossip_badsig(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()

        # l2 connects to both, so l1 can't reconnect and thus l2 drops to chain
        l2.rpc.connect(l1.info['id'], 'localhost', l1.port)
        l2.rpc.connect(l3.info['id'], 'localhost', l3.port)
        self.fund_channel(l2, l1, 10**6)
        self.fund_channel(l2, l3, 10**6)

        # Wait for route propagation.
        l1.bitcoin.generate_block(5)
        l1.daemon.wait_for_log('Received node_announcement for node {}'
                               .format(l3.info['id']))
        assert not l1.daemon.is_in_log('signature verification failed')
        assert not l2.daemon.is_in_log('signature verification failed')
        assert not l3.daemon.is_in_log('signature verification failed')

    @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll")
    def test_waitinvoice(self):
        """Test waiting for one invoice will not return if another invoice
        is paid.
        """
        # Setup
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)
        l1.bitcoin.generate_block(6)
        l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l2.info['id']))

        # Create invoices
        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')
        inv2 = l2.rpc.invoice(1000, 'inv2', 'inv2')
        l2.rpc.invoice(1000, 'inv3', 'inv3')

        # Start waiting on invoice 3
        f3 = self.executor.submit(l2.rpc.waitinvoice, 'inv3')
        # Start waiting on invoice 1, should block
        f = self.executor.submit(l2.rpc.waitinvoice, 'inv1')
        time.sleep(1)
        assert not f.done()
        # Pay invoice 2
        l1.rpc.pay(inv2['bolt11'])
        # Waiter should stil be blocked
        time.sleep(1)
        assert not f.done()
        # Waiting on invoice 2 should return immediately
        r = self.executor.submit(l2.rpc.waitinvoice, 'inv2').result(timeout=5)
        assert r['label'] == 'inv2'
        # Pay invoice 1
        l1.rpc.pay(inv1['bolt11'])
        # Waiter for invoice 1 should now finish
        r = f.result(timeout=5)
        assert r['label'] == 'inv1'
        # Waiter for invoice 3 should still be waiting
        time.sleep(1)
        assert not f3.done()

    @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll")
    def test_waitanyinvoice(self):
        """Test various variants of waiting for the next invoice to complete.
        """
        l1, l2 = self.connect()
        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')
        inv2 = l2.rpc.invoice(1000, 'inv2', 'inv2')
        inv3 = l2.rpc.invoice(1000, 'inv3', 'inv3')

        self.fund_channel(l1, l2, 10**6)

        l1.bitcoin.generate_block(6)
        l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l2.info['id']))

        # Attempt to wait for the first invoice
        f = self.executor.submit(l2.rpc.waitanyinvoice)
        time.sleep(1)

        # The call to waitanyinvoice should not have returned just yet
        assert not f.done()

        # Now pay the first two invoices and make sure we notice
        l1.rpc.pay(inv1['bolt11'])
        l1.rpc.pay(inv2['bolt11'])
        r = f.result(timeout=5)
        assert r['label'] == 'inv1'
        pay_index = r['pay_index']

        # This one should return immediately with inv2
        r = self.executor.submit(l2.rpc.waitanyinvoice, pay_index).result(timeout=5)
        assert r['label'] == 'inv2'
        pay_index = r['pay_index']

        # Now spawn the next waiter
        f = self.executor.submit(l2.rpc.waitanyinvoice, pay_index)
        time.sleep(1)
        assert not f.done()
        l1.rpc.pay(inv3['bolt11'])
        r = f.result(timeout=5)
        assert r['label'] == 'inv3'

        self.assertRaises(ValueError, l2.rpc.waitanyinvoice, 'non-number')

    def test_waitanyinvoice_reversed(self):
        """Test waiting for invoices, where they are paid in reverse order
        to when they are created.
        """
        # Setup
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)
        l1.bitcoin.generate_block(6)
        l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l2.info['id']))

        # Create invoices
        inv1 = l2.rpc.invoice(1000, 'inv1', 'inv1')
        inv2 = l2.rpc.invoice(1000, 'inv2', 'inv2')

        # Pay inv2, wait, pay inv1, wait
        # Pay inv2
        l1.rpc.pay(inv2['bolt11'])
        # Wait - should not block, should return inv2
        r = self.executor.submit(l2.rpc.waitanyinvoice).result(timeout=5)
        assert r['label'] == 'inv2'
        pay_index = r['pay_index']
        # Pay inv1
        l1.rpc.pay(inv1['bolt11'])
        # Wait inv2 - should not block, should return inv1
        r = self.executor.submit(l2.rpc.waitanyinvoice, pay_index).result(timeout=5)
        assert r['label'] == 'inv1'

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1 for --dev-broadcast-interval")
    def test_channel_reenable(self):
        l1, l2 = self.connect(may_reconnect=True)
        self.fund_channel(l1, l2, 10**6)

        l1.bitcoin.generate_block(6)
        l1.daemon.wait_for_log('Received node_announcement for node {}'.format(l2.info['id']))
        l2.daemon.wait_for_log('Received node_announcement for node {}'.format(l1.info['id']))

        # Both directions should be active before the restart
        wait_for(lambda: [c['active'] for c in l1.rpc.listchannels()['channels']] == [True, True])

        # Restart l2, will cause l1 to reconnect
        l2.restart()

        # Now they should sync and re-establish again
        l1.daemon.wait_for_logs(['Received channel_update for channel \\d+:1:1.1.',
                                 'Received channel_update for channel \\d+:1:1.0.'])
        l2.daemon.wait_for_logs(['Received channel_update for channel \\d+:1:1.1.',
                                 'Received channel_update for channel \\d+:1:1.0.'])
        wait_for(lambda: [c['active'] for c in l1.rpc.listchannels()['channels']] == [True, True])

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_update_fee(self):
        l1, l2 = self.connect()
        chanid = self.fund_channel(l1, l2, 10**6)

        # Make l1 send out feechange.
        l1.rpc.dev_setfees('14000')
        l2.daemon.wait_for_log('peer updated fee to 14000')

        # Now make sure an HTLC works.
        # (First wait for route propagation.)
        self.wait_for_routes(l1, [chanid])
        sync_blockheight([l1, l2])

        # Make payments.
        self.pay(l1, l2, 200000000)
        self.pay(l2, l1, 100000000)

        # Now shutdown cleanly.
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chanid, False, 0)
        l1.daemon.wait_for_log(' to CLOSINGD_COMPLETE')
        l2.daemon.wait_for_log(' to CLOSINGD_COMPLETE')

        # And should put closing into mempool.
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        bitcoind.generate_block(99)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_update_all_fees(self):
        l1, l2 = self.connect()
        chan = self.fund_channel(l1, l2, 10**6)

        # Set all fees as positional parameters.
        l1.rpc.dev_setfees('12345', '6789', '123')
        l1.daemon.wait_for_log('dev-setfees: fees now 12345/6789/123')
        l2.daemon.wait_for_log('peer updated fee to 12345')

        # Call setfees with fees passed as named parameters in different order.
        l1.rpc.dev_setfees(slow='123', normal='4567', immediate='8901')
        l1.daemon.wait_for_log('dev-setfees: fees now 8901/4567/123')
        l2.daemon.wait_for_log('peer updated fee to 8901')

        # Set one value at a time.
        l1.rpc.dev_setfees(slow='321')
        l1.daemon.wait_for_log('dev-setfees: fees now 8901/4567/321')
        l1.rpc.dev_setfees(normal='7654')
        l1.daemon.wait_for_log('dev-setfees: fees now 8901/7654/321')
        l1.rpc.dev_setfees(immediate='21098')
        l1.daemon.wait_for_log('dev-setfees: fees now 21098/7654/321')
        l2.daemon.wait_for_log('peer updated fee to 21098')

        # Verify that all fees are indeed optional in setfees call.
        l1.rpc.dev_setfees()
        l1.daemon.wait_for_log('dev-setfees: fees now 21098/7654/321')

        # This should return finish closing.
        l1.rpc.close(chan)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_fee_limits(self):
        # FIXME: Test case where opening denied.
        l1, l2 = self.connect()
        self.fund_channel(l1, l2, 10**6)

        # L1 asks for stupid low fees
        l1.rpc.dev_setfees(15)

        l1.daemon.wait_for_log('Peer permanent failure in CHANNELD_NORMAL: lightning_channeld: received ERROR channel .*: update_fee 15 outside range 1875-75000')
        # Make sure the resolution of this one doesn't interfere with the next!
        # Note: may succeed, may fail with insufficient fee, depending on how
        # bitcoind feels!
        l1.daemon.wait_for_log('sendrawtx exit')

        # Restore to normal.
        l1.rpc.dev_setfees(15000)

        # Try with node which sets --ignore-fee-limits
        l3 = self.node_factory.get_node(options={'ignore-fee-limits': 'true'})
        l1.rpc.connect(l3.info['id'], 'localhost', l3.port)

        chan = self.fund_channel(l1, l3, 10**6)

        # Try stupid high fees
        l1.rpc.dev_setfees(15000 * 10)

        l3.daemon.wait_for_log('peer_in WIRE_UPDATE_FEE')
        l3.daemon.wait_for_log('peer_in WIRE_COMMITMENT_SIGNED')

        # We need to wait until both have committed and revoked the
        # old state, otherwise we'll still try to commit with the old
        # 15sat/byte fee
        l1.daemon.wait_for_log('peer_out WIRE_REVOKE_AND_ACK')

        # This should wait for close to complete
        l1.rpc.close(chan)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_update_fee_reconnect(self):
        # Disconnect after first commitsig.
        disconnects = ['+WIRE_COMMITMENT_SIGNED']
        l1 = self.node_factory.get_node(disconnect=disconnects, may_reconnect=True)
        l2 = self.node_factory.get_node(may_reconnect=True)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        chan = self.fund_channel(l1, l2, 10**6)

        # Make l1 send out feechange; triggers disconnect/reconnect.
        l1.rpc.dev_setfees('14000')
        l1.daemon.wait_for_log('Setting REMOTE feerate to 14000')
        l2.daemon.wait_for_log('Setting LOCAL feerate to 14000')
        l1.daemon.wait_for_log('dev_disconnect: \+WIRE_COMMITMENT_SIGNED')

        # Wait for reconnect....
        l1.daemon.wait_for_log('Applying feerate 14000 to LOCAL')

        self.pay(l1, l2, 200000000)
        self.pay(l2, l1, 100000000)

        # They should both have gotten commits with correct feerate.
        assert l1.daemon.is_in_log('got commitsig [0-9]*: feerate 14000')
        assert l2.daemon.is_in_log('got commitsig [0-9]*: feerate 14000')

        # Now shutdown cleanly.
        l1.rpc.close(chan)

        # And should put closing into mempool.
        l1.daemon.wait_for_log('sendrawtx exit 0')
        l2.daemon.wait_for_log('sendrawtx exit 0')

        bitcoind.generate_block(1)
        l1.daemon.wait_for_log(' to ONCHAIN')
        l2.daemon.wait_for_log(' to ONCHAIN')

        bitcoind.generate_block(99)
        l1.daemon.wait_for_log('onchaind complete, forgetting peer')
        l2.daemon.wait_for_log('onchaind complete, forgetting peer')

    def test_io_logging(self):
        l1 = self.node_factory.get_node(options={'log-level': 'io'})
        l2 = self.node_factory.get_node()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Fundchannel manually so we get channeld pid.
        self.give_funds(l1, 10**6 + 1000000)
        l1.rpc.fundchannel(l2.info['id'], 10**6)['tx']
        pid1 = l1.subd_pid('channeld')

        l1.daemon.wait_for_log('sendrawtx exit 0')
        l1.bitcoin.generate_block(1)
        l1.daemon.wait_for_log(' to CHANNELD_NORMAL')

        pid2 = l2.subd_pid('channeld')
        l2.daemon.wait_for_log(' to CHANNELD_NORMAL')

        # Send it sigusr1: should turn on logging.
        subprocess.run(['kill', '-USR1', pid1])

        fut = self.pay(l1, l2, 200000000, async=True)

        # WIRE_UPDATE_ADD_HTLC = 128 = 0x0080
        l1.daemon.wait_for_log(r'channeld.*:\[OUT\] 0080')
        # WIRE_UPDATE_FULFILL_HTLC = 130 = 0x0082
        l1.daemon.wait_for_log(r'channeld.*:\[IN\] 0082')
        fut.result(10)

        # Send it sigusr1: should turn off logging.
        subprocess.run(['kill', '-USR1', pid1])

        self.pay(l1, l2, 200000000)

        assert not l1.daemon.is_in_log(r'channeld.*:\[OUT\] 0080',
                                       start=l1.daemon.logsearch_start)
        assert not l1.daemon.is_in_log(r'channeld.*:\[IN\] 0082',
                                       start=l1.daemon.logsearch_start)

        # IO logs should not appear in peer logs.
        peerlog = l2.rpc.listpeers(l1.info['id'], "io")['peers'][0]['log']
        assert not any(l['type'] == 'IO_OUT' or l['type'] == 'IO_IN'
                       for l in peerlog)

        # Turn on in l2 channel logging.
        subprocess.run(['kill', '-USR1', pid2])
        self.pay(l1, l2, 200000000)

        # Now it should find it.
        peerlog = l2.rpc.listpeers(l1.info['id'], "io")['peers'][0]['log']
        assert any(l['type'] == 'IO_OUT' for l in peerlog)
        assert any(l['type'] == 'IO_IN' for l in peerlog)

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_pay_disconnect(self):
        """If the remote node has disconnected, we fail payment, but can try again when it reconnects"""
        l1, l2 = self.connect()

        chanid = self.fund_channel(l1, l2, 10**6)

        # Wait for route propagation.
        self.wait_for_routes(l1, [chanid])

        inv = l2.rpc.invoice(123000, 'test_pay_disconnect', 'description')
        rhash = inv['payment_hash']

        # Can't use `pay` since that'd notice that we can't route, due to disabling channel_update
        route = l1.rpc.getroute(l2.info['id'], 123000, 1)["route"]

        # Make l2 upset by asking for crazy fee.
        l1.rpc.dev_setfees('150000')
        # Wait for l1 notice
        l1.daemon.wait_for_log(r'Peer permanent failure in CHANNELD_NORMAL: lightning_channeld: received ERROR channel .*: update_fee 150000 outside range 1875-75000')

        # Can't pay while its offline.
        self.assertRaises(ValueError, l1.rpc.sendpay, to_json(route), rhash)
        l1.daemon.wait_for_log('failed: WIRE_TEMPORARY_CHANNEL_FAILURE \\(First peer not ready\\)')

        # Should fail due to temporary channel fail
        self.assertRaises(ValueError, l1.rpc.sendpay, to_json(route), rhash)
        l1.daemon.wait_for_log('failed: WIRE_TEMPORARY_CHANNEL_FAILURE \\(First peer not ready\\)')
        assert not l1.daemon.is_in_log('Payment is still in progress')

        # After it sees block, someone should close channel.
        bitcoind.generate_block(1)
        l1.daemon.wait_for_log('ONCHAIN')

    def test_address(self):
        l1 = self.node_factory.get_node()
        addr = l1.rpc.getinfo()['address']
        if 'dev-allow-localhost' in l1.daemon.opts:
            assert len(addr) == 1
            assert addr[0]['type'] == 'ipv4'
            assert addr[0]['address'] == '127.0.0.1'
            assert int(addr[0]['port']) == l1.port
        else:
            assert len(addr) == 0

        bind = l1.rpc.getinfo()['binding']
        assert len(bind) == 1
        assert bind[0]['type'] == 'ipv4'
        assert bind[0]['address'] == '127.0.0.1'
        assert int(bind[0]['port']) == l1.port

    def test_listconfigs(self):
        l1 = self.node_factory.get_node()

        configs = l1.rpc.listconfigs()
        # See utils.py
        assert configs['bitcoin-datadir'] == bitcoind.bitcoin_dir
        assert configs['lightning-dir'] == l1.daemon.lightning_dir
        assert configs['allow-deprecated-apis'] is False
        assert configs['network'] == 'regtest'
        assert configs['ignore-fee-limits'] is False

        # Test one at a time.
        for c in configs.keys():
            if c.startswith('#'):
                continue
            oneconfig = l1.rpc.listconfigs(config=c)
            assert(oneconfig[c] == configs[c])

    @unittest.skipIf(not DEVELOPER, "Too slow without --dev-bitcoind-poll")
    def test_multiple_channels(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()

        for i in range(3):
            # FIXME: we shouldn't disconnect on close?
            ret = l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
            assert ret['id'] == l2.info['id']

            l1.daemon.wait_for_log('Handing back peer .* to master')
            l2.daemon.wait_for_log('Handing back peer .* to master')
            chan = self.fund_channel(l1, l2, 10**6)

            l1.rpc.close(chan)

        channels = l1.rpc.listpeers()['peers'][0]['channels']
        assert len(channels) == 3
        # Most in state ONCHAIN, last is CLOSINGD_COMPLETE
        for i in range(len(channels) - 1):
            assert channels[i]['state'] == 'ONCHAIN'
        assert channels[-1]['state'] == 'CLOSINGD_COMPLETE'

    def test_multirpc(self):
        """Test that we can do multiple RPC without waiting for response"""
        l1 = self.node_factory.get_node()

        sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
        sock.connect(l1.rpc.socket_path)

        commands = [
            b'{"id":1,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"id":2,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"id":3,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"id":4,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"id":5,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"id":6,"jsonrpc":"2.0","method":"listpeers","params":[]}',
            b'{"method": "invoice", "params": [100, "foo", "foo"], "jsonrpc": "2.0", "id": 7 }',
            b'{"method": "waitinvoice", "params": ["foo"], "jsonrpc" : "2.0", "id": 8 }',
            b'{"method": "delinvoice", "params": ["foo", "unpaid"], "jsonrpc" : "2.0", "id": 9 }',
        ]

        sock.sendall(b'\n'.join(commands))

        l1.rpc._readobj(sock)
        sock.close()

    def test_cli(self):
        l1 = self.node_factory.get_node()

        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       'help']).decode('utf-8')
        # Test some known output.
        assert 'help\n    List available commands, or give verbose help on one command' in out

        # Test JSON output.
        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       '-J',
                                       'help']).decode('utf-8')
        j, _ = json.JSONDecoder().raw_decode(out)
        assert j['help'][0]['command'] is not None
        assert j['help'][0]['description'] is not None

        # Test keyword input (autodetect)
        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       '-J',
                                       'help', 'command=help']).decode('utf-8')
        j, _ = json.JSONDecoder().raw_decode(out)
        assert 'help [command]' in j['verbose']

        # Test keyword input (forced)
        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       '-J', '-k',
                                       'help', 'command=help']).decode('utf-8')
        j, _ = json.JSONDecoder().raw_decode(out)
        assert 'help [command]' in j['verbose']

        # Test ordered input (autodetect)
        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       '-J',
                                       'help', 'help']).decode('utf-8')
        j, _ = json.JSONDecoder().raw_decode(out)
        assert 'help [command]' in j['verbose']

        # Test ordered input (forced)
        out = subprocess.check_output(['cli/lightning-cli',
                                       '--lightning-dir={}'
                                       .format(l1.daemon.lightning_dir),
                                       '-J', '-o',
                                       'help', 'help']).decode('utf-8')
        j, _ = json.JSONDecoder().raw_decode(out)
        assert 'help [command]' in j['verbose']

        # Test missing parameters.
        try:
            # This will error due to missing parameters.
            # We want to check if lightningd will crash.
            out = subprocess.check_output(['cli/lightning-cli',
                                           '--lightning-dir={}'
                                           .format(l1.daemon.lightning_dir),
                                           '-J', '-o',
                                           'sendpay']).decode('utf-8')
        except Exception:
            pass

    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_forget_channel(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        self.give_funds(l1, 10**6)
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.fundchannel(l2.info['id'], 10**5)

        assert len(l1.rpc.listpeers()['peers']) == 1

        # This should fail, the funding tx is in the mempool and may confirm
        self.assertRaisesRegex(ValueError,
                               "Cowardly refusing to forget channel",
                               l1.rpc.dev_forget_channel, l2.info['id'])
        assert len(l1.rpc.listpeers()['peers']) == 1

        # Forcing should work
        l1.rpc.dev_forget_channel(l2.info['id'], True)
        assert len(l1.rpc.listpeers()['peers']) == 0

        # And restarting should keep that peer forgotten
        l1.restart()
        assert len(l1.rpc.listpeers()['peers']) == 0

    def test_peerinfo(self):
        l1, l2 = self.connect()
        # Gossiping but no node announcement yet
        assert l1.rpc.getpeer(l2.info['id'])['state'] == "GOSSIPING"
        assert 'alias' not in l1.rpc.getpeer(l2.info['id'])
        assert 'color' not in l1.rpc.getpeer(l2.info['id'])

        # Fund a channel to force a node announcement
        chan = self.fund_channel(l1, l2, 10**6)
        # Now proceed to funding-depth and do a full gossip round
        bitcoind.generate_block(5)
        l1.daemon.wait_for_logs(['Received node_announcement for node ' + l2.info['id']])

        # With the node announcement, ensure we see that information in the peer info
        assert l1.rpc.getpeer(l2.info['id'])['alias'] == l1.rpc.listnodes(l2.info['id'])['nodes'][0]['alias']
        assert l1.rpc.getpeer(l2.info['id'])['color'] == l1.rpc.listnodes(l2.info['id'])['nodes'][0]['color']

        # Close the channel to forget the peer
        self.assertRaisesRegex(ValueError,
                               "Channel close negotiation not finished",
                               l1.rpc.close, chan, False, 0)
        l1.daemon.wait_for_log('Forgetting remote peer')
        bitcoind.generate_block(100)
        l1.daemon.wait_for_log('WIRE_ONCHAIN_ALL_IRREVOCABLY_RESOLVED')
        l2.daemon.wait_for_log('WIRE_ONCHAIN_ALL_IRREVOCABLY_RESOLVED')

        # The only channel was closed, everybody should have forgotten the nodes
        assert l1.rpc.listnodes()['nodes'] == []
        assert l2.rpc.listnodes()['nodes'] == []

    @flaky
    @unittest.skipIf(not DEVELOPER, "needs DEVELOPER=1")
    def test_blockchaintrack(self):
        """Check that we track the blockchain correctly across reorgs
        """
        l1 = self.node_factory.get_node(random_hsm=True)
        addr = l1.rpc.newaddr()['address']

        ######################################################################
        # First failure scenario: rollback on startup doesn't work,
        # and we try to add a block twice when rescanning:
        l1.restart()

        height = bitcoind.rpc.getblockcount()

        # At height 111 we receive an incoming payment
        hashes = bitcoind.rpc.generate(9)
        bitcoind.rpc.sendtoaddress(addr, 1)
        time.sleep(1)  # mempool is still unpredictable
        bitcoind.rpc.generate(1)

        l1.daemon.wait_for_log(r'Owning')
        outputs = l1.rpc.listfunds()['outputs']
        assert len(outputs) == 1

        ######################################################################
        # Second failure scenario: perform a 20 block reorg
        bitcoind.rpc.generate(10)
        l1.daemon.wait_for_log('Adding block {}: '.format(height + 20))

        # Now reorg out with a longer fork of 21 blocks
        bitcoind.rpc.invalidateblock(hashes[0])
        bitcoind.wait_for_log(r'InvalidChainFound: invalid block=.*  height={}'
                              .format(height + 1))
        hashes = bitcoind.rpc.generate(30)
        time.sleep(1)

        bitcoind.rpc.getblockcount()
        l1.daemon.wait_for_log('Adding block {}: '.format(height + 30))

        # Our funds got reorged out, we should not have any funds that are confirmed
        assert [o for o in l1.rpc.listfunds()['outputs'] if o['status'] != "unconfirmed"] == []

    def test_disconnectpeer(self):
        l1 = self.node_factory.get_node()
        l2 = self.node_factory.get_node()
        l3 = self.node_factory.get_node()
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)
        l1.rpc.connect(l3.info['id'], 'localhost', l3.port)

        # Gossiping
        assert l1.rpc.getpeer(l2.info['id'])['state'] == "GOSSIPING"
        assert l1.rpc.getpeer(l3.info['id'])['state'] == "GOSSIPING"

        # Disconnect l2 from l1
        l1.rpc.disconnect(l2.info['id'])

        # Make sure listpeers no longer returns the disconnected node
        assert l1.rpc.getpeer(l2.info['id']) is None
        assert l2.rpc.getpeer(l1.info['id']) is None

        # Make sure you cannot disconnect after disconnecting
        self.assertRaisesRegex(ValueError, "Peer not connected",
                               l1.rpc.disconnect, l2.info['id'])
        self.assertRaisesRegex(ValueError, "Peer not connected",
                               l2.rpc.disconnect, l1.info['id'])

        # Fund channel l1 -> l3
        self.fund_channel(l1, l3, 10**6)
        bitcoind.generate_block(5)

        # disconnecting a non gossiping peer results in error
        self.assertRaisesRegex(ValueError, "Peer is not in gossip mode",
                               l1.rpc.disconnect, l3.info['id'])

    def test_rescan(self):
        """Test the rescan option
        """
        l1 = self.node_factory.get_node()

        # The first start should start at current_height - 30 = 71, make sure
        # it's not earlier
        l1.daemon.wait_for_log(r'Adding block 101')
        assert not l1.daemon.is_in_log(r'Adding block 70')

        # Restarting with a higher rescan should go back further
        l1.daemon.opts['rescan'] = 50
        l1.restart()
        l1.daemon.wait_for_log(r'Adding block 101')
        assert l1.daemon.is_in_log(r'Adding block 51')
        assert not l1.daemon.is_in_log(r'Adding block 50')

        # Restarting with an absolute rescan should start from there
        l1.daemon.opts['rescan'] = -31
        l1.restart()
        l1.daemon.wait_for_log(r'Adding block 101')
        assert l1.daemon.is_in_log(r'Adding block 31')
        assert not l1.daemon.is_in_log(r'Adding block 30')

        # Restarting with a future absolute blockheight should just start with
        # the current height
        l1.daemon.opts['rescan'] = -500000
        l1.stop()
        bitcoind.rpc.generate(4)
        l1.start()
        l1.daemon.wait_for_log(r'Adding block 105')
        assert not l1.daemon.is_in_log(r'Adding block 102')

    @unittest.skipIf(not DEVELOPER, "needs --dev-max-funding-unconfirmed-blocks")
    def test_fundee_forget_funding_tx_unconfirmed(self):
        """Test that fundee will forget the channel if
        the funding tx has been unconfirmed for too long.
        """
        # Keep this low (default is 2016), since everything
        # is much slower in VALGRIND mode and wait_for_log
        # could time out before lightningd processes all the
        # blocks.
        blocks = 200
        # funder
        l1 = self.node_factory.get_node(fake_bitcoin_cli=True)
        # fundee
        l2 = self.node_factory.get_node(options={"dev-max-funding-unconfirmed-blocks": blocks})
        l1.rpc.connect(l2.info['id'], 'localhost', l2.port)

        # Give funder some funds.
        self.give_funds(l1, 10**7)
        # Let blocks settle.
        time.sleep(1)

        # Prevent funder from broadcasting funding tx.
        self.fake_bitcoind_fail(l1, 1)
        # Fund the channel.
        # The process will complete, but funder will be unable
        # to broadcast and confirm funding tx.
        l1.rpc.fundchannel(l2.info['id'], 10**6)
        # Prevent l1 from timing out bitcoin-cli.
        self.fake_bitcoind_unfail(l1)
        # Generate blocks until unconfirmed.
        bitcoind.generate_block(blocks)

        # fundee will forget channel!
        l2.daemon.wait_for_log('Forgetting channel: It has been {} blocks'.format(blocks))
        # fundee will also forget and disconnect from peer.
        assert len(l2.rpc.listpeers(l1.info['id'])['peers']) == 0


if __name__ == '__main__':
    unittest.main(verbosity=2)