Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that our org uses shared workflows from openedx, not edx #32

Open
kdmccormick opened this issue Nov 9, 2022 · 0 comments
Open

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Nov 9, 2022

Context

Acceptance Criteria

  • For every repo in the openedx org:
    • For every GitHub Action workflow in the repo:
      • Ensure that any and all shared workflow references point to the openedx organization, not the edx organization.

Examples

What we want: https://github.com/openedx/acid-block/blob/1f76d2860013cb2e046bb1659c5c74b76775b50c/.github/workflows/commitlint.yml#L10

What we don't want: https://github.com/openedx/api-doc-tools/blob/81edb71fd132a66280be3af822c88e224bfb4f83/.github/workflows/commitlint.yml#L10

Notes

GitHub search can be used to find offending examples, e.g.: https://github.com/search?q=%22edx%2F.github%2F.github%2Fworkflows%2Fcommitlint%22+org%3Aopenedx&type=code

If we want to automate this, we could use @feanil 's new repo checks framework. Specifically, we add a Check subclass that:

  • in the is_relevant(...) method, returned True;
  • in the check(...) method, searched for the substring "uses: edx/" within all YAML files in the .github directory;
  • in the fix(...) method, opened a PR to replace "uses: edx/" with "uses: openedx/".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant