Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: option for version #110

Open
thomasgeissl opened this issue Jan 4, 2016 · 4 comments
Open

Feature: option for version #110

thomasgeissl opened this issue Jan 4, 2016 · 4 comments

Comments

@thomasgeissl
Copy link
Contributor

Hello,
can we add an option to the command line app get the version? Also, I think it would be useful if it is shown on the gui.
I mostly just use the spotlight search on osx to open the projectGenerator and it does not tell me about the version and location. So I am never sure version I am using.
I think showing this on the gui would be very useful for referencing, especially for forum posts.
Can this be automated to show the current tag/commit?
What do you think about adding a version option?
Thomas

@ofZach
Copy link
Contributor

ofZach commented Jan 4, 2016

I think this is a great idea... happy to take a PR on the command line app if you want to jump in. I can think about how to display this in the gui app. (there's already good example in the gui app of interacting with the command line app and parsing the output when you do a generate or update, here we'd call -v at the start of the gui app and use that value somewhere)

@thomasgeissl
Copy link
Contributor Author

I will see what I can do. Not sure how to do the versioning. Can we automatically store the current commit in data/version.txt? Are there more elegant solutions?

@ofZach
Copy link
Contributor

ofZach commented Jan 4, 2016

in OF we use a # define for version and it's part of a checklist to increment it. I'd think something similar would work here...

@thomasgeissl
Copy link
Contributor Author

This does not mean it is incremented automatically, right? So i guess we have to talk more about versioning.
A few things on this:

  • Will this repo get merged into the main oF repo? If this is the case should we have separate versioning?
  • Should we tag releases? This way we could e.g. write a brew formula.
  • What kind of versioning should we use? Semantic versioning (major.minor.patch)?
  • When will the version be incremented? Every commit? I don't think this makes sense, if we have to do it manually.

Edit: Forget the brew formula. This won't work because of the oF dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants