Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron version uses wrong project generator command line executable #114

Open
Meach opened this issue Feb 12, 2016 · 3 comments
Open

Electron version uses wrong project generator command line executable #114

Meach opened this issue Feb 12, 2016 · 3 comments

Comments

@Meach
Copy link

Meach commented Feb 12, 2016

Hi,

I was testing the new project generator done with Electron and found a bug.
I followed the readme to install it, I built an updated version of commandLine project beforehand, then moving the binary to frontend/app folder.

Then in the PG, when generating/updating a project, it uses frontend/app/projectGenerator...which gave me error such as:

'projectGenerator' is not recognized as an internal or external command, operable program or batch file.

To fix this, I had to change in frontend/index.js (line 650):

pgApp = pathTemp.normalize(pathTemp.join(pathTemp.join(__dirname, "app"), "projectGenerator"));

to this:

pgApp = pathTemp.normalize(pathTemp.join(pathTemp.join(__dirname, "app"), "commandLine"));

So that it uses commandLine instead of projectGenerator. Then it was generating/updating projects correctly.

I am on Windows 7 also, not sure if it matters.

@Meach
Copy link
Author

Meach commented Feb 12, 2016

Actually I just tried on OSX and it's all good: when compiling the commandLine project, it provides a projectGenerator binary, which then works correctly with the electron PG.

Then the problem is with Visual Studio for the commandLine project: the name of the executable should be "projectGenerator" and no "commandLine".

@ofZach
Copy link
Contributor

ofZach commented Feb 12, 2016

can you open an issue here: https://github.com/openframeworks/projectGenerator ? I think we do renaming this app as part of our packaging.

@arturoc
Copy link
Member

arturoc commented Feb 12, 2016

yes, the bin name should stay as projectGenerator but for visual studio there's still no way to set the bin name when we generate the project file automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants