Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing JOSS review comments #10

Closed
giswqs opened this issue Feb 5, 2021 · 1 comment
Closed

Addressing JOSS review comments #10

giswqs opened this issue Feb 5, 2021 · 1 comment
Assignees

Comments

@giswqs
Copy link
Member

giswqs commented Feb 5, 2021

This issue is for addressing the JOSS reviewers' comments. openjournals/joss-reviews#2965

@giswqs giswqs self-assigned this Feb 5, 2021
giswqs added a commit that referenced this issue Feb 10, 2021
giswqs added a commit that referenced this issue Feb 10, 2021
giswqs added a commit that referenced this issue Feb 10, 2021
giswqs added a commit that referenced this issue Feb 10, 2021
giswqs added a commit that referenced this issue Feb 10, 2021
giswqs added a commit that referenced this issue Feb 11, 2021
giswqs added a commit that referenced this issue Feb 11, 2021
giswqs added a commit that referenced this issue Feb 11, 2021
giswqs added a commit that referenced this issue Feb 15, 2021
giswqs added a commit that referenced this issue Feb 15, 2021
giswqs added a commit that referenced this issue Feb 15, 2021
giswqs added a commit that referenced this issue Feb 15, 2021
@amanaster2
Copy link

amanaster2 commented Feb 27, 2021

JOSS review comment

Installation instruction suggestions:

  • Need clarity regarding which method to use for installing (mamba vs. pip). I was not able to get the mamba installation of lidar working on either computer I tried it on. It would be safer to assume that folks don't have the necessary dependencies (i.e., GDAL, richdem) already installed, especially if they're creating a new environment.
  • Include the Dependencies section of documentation with the Installation section for ease of use.
  • Under Dependencies, the Windows subsection is essentially a repeat of the initial command provided in the section. Suggest either removing one of the commands or making the commands the same. (Second command has pip install richdem, and I found that pip install lidar gives richdem, so that line isn't necessary.)

giswqs added a commit that referenced this issue Feb 27, 2021
giswqs added a commit that referenced this issue Feb 27, 2021
giswqs added a commit that referenced this issue Feb 27, 2021
giswqs added a commit that referenced this issue Feb 27, 2021
giswqs added a commit that referenced this issue Mar 1, 2021
giswqs added a commit that referenced this issue Mar 1, 2021
@giswqs giswqs closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants