Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: funkyheatmap: Visualising data frames with mixed data types #7590

Open
editorialbot opened this issue Dec 15, 2024 · 20 comments
Open
Labels
pre-review query-scope Submissions of uncertain scope for JOSS R Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @LouiseDck (Louise Deconinck)
Repository: https://github.com/funkyheatmap/funkyheatmap
Branch with paper.md (empty if default branch):
Version: 0.5.0
Editor: Pending
Reviewers: Pending
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4345bc25b2c78ea510e09b51fa1ef990"><img src="https://joss.theoj.org/papers/4345bc25b2c78ea510e09b51fa1ef990/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4345bc25b2c78ea510e09b51fa1ef990/status.svg)](https://joss.theoj.org/papers/4345bc25b2c78ea510e09b51fa1ef990)

Author instructions

Thanks for submitting your paper to JOSS @LouiseDck. Currently, there isn't a JOSS editor assigned to your paper.

@LouiseDck if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 15, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (1585.8 files/s, 234964.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              1              0              0           3950
R                               43            327            737           2919
YAML                             8             67             12            400
Markdown                         5            122              0            313
Rmd                              5            149            292            296
TeX                              2             14              0            151
JSON                             1              1              0             14
Bourne Shell                     1              3              2             10
-------------------------------------------------------------------------------
SUM:                            66            683           1043           8053
-------------------------------------------------------------------------------

Commit count by author:

   120	Robrecht Cannoodt
     5	Louise Deconinck
     1	Luke Zappia
     1	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/978-0-387-98141-3 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1109/TVCG.2011.185 is OK
- 10.1038/s41587-019-0071-9 is OK
- 10.1038/s41592-021-01336-8 is OK
- 10.1038/s41587-020-0469-4 is OK
- 10.1101/642926 is OK
- 10.1093/bioinformatics/btac805 is OK
- 10.1101/2023.03.22.533802 is OK
- 10.48550/arXiv.2110.11494 is OK
- 10.1038/s41467-023-37168-7 is OK
- 10.21203/rs.3.rs-4181617/v1 is OK

🟡 SKIP DOIs

- None

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 902

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🟡 License found: Other (Check here for OSI approval)

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Robrecht Cannoodt*, perhaps the affiliations index need quoting?.

@danielskatz
Copy link

👋 @LouiseDck - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

@LouiseDck
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HiPart: Hierarchical Divisive Clustering Toolbox
Submitting author: @panagiotisanagnostou
Handling editor: @jbytecode (Active)
Reviewers: @AP6YC, @jjerphan
Similarity score: 0.6624

cellanneal: A user-friendly deconvolution software for transcriptomics data
Submitting author: @libuchauer
Handling editor: @jmschrei (Active)
Reviewers: @ritika-giri, @ManavalanG
Similarity score: 0.6558

MiscMetabar: an R package to facilitate visualization and reproducibility in metabarcoding analysis
Submitting author: @adrientaudiere
Handling editor: @kellyrowland (Active)
Reviewers: @tkchafin, @iimog
Similarity score: 0.6517

scTree: An R package to generate antibody-compatible classifiers from single-cell sequencing data
Submitting author: @jspaezp
Handling editor: @will-rowe (Retired)
Reviewers: @mschubert, @jenzopr
Similarity score: 0.6504

MorphoPy: A python package for feature extraction of neural morphologies.
Submitting author: @visdoom
Handling editor: @oliviaguest (Active)
Reviewers: @Emptymalei, @mstimberg
Similarity score: 0.6500

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @LouiseDck - please add countries to all affiliations.

I'm also unsure why you use "{funkyheatmap}" in your paper in a number of places. Are the {}s coming from some type of formatting instruction?

Also, there is a References heading missing at the end of the paper, so the references look like they are part of the Acknowledgments. Please add this.

Finally, I am going to ask the JOSS editors to take a look at this, as it's not clear to me that this is research software as defined by JOSS. You should hear back in a couple of weeks or so, due to the holidays.

@danielskatz
Copy link

@editorialbot query scope

@editorialbot
Copy link
Collaborator Author

Submission flagged for editorial review.

@editorialbot editorialbot added the query-scope Submissions of uncertain scope for JOSS label Dec 17, 2024
@LouiseDck
Copy link

LouiseDck commented Dec 17, 2024

@editorialbot generate pdf

Thanks @danielskatz for the speed of your reply! I've adapted the references and added the references section. I hope this will be fine now 🤞

The curly-brace thing is a convention in the R community, and is used to denote the name of a package. I don't know where this convention originated, but it is common and still in use, e.g: here

If I may make a case for this piece of software: I think benchmarking is a key part of the scientific process, and software like this enhances the usability of these benchmarks -- For big benchmarks it's a very useful way to communicate results clearly (you simply can't do this effectively with only a huge table full of numbers). For that reason I do think it fits within "extracting knowledge from data" or "supports the execution of research experiments" (as a benchmarking study is a kind of research experiment.)
But of course I will await the editorial review, thanks for the consideration!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

HiPart: Hierarchical Divisive Clustering Toolbox
Submitting author: @panagiotisanagnostou
Handling editor: @jbytecode (Active)
Reviewers: @AP6YC, @jjerphan
Similarity score: 0.6626

cellanneal: A user-friendly deconvolution software for transcriptomics data
Submitting author: @libuchauer
Handling editor: @jmschrei (Active)
Reviewers: @ritika-giri, @ManavalanG
Similarity score: 0.6552

MiscMetabar: an R package to facilitate visualization and reproducibility in metabarcoding analysis
Submitting author: @adrientaudiere
Handling editor: @kellyrowland (Active)
Reviewers: @tkchafin, @iimog
Similarity score: 0.6520

MorphoPy: A python package for feature extraction of neural morphologies.
Submitting author: @visdoom
Handling editor: @oliviaguest (Active)
Reviewers: @Emptymalei, @mstimberg
Similarity score: 0.6501

scTree: An R package to generate antibody-compatible classifiers from single-cell sequencing data
Submitting author: @jspaezp
Handling editor: @will-rowe (Retired)
Reviewers: @mschubert, @jenzopr
Similarity score: 0.6500

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@LouiseDck
Copy link

@editorialbot generate pdf

Sorry, this should be fine now 😅

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

MiscMetabar: an R package to facilitate visualization and reproducibility in metabarcoding analysis
Submitting author: @adrientaudiere
Handling editor: @kellyrowland (Active)
Reviewers: @tkchafin, @iimog
Similarity score: 0.6528

tidyHeatmap: an R package for modular heatmap production based on tidy principles
Submitting author: @stemangiola
Handling editor: @karthik (Retired)
Reviewers: @rlbarter, @AliciaSchep
Similarity score: 0.6499

PCRedux: A Quantitative PCR Machine Learning Toolkit
Submitting author: @devSJR
Handling editor: @csoneson (Active)
Reviewers: @jaybee84, @markziemann
Similarity score: 0.6492

CGIMP: Real-time exploration and covariate projection for self-organizing map datasets
Submitting author: @adadiehl
Handling editor: @lpantano (Active)
Reviewers: @adriancbondia, @ @arunhpatil, @arunhpatil
Similarity score: 0.6317

pivmet: an R package proposing pivotal methods for consensus clustering and mixture modelling
Submitting author: @LeoEgidi
Handling editor: @skanwal (Active)
Reviewers: @adriancorrendo, @larryshamalama
Similarity score: 0.6265

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@rcannood
Copy link

rcannood commented Dec 17, 2024

@danielskatz Thanks for being the managing EiC for this submission!

Finally, I am going to ask the JOSS editors to take a look at this, as it's not clear to me that this is research software as defined by JOSS. You should hear back in a couple of weeks or so, due to the holidays.

Just to weigh in on this -- I would argue it definitely falls under JOSS' definition of research software:

JOSS publishes articles about research software. This definition includes software that: solves complex modeling problems in a scientific context (physics, mathematics, biology, medicine, social science, neuroscience, engineering); supports the functioning of research instruments or the execution of research experiments; extracts knowledge from large data sets; offers a mathematical library, or similar. While useful for many areas of research, pre-trained machine learning models and notebooks are not in-scope for JOSS.

Since this package was developed and specifically catered to being able to showcase results from (bioinformatics) benchmarking studies. Therefore it supports the execution of research experiments, and extracts knowledge from the raw benchmarking results. A showcase of which studies (derivatives of) funkyheatmap have been used in is shown here.

An example of how funkyheatmap extracts knowledge from large datasets: on the openproblems website funkyheatmap is used to summarise the results ( https://openproblems.bio/results/label_projection/ ) based on the raw data from the benchmark ( https://openproblems.bio/results/label_projection/data/results.json ).

One final note, it was originally part of a repository from a different study ( https://github.com/dynverse/dynbenchmark/blob/master/package/R/funky_heatmap.R ) but we decided to turn into a standalone package since there was a lot of interest from the research community.

🙇 Thank you for taking this into consideration and hope for a positive response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review query-scope Submissions of uncertain scope for JOSS R Shell TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests

4 participants