Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: JcampConverter - An open source for parsing Jcamp DX file for mobile applications #7592

Open
editorialbot opened this issue Dec 16, 2024 · 8 comments
Labels
pre-review Ruby Swift TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 16, 2024

Submitting author: @baolanlequang (Lan B. Q. Le)
Repository: https://github.com/baolanlequang/jcamp-converter-ios
Branch with paper.md (empty if default branch): joss_paperpaper
Version: 0.1.1
Editor: Pending
Reviewers: Pending
Managing EiC: Kevin Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0604ccc2ecf4296840c2417a15f0cb29"><img src="https://joss.theoj.org/papers/0604ccc2ecf4296840c2417a15f0cb29/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0604ccc2ecf4296840c2417a15f0cb29/status.svg)](https://joss.theoj.org/papers/0604ccc2ecf4296840c2417a15f0cb29)

Author instructions

Thanks for submitting your paper to JOSS @baolanlequang. Currently, there isn't a JOSS editor assigned to your paper.

@baolanlequang if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 16, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1206.5 files/s, 105601.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Swift                           11            194             84            917
TeX                              1              0              0            180
Markdown                         2             68              0            179
XML                              4              0              0             35
YAML                             1              1              4             19
Ruby                             1             34             88             17
C/C++ Header                     1              6              9              3
-------------------------------------------------------------------------------
SUM:                            21            303            185           1350
-------------------------------------------------------------------------------

Commit count by author:

    25	baolan2005
    15	Lan Le
    11	Bao Lan Le Quang

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1665

🔴 Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.5281/zenodo.8368258 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Kotlin Language
- No DOI given, and none found for title: Swift Language
- No DOI given, and none found for title: JCAMP-dx test data
- No DOI given, and none found for title: JCAMP-DX: A standard form for exchange of infrared...
- No DOI given, and none found for title: JCAMP-DX for nmr
- No DOI given, and none found for title: JCamp converter test data
- No DOI given, and none found for title: CocoaPods
- No DOI given, and none found for title: jcamp-converter-ios
- No DOI given, and none found for title: JitPack
- No DOI given, and none found for title: jcamp-converter-android
- No DOI given, and none found for title: ChemDraw
- No DOI given, and none found for title: MestRe nova

❌ MISSING DOIs

- 10.1186/s13321-020-00481-0 may be a valid DOI for title: ChemSpectra: a web-based spectra editor for analyt...
- 10.1515/iupac.71.0167 may be a valid DOI for title: An extension to the JCAMP-DX standard file format,...
- 10.1186/1752-153x-1-31 may be a valid DOI for title: The JSpecView Project: an Open Source Java viewer ...
- 10.1255/sew.2021.a18 may be a valid DOI for title: NMRium browser-based nuclear magnetic resonance da...
- 10.1107/s1600576719004229 may be a valid DOI for title: Raman Open Database: first interconnected Raman–X-...
- 10.1016/j.forc.2018.05.003 may be a valid DOI for title: NPS Data Hub: a web-based community driven analyti...
- 10.1007/s10858-013-9718-x may be a valid DOI for title: Nmrglue: an open source Python package for the ana...
- 10.26226/morressier.5fd757103d762219be34f38d may be a valid DOI for title: European Open Science Cloud
- 10.1007/s00287-021-01392-6 may be a valid DOI for title: Nationale Forschungsdateninfrastruktur (NFDI)
- 10.1186/s13321-017-0240-0 may be a valid DOI for title: Chemotion ELN: an Open Source electronic lab noteb...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

Cellpy – an open-source library for processing and analysis of battery testing data
Submitting author: @jepegit
Handling editor: @mbarzegary (Active)
Reviewers: @MaximevdHeijden, @TomTranter, @ma-sadeghi
Similarity score: 0.5818

SPyCi-PDB: A modular command-line interface for back-calculating experimental datatypes of protein structures.
Submitting author: @menoliu
Handling editor: @ppxasjsm (Active)
Reviewers: @dotsdl, @lohedges, @JenkeScheen, @sulstice
Similarity score: 0.5792

LIBSsa: an open source software for analyzing LIBS spectra
Submitting author: @kstenio
Handling editor: @csoneson (Active)
Reviewers: @domna, @alberto-battistel, @Tillsten
Similarity score: 0.5774

GNU Data Language 1.0: a free/libre and open-source drop-in replacement for IDL/PV-WAVE
Submitting author: @pjb7687
Handling editor: @gkthiruvathukal (Active)
Reviewers: @mgalloy, @mohawk2
Similarity score: 0.5682

subMALDI: an open framework R package for processing irregularly-spaced mass spectrometry data
Submitting author: @wesleyburr
Handling editor: @pibion (Retired)
Reviewers: @jspaezp, @sigven, @tystan
Similarity score: 0.5660

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@danielskatz
Copy link

👋 @baolanlequang - Thanks for your submission.

However, the paper (as seen in the proof above) has a lot of problems, ranging from non-idiomatic English that makes it hard to understand to problems with section and figure labels to references that are missing DOIs to the lack of a Statement of Need section.

Before you work on any of these, I'm going to have an internal discussion about which track this should be in, and there will also likely be a discussion about if this is in-scope for JOSS based on if it meets the substantial scholarly effort criterion and if it is research software, both as defined by JOSS.

You should hear back in a few weeks.

@editorialbot editorialbot added Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Ruby Swift TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

2 participants