Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Curio: Unsupervised Topic Modeling in Swift #7597

Open
editorialbot opened this issue Dec 17, 2024 · 22 comments
Open

[PRE REVIEW]: Curio: Unsupervised Topic Modeling in Swift #7597

editorialbot opened this issue Dec 17, 2024 · 22 comments
Assignees
Labels
pre-review Shell Swift TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Dec 17, 2024

Submitting author: @JimWallace (James R. Wallace)
Repository: https://git.uwaterloo.ca/jrwallace/curio
Branch with paper.md (empty if default branch):
Version: 0.0.10
Editor: @jbytecode
Reviewers: Pending
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/fbbefaa1ad3bb51af9c962ae1240a7a6"><img src="https://joss.theoj.org/papers/fbbefaa1ad3bb51af9c962ae1240a7a6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/fbbefaa1ad3bb51af9c962ae1240a7a6/status.svg)](https://joss.theoj.org/papers/fbbefaa1ad3bb51af9c962ae1240a7a6)

Author instructions

Thanks for submitting your paper to JOSS @JimWallace. Currently, there isn't a JOSS editor assigned to your paper.

@JimWallace if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Dec 17, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.14 s (935.2 files/s, 285391.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                            13              3              0          29946
Swift                          113           1717           3640           5318
XML                              4              0              0            328
Markdown                         2             27              0             91
TeX                              1              5              0             47
Bourne Shell                     1              6              9             27
YAML                             1              8              0             24
-------------------------------------------------------------------------------
SUM:                           135           1766           3649          35781
-------------------------------------------------------------------------------

Commit count by author:

   549	Jim Wallace
   137	Mingchung Xia
    34	JNordm
    32	a252jain
     7	Henry Tian
     4	nmathisfun
     1	AbhiJ2706
     1	Abhinav Jain
     1	Ali Raza Zaidi
     1	Jason Zhao
     1	Jean Nordmann
     1	JimWallace
     1	Nicole Mathis
     1	Ryan Lam

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 331

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- None

🟡 SKIP DOIs

- No DOI given, and none found for title: UMAP: Uniform Manifold Approximation and Projectio...
- No DOI given, and none found for title: Visualizing data using t-SNE.
- No DOI given, and none found for title: Model2Vec: The Fastest State-of-the-Art Static Emb...
- No DOI given, and none found for title: Similarity Topology
- No DOI given, and none found for title: SwiftFaiss

❌ MISSING DOIs

- 10.1007/978-3-642-37456-2_14 may be a valid DOI for title: Density-based clustering based on hierarchical den...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

ldaPrototype: A method in R to get a Prototype of multiple Latent Dirichlet Allocations
Submitting author: @JonasRieger
Handling editor: @karthik (Retired)
Reviewers: @tommyjones, @bstewart
Similarity score: 0.6749

corporaexplorer: An R package for dynamic exploration of text collections
Submitting author: @kgjerde
Handling editor: @leouieda (Retired)
Reviewers: @kbenoit, @trinker
Similarity score: 0.6681

rtweet: Collecting and analyzing Twitter data
Submitting author: @mkearney
Handling editor: @kthyng (Active)
Reviewers: @kthyng
Similarity score: 0.6603

textnets: A Python package for text analysis with networks
Submitting author: @jboynyc
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sara-02, @tresoldi
Similarity score: 0.6537

ADaPT-ML: A Data Programming Template for Machine Learning
Submitting author: @nulberry
Handling editor: @jmschrei (Active)
Reviewers: @aaronpeikert, @wincowgerDEV
Similarity score: 0.6530

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

@editorialbot invite @jbytecode as editor

👋 @jbytecode do you think you can take this one on as editor?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@jbytecode
Copy link

Hi @crvernon,

My latest experiences with Swift on Linux were terrible. I don't even know if every single package created on macOS can run and can be tested on other operating systems.

@JimWallace - Have you performed tests in Windows and Linux machines? If it is not so, it could be a hard constraint in finding suitable reviewers. This would also be a major obstacle to the widespread adoption of the software by the entire community.

The second thing is that the working with GitLab is the other constraint, one of the reviewers of my other submission was struggling with sending pull requests. But we can resolve this difficulty.

I'm now waiting a response from our author.

@JimWallace
Copy link

tldr; This is not intended to run on Windows or Linux.

Windows and Linux support is getting better in Swift, but it's not there yet IMO. Some of the code works cross-platform, and I had a linux CI/CD up and running for quite a while. It's not currently active because I shifted focus towards Apple-specific hardware. Cross-platform BLAS, etc. is not yet mature in Swift.

So, unfortunately, a lot of the code depends on MLX, which is M-series chip only. There are some really nice benefits from this in terms of edge computing, supporting most Apple laptops, but indeed I can see how this might make it harder to find reviewers. I would, however, argue that it's possibly a strength in terms of adoption, since this is providing somewhat unique functionality via the state-of-the-art (and also rapidly evolving) MLX framework.

I'm expecting to build a bunch of new features using MLX's LLM support next year, and was hoping that might be of interest to other folks.

I'd spoken with some co-authors about sending this over to GitHub, too. My institution provides some really nice gitlab support, so that hasn't been a priority.

@jbytecode
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @jbytecode is now the editor

@jbytecode
Copy link

@JimWallace - Okay, thank you for the clarification. We don't have an issue with platform independence now and we can move forward.

I'm the handling editor of this submission. First, we'll try to find suitable reviewers.

The editorialbot suggests us some similar publications. We can consider their authors. (Given in the post #7597 (comment)).

The other tool is the reviewer search, given in the link https://reviewers.joss.theoj.org/lookup. You can use this tool to filter some suitable reviewers.

In the first stage, whether using the suggestions and lists or not, I'm asking you to suggest suitable reviewers. If you provide their GitHub accounts, please don't use the @ character for avoiding unnecessary notifications. You can also suggest names so I can invite them with using their emails.

Do you have any suggestions for suitable reviewers?

@jbytecode
Copy link

@JimWallace - While we are searching suitable reviewers, could you please fix the missing DOI issue stated in the report: #7597 (comment)

@JimWallace
Copy link

Thanks,

rtweet corporaexplorer both look like similar projects, and I'd expect they'd be a good way to find reviewers. I'd point to either those authors, or the folks that reviewed those projects as suitable.

I believe that I've fixed the DOI issue.

@jbytecode
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1007/978-3-642-37456-2_14 is OK
- 10.48550/arXiv.1802.03426 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Visualizing data using t-SNE.
- No DOI given, and none found for title: Model2Vec: The Fastest State-of-the-Art Static Emb...
- No DOI given, and none found for title: Similarity Topology
- No DOI given, and none found for title: SwiftFaiss

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@jbytecode
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

ldaPrototype: A method in R to get a Prototype of multiple Latent Dirichlet Allocations
Submitting author: @JonasRieger
Handling editor: @karthik (Retired)
Reviewers: @tommyjones, @bstewart
Similarity score: 0.6813

corporaexplorer: An R package for dynamic exploration of text collections
Submitting author: @kgjerde
Handling editor: @leouieda (Retired)
Reviewers: @kbenoit, @trinker
Similarity score: 0.6765

rtweet: Collecting and analyzing Twitter data
Submitting author: @mkearney
Handling editor: @kthyng (Active)
Reviewers: @kthyng
Similarity score: 0.6665

textnets: A Python package for text analysis with networks
Submitting author: @jboynyc
Handling editor: @gkthiruvathukal (Active)
Reviewers: @sara-02, @tresoldi
Similarity score: 0.6603

ADaPT-ML: A Data Programming Template for Machine Learning
Submitting author: @nulberry
Handling editor: @jmschrei (Active)
Reviewers: @aaronpeikert, @wincowgerDEV
Similarity score: 0.6600

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@jbytecode
Copy link

👋👋👋 Dear @mkearney, @kgjerde 👋👋👋

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software.

The submission I'd like you to review is titled:

[PRE REVIEW]: Curio: Unsupervised Topic Modeling in Swift

You can find more information at the top of this Github issue (#7597).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Shell Swift TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

4 participants