Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: CNearest: A C++ toolkit to use the nearest-neighbour method of regularised stokeslets algorithm to solve viscous flow problems #7605

Open
editorialbot opened this issue Dec 19, 2024 · 6 comments
Assignees

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @ergoregion (Neil Butcher)
Repository: https://gitlab.com/djsmithbham/cnearest
Branch with paper.md (empty if default branch): JOSS-paper
Version: 0.0.1
Editor: @philipcardiff
Reviewers: @fabienevrard, @Pecnut
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2dedd709aa80938d14c38d8e9aabff79"><img src="https://joss.theoj.org/papers/2dedd709aa80938d14c38d8e9aabff79/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2dedd709aa80938d14c38d8e9aabff79/status.svg)](https://joss.theoj.org/papers/2dedd709aa80938d14c38d8e9aabff79)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fabienevrard & @Pecnut, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @philipcardiff know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@fabienevrard, please create your checklist typing: @editorialbot generate my checklist

@Pecnut, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.98  T=0.07 s (2351.2 files/s, 251449.8 lines/s)
------------------------------------------------------------------------------------
Language                          files          blank        comment           code
------------------------------------------------------------------------------------
XML                                  45             48              0           6075
C++                                  51           1413            269           4654
C                                     2            295            122           1329
YAML                                  3            140              9           1103
C/C++ Header                         32            184            375            623
CMake                                18            120             38            502
Visual Studio Solution                4              4              4            394
Markdown                             12            212              0            350
TeX                                   1             28              0            255
JSON                                  2              0              0            118
Tcl/Tk                                1             22             32             52
Text                                  4              0              0             31
Dockerfile                            1              8              1             12
------------------------------------------------------------------------------------
SUM:                                176           2474            850          15498
------------------------------------------------------------------------------------

Commit count by author:

   107	[email protected]
    54	Neil Butcher
    35	djsmithbham
     3	James Tyrrell (Advanced Research Computing)
     1	James Tyrrell

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1493

✅ The paper includes a Statement of need section

@editorialbot editorialbot added the C label Dec 19, 2024
@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.jcp.2008.01.032 is OK
- 10.1137/S106482750038146X is OK
- 10.1063/1.1830486 is OK
- 10.1016/j.jcp.2015.01.019 is OK
- 10.1016/j.jcp.2018.08.055 is OK
- 10.1103/PhysRevFluids.3.053101 is OK
- 10.1137/18M1191816 is OK
- 10.1098/rsta.2019.0528 is OK
- 10.1098/rsos.210108 is OK
- 10.1103/PhysRevFluids.4.113101 is OK
- 10.1140/epje/i2015-15139-7 is OK
- 10.1103/PhysRevFluids.5.073101 is OK
- 10.1017/CBO9780511624124 is OK
- 10.1017/S0022112004008201 is OK
- 10.1016/j.jfluidstructs.2016.07.006 is OK
- 10.1098/rspa.2009.0295 is OK
- 10.1016/j.jcp.2017.12.008 is OK
- 10.1098/rspa.2009.0295 is OK
- 10.1103/PhysRevFluids.4.063102 is OK
- 10.1002/bip.1981.360200205 is OK
- 10.1103/PhysRevFluids.4.084104 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: 20 years of Regularized Stokeslets: Applications, ...
- No DOI given, and none found for title: Eigen v3
- No DOI given, and none found for title: NEAREST

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants