Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Python wrapper of "setOutputsForces" and "getOutputsForces" #60

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Fix the Python wrapper of "setOutputsForces" and "getOutputsForces" #60

merged 3 commits into from
Jan 21, 2022

Conversation

raimis
Copy link
Contributor

@raimis raimis commented Jan 21, 2022 •
edited
Loading

  • Fix the wrapper
  • Add a test

Fixes #58

@raimis raimis self-assigned this Jan 21, 2022
@peastman
Copy link
Member

Looks good. Sorry for omitting this in the original PR!

Raimondas Galvelis added 2 commits January 21, 2022 23:03
@raimis raimis marked this pull request as ready for review January 21, 2022 22:21
@raimis raimis requested a review from peastman January 21, 2022 22:21
@raimis
Copy link
Contributor Author

raimis commented Jan 21, 2022

@peastman this done! Could you review?

@raimis raimis mentioned this pull request Jan 21, 2022
Closed
peastman
peastman approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@peastman peastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raimis raimis merged commit 13e8715 into openmm:master Jan 21, 2022
@raimis raimis mentioned this pull request Mar 1, 2022
Closed
@dmighty007 dmighty007 mentioned this pull request Feb 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peastman peastman peastman approved these changes

Assignees

@raimis raimis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The method “setOutputsForces” cannot be used in Python
2 participants
@raimis @peastman