Ovms windows3 (#2747)

* Windows enabling

Author: rasapala

.bazelrc

@@ -51,6 +51,10 @@ build --define=MEDIAPIPE_DISABLE_GPU=1
 
 build --define=MEDIAPIPE_DISABLE=0
 
+build --define=CLOUD_DISABLE=0
+coverage --define=CLOUD_DISABLE=0
+test --define=CLOUD_DISABLE=0
+
 build --define=PYTHON_DISABLE=0
 
 # sometimes failed logs exceed this threshold
@@ -66,26 +70,38 @@ build --copt=-DGRPC_BAZEL_BUILD
 build --copt=-O2
 
 # LLVM, MLIR and TF require C++14, we use C++17 in project
-build --cxxopt=-std=c++17
-build --host_cxxopt=-std=c++17
+build:linux --cxxopt=-std=c++17
+build:linux --host_cxxopt=-std=c++17
+
+build:windows --host_cxxopt=/std:c++17
+build:windows --cxxopt=/std:c++17
+build:windows --action_env BAZEL_CXXOPTS="/std:c++17"
+
+# Fixing compiler errors:
+#build:windows --cxxopt=/translateInclude=no
+build:windows --enable_platform_specific_config
 
 # Security options
-build --cxxopt=-fno-strict-overflow
-build --cxxopt=-fno-delete-null-pointer-checks
-build --cxxopt=-fwrapv
-build --cxxopt=-fstack-protector
-build --cxxopt=-fstack-clash-protection
-build --cxxopt=-Wformat
-build --cxxopt=-Wformat-security
-build --cxxopt=-Werror=format-security
+# TODO: Add equivalent windows flag
+build:linux --cxxopt=-fno-strict-overflow
+build:linux --cxxopt=-fno-delete-null-pointer-checks
+build:linux --cxxopt=-fwrapv
+build:linux --cxxopt=-fstack-protector
+build:linux --cxxopt=-fstack-clash-protection
+build:linux --cxxopt=-Wformat
+build:linux --cxxopt=-Wformat-security
+build:linux --cxxopt=-Werror=format-security
 
 # Adding "--cxxopt=-D_GLIBCXX_USE_CXX11_ABI=0" creates parity with TF
 # compilation options. It also addresses memory use due to
 # copy-on-write semantics of std::strings of the older ABI.
 build --cxxopt=-D_GLIBCXX_USE_CXX11_ABI=1
 
+# TODO Windows: may impact python nodes execution
+build:windows --noenable_bzlmod
 build --experimental_repo_remote_exec
-build --force_pic
+# TODO: Add equivalent windows flag
+build:linux --force_pic
 build --experimental_cc_shared_library
 
 build --check_visibility=true
@@ -96,4 +112,147 @@ build --cxxopt=-DOVMS_DUMP_TO_FILE=0
 # envs below are required to succesfully run binaries in bazel as bazel is
 # very strict in sandboxing
 test --test_env PYTHONPATH=/opt/intel/openvino/python:/ovms/bazel-bin/src/python/binding
+
+# TF bazelrc settings
+# TensorFlow Bazel configuration file.
+
+build:windows --define framework_shared_object=true
+build:windows --define tsl_protobuf_header_only=true
+
+build:windows --define=use_fast_cpp_protos=true
+build:windows --define=allow_oversize_protos=true
+
+build:windows --spawn_strategy=standalone
+build:windows -c opt
+
+# Make Bazel print out all options from rc files.
+build:windows --announce_rc
+
+# TODO(mihaimaruseac): Document this option or remove if no longer needed
+build:windows --define=grpc_no_ares=true
+
+
+build:windows --noincompatible_remove_legacy_whole_archive
+build:windows --features=-force_no_whole_archive
+
+# TODO(mihaimaruseac): Document this option or remove if no longer needed
+build:windows --enable_platform_specific_config
+
+# Enable XLA support by default.
+build:windows --define=with_xla_support=true
+
+# TODO(mihaimaruseac): Document this option or remove if no longer needed
+build:windows --config=short_logs
+
+# TODO(mihaimaruseac): Document this option or remove if no longer needed
+build:windows --config=v2
+
+# Disable AWS/HDFS support by default
+build:windows --define=no_aws_support=true
+build:windows --define=no_hdfs_support=true
+
+# cc_shared_library ensures no library is linked statically more than once.
+build:windows --experimental_link_static_libraries_once=false
+
+# Prevent regressions on those two incompatible changes
+# TODO: remove those flags when they are flipped in the default Bazel version TF uses.
+build:windows --incompatible_enforce_config_setting_visibility
+
+# Config to use a mostly-static build and disable modular op registration
+# support (this will revert to loading TensorFlow with RTLD_GLOBAL in Python).
+# By default, TensorFlow will build with a dependence on
+# //tensorflow:libtensorflow_framework.so.
+build:monolithic --define framework_shared_object=false
+build:monolithic --define tsl_protobuf_header_only=false
+build:monolithic --experimental_link_static_libraries_once=false  # b/229868128
+
+build:windows --copt=/W0
+build:windows --host_copt=/W0
+
+# On Windows, `__cplusplus` is wrongly defined without this switch
+# See https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/
+build:windows --copt=/Zc:__cplusplus
+build:windows --host_copt=/Zc:__cplusplus
+
+# Tensorflow uses M_* math constants that only get defined by MSVC headers if
+# _USE_MATH_DEFINES is defined.
+build:windows --copt=/D_USE_MATH_DEFINES
+build:windows --host_copt=/D_USE_MATH_DEFINES
+
+# Windows has a relatively short command line limit, which TF has begun to hit.
+# See https://docs.bazel.build/versions/main/windows.html
+build:windows --features=compiler_param_file
+build:windows --features=archive_param_file
+
+# Speed Windows compile times. Available in VS 16.4 (we are on 16.11). See
+# https://groups.google.com/a/tensorflow.org/d/topic/build/SsW98Eo7l3o/discussion
+build:windows --copt=/d2ReducedOptimizeHugeFunctions
+build:windows --host_copt=/d2ReducedOptimizeHugeFunctions
+
+build:windows --cxxopt=/std:c++17
+build:windows --host_cxxopt=/std:c++17
+
+# On windows, we still link everything into a single DLL.
+build:windows --config=monolithic
+
+# Make sure to include as little of windows.h as possible
+build:windows --copt=-DWIN32_LEAN_AND_MEAN
+build:windows --host_copt=-DWIN32_LEAN_AND_MEAN
+build:windows --copt=-DNOGDI
+build:windows --host_copt=-DNOGDI
+
+# MSVC (Windows): Standards-conformant preprocessor mode
+# See https://docs.microsoft.com/en-us/cpp/preprocessor/preprocessor-experimental-overview
+build:windows --copt=/Zc:preprocessor
+build:windows --host_copt=/Zc:preprocessor
+
+# Misc build options we need for windows.
+build:windows --linkopt=/DEBUG
+build:windows --host_linkopt=/DEBUG
+build:windows --linkopt=/OPT:REF
+build:windows --host_linkopt=/OPT:REF
+build:windows --linkopt=/OPT:ICF
+build:windows --host_linkopt=/OPT:ICF
+
+# Verbose failure logs when something goes wrong
+build:windows --verbose_failures
+
+# Work around potential issues with large command lines on windows.
+# See: https://github.com/bazelbuild/bazel/issues/5163
+build:windows --features=compiler_param_file
+
+# Configure short or long logs
+build:short_logs --output_filter=DONT_MATCH_ANYTHING
+build:verbose_logs --output_filter=
+
+build:avx_win --copt=/arch=AVX
+build:avx2_win --copt=/arch=AVX2
+
+# Options to build TensorFlow 1.x or 2.x.
+build:v1 --define=tf_api_version=1 --action_env=TF2_BEHAVIOR=0
+build:v2 --define=tf_api_version=2 --action_env=TF2_BEHAVIOR=1
+
+# Flag to enable remote config
+build:windows --experimental_repo_remote_exec
+
+# Config-specific options should come above this line.
+
+# Load rc file written by ./configure.
+# try-import %workspace%/.tf_configure.bazelrc
+build:windows --action_env PYTHON_BIN_PATH="C:/opt/Python39/python.exe"
+build:windows --action_env PYTHON_LIB_PATH="C:/opt/Python39/lib/site-packages"
+build:windows --python_path="C:/opt/Python39/python.exe"
+build:windows:opt --copt=/arch:AVX
+build:windows:opt --host_copt=/arch:AVX
+build:windows --define=override_eigen_strong_inline=true
+
+# Load rc file with user-specific options.
+try-import %workspace%/.bazelrc.user
+
+# Disable TFRT integration for now unless --config=tfrt is specified.
+build:windows --deleted_packages=tensorflow/core/tfrt/stubs,tensorflow/compiler/mlir/tfrt,tensorflow/compiler/mlir/tfrt/benchmarks,tensorflow/compiler/mlir/tfrt/ir,tensorflow/compiler/mlir/tfrt/ir/mlrt,tensorflow/compiler/mlir/tfrt/jit/python_binding,tensorflow/compiler/mlir/tfrt/jit/transforms,tensorflow/compiler/mlir/tfrt/python_tests,tensorflow/compiler/mlir/tfrt/tests,tensorflow/compiler/mlir/tfrt/tests/mlrt,tensorflow/compiler/mlir/tfrt/tests/ir,tensorflow/compiler/mlir/tfrt/tests/analysis,tensorflow/compiler/mlir/tfrt/tests/jit,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_tfrt,tensorflow/compiler/mlir/tfrt/tests/lhlo_to_jitrt,tensorflow/compiler/mlir/tfrt/tests/tf_to_corert,tensorflow/compiler/mlir/tfrt/tests/tf_to_tfrt_data,tensorflow/compiler/mlir/tfrt/tests/saved_model,tensorflow/compiler/mlir/tfrt/transforms/lhlo_gpu_to_tfrt_gpu,tensorflow/compiler/mlir/tfrt/transforms/mlrt,tensorflow/core/runtime_fallback,tensorflow/core/runtime_fallback/conversion,tensorflow/core/runtime_fallback/kernel,tensorflow/core/runtime_fallback/opdefs,tensorflow/core/runtime_fallback/runtime,tensorflow/core/runtime_fallback/util,tensorflow/core/tfrt/mlrt,tensorflow/core/tfrt/mlrt/attribute,tensorflow/core/tfrt/mlrt/kernel,tensorflow/core/tfrt/mlrt/bytecode,tensorflow/core/tfrt/mlrt/interpreter,tensorflow/compiler/mlir/tfrt/translate/mlrt,tensorflow/compiler/mlir/tfrt/translate/mlrt/testdata,tensorflow/core/tfrt/gpu,tensorflow/core/tfrt/run_handler_thread_pool,tensorflow/core/tfrt/runtime,tensorflow/core/tfrt/saved_model,tensorflow/core/tfrt/graph_executor,tensorflow/core/tfrt/saved_model/tests,tensorflow/core/tfrt/tpu,tensorflow/core/tfrt/utils,tensorflow/core/tfrt/utils/debug,tensorflow/core/tfrt/saved_model/python,tensorflow/core/tfrt/graph_executor/python
+
+# Windows build ssl headers for GRPC workaround
+build:windows --override_repository="boringssl=C:\\opt\\boringSSL-SwiftPM"
+
 test --test_env LD_LIBRARY_PATH=/opt/opencv/lib/:/opt/intel/openvino/runtime/lib/intel64/:/opt/intel/openvino/runtime/3rdparty/tbb/lib/

.gitignore

@@ -26,4 +26,8 @@ cppclean_test
 tags
 .venv-style/
 src/test/llm_testing
+node_modules/
+yarn.*
+bazel-openvino-model-server/
+bazel-model_server/
 out

BUILD.bazel

@@ -24,11 +24,11 @@ exports_files([
 load("@bazel_skylib//lib:selects.bzl", "selects")
 load("@mediapipe//mediapipe/framework:more_selects.bzl", "more_selects")
 load("//:common_settings.bzl",
-     "COMMON_STATIC_LIBS_COPTS", "COMMON_STATIC_LIBS_LINKOPTS", "COMMON_FUZZER_COPTS", "COMMON_FUZZER_LINKOPTS", "COMMON_LOCAL_DEFINES",
+     "COMMON_STATIC_LIBS_COPTS_VISIBLE", "COMMON_STATIC_LIBS_COPTS", "COMMON_STATIC_LIBS_LINKOPTS", "COMMON_FUZZER_COPTS", "COMMON_FUZZER_LINKOPTS", "COMMON_LOCAL_DEFINES",
      "create_config_settings")
 create_config_settings()
 
-#To build without python use flags - bazel build --define PYTHON_DISABLE=1 --cxxopt=-DPYTHON_DISABLE=1 //src:ovms
+#To build without python use flags - bazel build --config=linux --define PYTHON_DISABLE=1 --cxxopt=-DPYTHON_DISABLE=1 //src:ovms
 
 cc_library(
   name = "ovms_dependencies",
@@ -41,20 +41,23 @@ cc_library(
         "@org_tensorflow//tensorflow/core:framework",
         "@com_github_gabime_spdlog//:spdlog",
         "@com_github_jarro2783_cxxopts//:cxxopts",
-        "@aws-sdk-cpp//:aws-sdk-cpp",
-        "@aws-sdk-cpp//:aws-sdk-cpp_cmake",
-        "@azure//:storage",
-        "@cpprest//:sdk",
-        "@boost//:lib",
-        "@com_github_googleapis_google_cloud_cpp//google/cloud/storage:storage_client",
-        "@tensorflow_serving//tensorflow_serving/util/net_http/server/public:http_server",
         "@tensorflow_serving//tensorflow_serving/util/net_http/server/public:http_server_api",
         "@tensorflow_serving//tensorflow_serving/util:threadpool_executor",
         "@tensorflow_serving//tensorflow_serving/util:json_tensor",
-        "@linux_openvino//:openvino",
-        "@linux_opencv//:opencv",
+        "//third_party:openvino",
+        "//third_party:opencv",
         "@com_github_jupp0r_prometheus_cpp//core",
         ] + select({
+            "//:not_disable_cloud": [
+                "@aws-sdk-cpp//:aws-sdk-cpp",
+                "@aws-sdk-cpp//:aws-sdk-cpp_cmake",
+                "@azure//:storage",
+                "@cpprest//:sdk",
+                "//third_party:boost",
+                "@com_github_googleapis_google_cloud_cpp//google/cloud/storage:storage_client",],
+            "//:disable_cloud": []
+            })
+         + select({
             "//:not_disable_mediapipe": [
                 "@mediapipe//mediapipe/framework:calculator_framework",
                 "@mediapipe//mediapipe/framework/stream_handler:barrier_input_stream_handler",
@@ -78,6 +81,12 @@ cc_library(
                 "@pybind11//:pybind11_embed",
                 ],
             "//:disable_python": []
+            })
+        + select({
+                "//conditions:default": [
+                    "@tensorflow_serving//tensorflow_serving/util/net_http/server/public:http_server",
+                ],
+                "//src:windows" : [],
             }),
   visibility = ["//visibility:public"],
 )

Dockerfile.redhat

@@ -175,7 +175,7 @@ ARG ov_use_binary=0
 ARG DLDT_PACKAGE_URL
 ARG TEMP_DIR=/tmp/openvino_installer
 ARG CMAKE_BUILD_TYPE=Release
-ARG debug_bazel_flags="--strip=always --define MEDIAPIPE_DISABLE=0 --define PYTHON_DISABLE=0 --//:distro=redhat"
+ARG debug_bazel_flags="--config=linux --strip=always --define MEDIAPIPE_DISABLE=0 --define PYTHON_DISABLE=0 --//:distro=redhat"
 
 # hadolint ignore=DL3003
 RUN if [[ "$NVIDIA" == "1" ]] ; then true ; else exit 0 ; fi ; git clone https://github.com/$ov_contrib_org/openvino_contrib.git /openvino_contrib && cd /openvino_contrib && git checkout $ov_contrib_branch && git submodule update --init --recursive
@@ -352,7 +352,7 @@ RUN rm -Rf /etc/entitlement /etc/rhsm/ca
 
 FROM $BUILD_IMAGE as capi-build
 # C api shared library
-ARG CAPI_FLAGS="--strip=always --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1 --//:distro=redhat"
+ARG CAPI_FLAGS="--config=linux --strip=always --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1 --//:distro=redhat"
 ARG JOBS=40
 RUN bazel build --jobs $JOBS ${CAPI_FLAGS} //src:ovms_shared
 

Dockerfile.ubuntu

@@ -95,7 +95,7 @@ ARG BASE_IMAGE
 ENV DEBIAN_FRONTEND=noninteractive
 SHELL ["/bin/bash", "-xo", "pipefail", "-c"]
 
-ARG debug_bazel_flags="--strip=always --define MEDIAPIPE_DISABLE=0 --define PYTHON_DISABLE=0 --//:distro=ubuntu"
+ARG debug_bazel_flags="--config=linux --strip=always --define MEDIAPIPE_DISABLE=0 --define PYTHON_DISABLE=0 --//:distro=ubuntu"
 
 RUN apt-get update && apt-get install --no-install-recommends -y \
             libgflags-dev \
@@ -356,7 +356,7 @@ FROM $BUILD_IMAGE as capi-build
 SHELL ["/bin/bash", "-xo", "pipefail", "-c"]
 # C api shared library
 # hadolint ignore=DL3059
-ARG CAPI_FLAGS="--strip=always --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1 --//:distro=ubuntu"
+ARG CAPI_FLAGS="--config=linux --strip=always --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1 --//:distro=ubuntu"
 ARG JOBS=40
 ARG FUZZER_BUILD=0
 RUN bazel build --jobs=$JOBS ${CAPI_FLAGS} //src:ovms_shared

Makefile

@@ -135,8 +135,8 @@ else ifeq ($(findstring redhat,$(BASE_OS)),redhat)
 else
   $(error BASE_OS must be either ubuntu or redhat)
 endif
-CAPI_FLAGS = "--strip=$(STRIP)"$(BAZEL_DEBUG_BUILD_FLAGS)" --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1"$(OV_TRACING_PARAMS)$(TARGET_DISTRO_PARAMS)
-BAZEL_DEBUG_FLAGS="--strip=$(STRIP)"$(BAZEL_DEBUG_BUILD_FLAGS)$(DISABLE_MEDIAPIPE_PARAMS)$(DISABLE_PYTHON_PARAMS)$(FUZZER_BUILD_PARAMS)$(OV_TRACING_PARAMS)$(TARGET_DISTRO_PARAMS)
+CAPI_FLAGS = "--config=linux --strip=$(STRIP)"$(BAZEL_DEBUG_BUILD_FLAGS)" --define MEDIAPIPE_DISABLE=1 --define PYTHON_DISABLE=1"$(OV_TRACING_PARAMS)$(TARGET_DISTRO_PARAMS)
+BAZEL_DEBUG_FLAGS="--config=linux --strip=$(STRIP)"$(BAZEL_DEBUG_BUILD_FLAGS)$(DISABLE_MEDIAPIPE_PARAMS)$(DISABLE_PYTHON_PARAMS)$(FUZZER_BUILD_PARAMS)$(OV_TRACING_PARAMS)$(TARGET_DISTRO_PARAMS)
 
 # Option to Override release image.
 # Release image OS *must have* glibc version >= glibc version on BASE_OS: