Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lints to guest programs #1125

Closed
jonathanpwang opened this issue Dec 23, 2024 · 0 comments · Fixed by #1131
Closed

Add lints to guest programs #1125

jonathanpwang opened this issue Dec 23, 2024 · 0 comments · Fixed by #1131
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jonathanpwang
Copy link
Contributor

The crates for guest programs used in benchmarks and integration tests are not part of the Cargo workspace, which is intentional since the guest programs are designed to target RISC-V. These guest programs are usually in a **/benchmarks/programs or **/test/programs folders.

We should add a lint workflow step to run cargo fmt and cargo clippy on these crates, making sure to lint for all targets.

@jonathanpwang jonathanpwang added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 23, 2024
@linear linear bot removed good first issue Good for newcomers help wanted Extra attention is needed labels Dec 23, 2024
@jonathanpwang jonathanpwang added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant