Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: stop hardcoding /usr/bin/gcc #75

Open
thesamesam opened this issue Aug 18, 2024 · 11 comments
Open

test: stop hardcoding /usr/bin/gcc #75

thesamesam opened this issue Aug 18, 2024 · 11 comments

Comments

@thesamesam
Copy link

Many tests have lines like test/unittest/usdt/tst.guess32.sh:14:CC=/usr/bin/gcc. They should respect CC from the environment to allow testing with different GCC versions.

e.g. On my system, /usr/bin/gcc is usually GCC trunk, but I might want to compare GCC 14 with that to check for regressions.

@thesamesam
Copy link
Author

The same is true for objdump and all such toolchain tools.

@kvanhees
Copy link
Member

+1

@nickalcock
Copy link
Member

Totally agreed. This was a short-term kludge of mine in 2011 -- it's long past time for it to get fixed properly. A nice boring job given how pervasive this is :)

@thesamesam
Copy link
Author

I don't mind taking it. I already have a stack of other test fixes it might conflict with, even.

@ezannoni
Copy link
Member

Do we have a patch for this?

@thesamesam
Copy link
Author

No, I'm happy to do it, but I was hoping to have my test fixes in first (already sent). I can prepare the patches now but I was worried about conflicts.

@kvanhees
Copy link
Member

I am looking at the patches already submitted to pull them in.

thesamesam added a commit to thesamesam/dtrace-utils that referenced this issue Oct 12, 2024
thesamesam added a commit to thesamesam/dtrace-utils that referenced this issue Oct 12, 2024
@nickalcock
Copy link
Member

I'm afraid that's almost certain to clash like mad with c80d7eb which I'm getting reviewed now :(

@nickalcock
Copy link
Member

That's in, so the clash has happened and things have settled down again.

@thesamesam
Copy link
Author

Thanks Nick. I'll rebase and test it, then send it soon.

@ezannoni
Copy link
Member

Sam, did you get a chance to do the rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants