|
1 |
| -# Contributing to OLCUT |
| 1 | +# Contributing to this repository |
2 | 2 |
|
3 |
| -We welcome your contributions! There are several directions that OLCUT could |
4 |
| -be extended in. New config file formats could be added, more classes can be |
5 |
| -added for the `@Config` annotation, more classes can be supported by the |
6 |
| -`CommandInterpreter`'s `@Command` methods. Have an idea? Talk to us and |
7 |
| -let's make it happen. Just file an Issue to get in touch. |
| 3 | +We welcome your contributions! There are multiple ways to contribute. |
8 | 4 |
|
9 |
| -## Questions, Bugs, and Features |
| 5 | +## Opening issues |
10 | 6 |
|
11 |
| -If you hit a bug or have an enhancement request please file a [GitHub issue](https://github.com/oracle/olcut/issues). |
12 |
| -This is also a great way to ask us questions. When filing a bug remember that |
13 |
| -the better written the bug is, the more likely it is to be fixed. Please include: |
| 7 | +For bugs or enhancement requests, please file a GitHub issue unless it's |
| 8 | +security related. When filing a bug remember that the better written the bug is, |
| 9 | +the more likely it is to be fixed. If you think you've found a security |
| 10 | +vulnerability, do not raise a GitHub issue and follow the instructions in our |
| 11 | +[security policy](./SECURITY.md). |
14 | 12 |
|
15 |
| -1. Version of OLCUT |
16 |
| -1. OS |
17 |
| -1. Java version |
18 |
| -1. As much code as you can provide to reproduce the bug |
19 |
| -1. Any relevant configuration file snippets |
20 |
| -1. Steps to reproduce |
| 13 | +## Contributing code |
21 | 14 |
|
22 |
| -## Code |
| 15 | +We welcome your code contributions. Before submitting code via a pull request, |
| 16 | +you will need to have signed the [Oracle Contributor Agreement][OCA] (OCA) and |
| 17 | +your commits need to include the following line using the name and e-mail |
| 18 | +address you used to sign the OCA: |
23 | 19 |
|
24 |
| -We welcome code contributions, but we need the contributor to sign the |
25 |
| -[Oracle Contributor Agreement (OCA)](https://www.oracle.com/technetwork/community/oca-486395.html) |
26 |
| -first. |
| 20 | +```text |
| 21 | +Signed-off-by: Your Name <[email protected]> |
| 22 | +``` |
27 | 23 |
|
28 |
| -The process: |
| 24 | +This can be automatically added to pull requests by committing with `--sign-off` |
| 25 | +or `-s`, e.g. |
29 | 26 |
|
30 |
| -1. We encourage you to file an [issue](https://github.com/oracle/olcut/issues) to discuss your idea with us before implementing anything. |
31 |
| -1. Sign the [OCA](https://www.oracle.com/technetwork/community/oca-486395.html) |
32 |
| -1. Fork the repository and work your magic |
33 |
| -1. Create a Pull Request |
34 |
| -1. We will review your PR and merge as appropriate. |
| 27 | +```text |
| 28 | +git commit --signoff |
| 29 | +``` |
35 | 30 |
|
36 |
| -## Code of Conduct |
| 31 | +Only pull requests from committers that can be verified as having signed the OCA |
| 32 | +can be accepted. |
| 33 | + |
| 34 | +## Pull request process |
| 35 | + |
| 36 | +1. Ensure there is an issue created to track and discuss the fix or enhancement |
| 37 | + you intend to submit. |
| 38 | +1. Fork this repository. |
| 39 | +1. Create a branch in your fork to implement the changes. We recommend using |
| 40 | + the issue number as part of your branch name, e.g. `1234-fixes`. |
| 41 | +1. Ensure that any documentation is updated with the changes that are required |
| 42 | + by your change. |
| 43 | +1. Ensure that any samples are updated if the base image has been changed. |
| 44 | +1. Submit the pull request. *Do not leave the pull request blank*. Explain exactly |
| 45 | + what your changes are meant to do and provide simple steps on how to validate. |
| 46 | + your changes. Ensure that you reference the issue you created as well. |
| 47 | +1. We will assign the pull request to 2-3 people for review before it is merged. |
| 48 | + |
| 49 | +## Code of conduct |
| 50 | + |
| 51 | +Follow the [Golden Rule](https://en.wikipedia.org/wiki/Golden_Rule). If you'd |
| 52 | +like more specific guidelines, see the [Contributor Covenant Code of Conduct][COC]. |
| 53 | + |
| 54 | +[OCA]: https://oca.opensource.oracle.com |
| 55 | +[COC]: https://www.contributor-covenant.org/version/1/4/code-of-conduct/ |
37 | 56 |
|
38 |
| -Follow the [Golden Rule](https://en.wikipedia.org/wiki/Golden_Rule). If |
39 |
| -you'd like more specific guidelines see the |
40 |
| -[Contributor Covenant Code of Conduct](https://www.contributor-covenant.org/version/1/4/code-of-conduct.html) |
|
0 commit comments