Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating DialogPrimitive.Close flickering #144

Open
trevorpfiz opened this issue Dec 13, 2024 · 4 comments
Open

Rating DialogPrimitive.Close flickering #144

trevorpfiz opened this issue Dec 13, 2024 · 4 comments

Comments

@trevorpfiz
Copy link

I am noticing the DialogPrimitive.Close flickering when trying out the Rating example and when trying to build my own. I have noticed that adding a DialogFooter with styles sometimes fixes it? A weird bug.

https://www.loom.com/share/34ca439cf00947a48bebbb8d9ef8708f?sid=7cb8ce3d-624d-4f20-bcb8-f6518f85bc10

@pasqualevitiello
Copy link
Contributor

Hey @trevorpfiz can you please provide more information (eg, OS, browser, etc)? Also, does that happens with all dialog components?

@trevorpfiz
Copy link
Author

Hey @trevorpfiz can you please provide more information (eg, OS, browser, etc)? Also, does that happens with all dialog components?

macOS Sequoia 15.1.1. Using Chrome. I also see it in Arc. The bug doesn't seem to be there on Safari.

It is only the Rating dialog for some reason.

@pasqualevitiello
Copy link
Contributor

Pretty weird, same OS here (Chrome 131.0.6778.110) but I cannot reproduce the issue: https://jumpshare.com/v/O0FpJIysOUIRyMv3lGO7

@pasqualevitiello
Copy link
Contributor

pasqualevitiello commented Dec 30, 2024

Now I can see it (currently checking on Chrome 131.0.6778.205), but in a different component:

Screenshot 2024-12-30 at 13 37 47

If I remove margin top from the "+ Add another" or change the font size of that text, the close icon doesn't flicker anymore. Honestly, that does not make any sense to me. I think it's some weird issue with Chrome, since it seems to be working with other browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants