[Function Attribute] add target-cpu and target-features sets if they're non-null.

All llvm::Functions created during IRGen will have target-cpu and target-features
attributes if they are non-null.

Update testing cases to expect the attribute in function definition.
Add testing case function-target-features.swift to verify target-cpu and
target-features.

rdar://20772331


Swift SVN r28186

Author: Manman Ren

lib/IRGen/GenCast.cpp

@@ -316,6 +316,7 @@ static llvm::Function *emitExistentialScalarCastFn(IRGenModule &IGM,
   auto fnTy = llvm::FunctionType::get(returnTy, argTys, /*vararg*/ false);
   auto fn = llvm::Function::Create(fnTy, llvm::GlobalValue::PrivateLinkage,
                                    llvm::Twine(name), IGM.getModule());
+  fn->setAttributes(IGM.constructInitialAttributes());
 
   auto IGF = IRGenFunction(IGM, fn);
   Explosion args = IGF.collectParameters();

lib/IRGen/GenDecl.cpp

@@ -550,6 +550,7 @@ void IRGenModule::emitRuntimeRegistration() {
                                            llvm::GlobalValue::PrivateLinkage,
                                            "runtime_registration",
                                            getModule());
+  RegistrationFunction->setAttributes(constructInitialAttributes());
 
   // Insert a call into the entry function.
   {
@@ -827,6 +828,7 @@ void IRGenModule::emitVTableStubs() {
       stub = llvm::Function::Create(llvm::FunctionType::get(VoidTy, false),
                                     llvm::GlobalValue::LinkOnceODRLinkage,
                                     "_swift_dead_method_stub");
+      stub->setAttributes(constructInitialAttributes());
       Module.getFunctionList().push_back(stub);
       stub->setVisibility(llvm::GlobalValue::HiddenVisibility);
       stub->setCallingConv(RuntimeCC);
@@ -905,6 +907,7 @@ void IRGenModule::emitTypeVerifier() {
                                              llvm::GlobalValue::PrivateLinkage,
                                              "type_verifier",
                                              getModule());
+  VerifierFunction->setAttributes(constructInitialAttributes());
 
   // Insert a call into the entry function.
   {
@@ -1160,8 +1163,13 @@ llvm::Function *LinkInfo::createFunction(IRGenModule &IGM,
   }
   fn->setVisibility(getVisibility());
   fn->setCallingConv(cc);
-  if (!attrs.isEmpty())
-    fn->setAttributes(attrs);
+
+  auto initialAttrs = IGM.constructInitialAttributes();
+  // Merge initialAttrs with attrs.
+  auto updatedAttrs = attrs.addAttributes(IGM.getLLVMContext(),
+                        llvm::AttributeSet::FunctionIndex, initialAttrs);
+  if (!updatedAttrs.isEmpty())
+    fn->setAttributes(updatedAttrs);
 
   // Everything externally visible is considered used in Swift.
   // That mostly means we need to be good at not marking things external.

lib/IRGen/GenFunc.cpp

@@ -3194,7 +3194,12 @@ static llvm::Function *emitPartialApplicationForwarder(IRGenModule &IGM,
   llvm::Function *fwd =
     llvm::Function::Create(fwdTy, llvm::Function::InternalLinkage,
                            llvm::StringRef(thunkName), &IGM.Module);
-  fwd->setAttributes(outAttrs);
+
+  auto initialAttrs = IGM.constructInitialAttributes();
+  // Merge initialAttrs with outAttrs.
+  auto updatedAttrs = outAttrs.addAttributes(IGM.getLLVMContext(),
+                        llvm::AttributeSet::FunctionIndex, initialAttrs);
+  fwd->setAttributes(updatedAttrs);
 
   IRGenFunction subIGF(IGM, fwd);
   if (IGM.DebugInfo)
@@ -3697,6 +3702,7 @@ static llvm::Function *emitBlockCopyHelper(IRGenModule &IGM,
   auto func = llvm::Function::Create(copyTy, llvm::GlobalValue::InternalLinkage,
                                      "block_copy_helper",
                                      IGM.getModule());
+  func->setAttributes(IGM.constructInitialAttributes());
   IRGenFunction IGF(IGM, func);
 
   // Copy the captures from the source to the destination.
@@ -3731,6 +3737,7 @@ static llvm::Function *emitBlockDisposeHelper(IRGenModule &IGM,
                                      llvm::GlobalValue::InternalLinkage,
                                      "block_destroy_helper",
                                      IGM.getModule());
+  func->setAttributes(IGM.constructInitialAttributes());
   IRGenFunction IGF(IGM, func);
 
   // Destroy the captures.

lib/IRGen/GenHeap.cpp

@@ -177,6 +177,7 @@ static llvm::Function *createDtorFn(IRGenModule &IGM,
     llvm::Function::Create(IGM.DeallocatingDtorTy,
                            llvm::Function::PrivateLinkage,
                            "objectdestroy", &IGM.Module);
+  fn->setAttributes(IGM.constructInitialAttributes());
 
   IRGenFunction IGF(IGM, fn);
   if (IGM.DebugInfo)
@@ -220,6 +221,7 @@ llvm::Constant *HeapLayout::createSizeFn(IRGenModule &IGM) const {
     llvm::Function::Create(IGM.DeallocatingDtorTy,
                            llvm::Function::PrivateLinkage,
                            "objectsize", &IGM.Module);
+  fn->setAttributes(IGM.constructInitialAttributes());
 
   IRGenFunction IGF(IGM, fn);
   if (IGM.DebugInfo)

lib/IRGen/GenMeta.cpp

@@ -1788,6 +1788,7 @@ namespace {
                                      llvm::Twine("get_field_types_")
                                        + type->getName().str(),
                                      IGM.getModule());
+    fn->setAttributes(IGM.constructInitialAttributes());
 
     // Emit the body of the field type accessor later. We need to access
     // the type metadata for the fields, which could lead to infinite recursion
@@ -2279,6 +2280,7 @@ namespace {
                                            llvm::GlobalValue::PrivateLinkage,
                                            "create_generic_metadata",
                                            &IGM.Module);
+      f->setAttributes(IGM.constructInitialAttributes());
 
       IRGenFunction IGF(IGM, f);
       if (IGM.DebugInfo)

lib/IRGen/GenObjC.cpp

@@ -754,7 +754,12 @@ static llvm::Function *emitObjCPartialApplicationForwarder(IRGenModule &IGM,
   llvm::Function *fwd =
     llvm::Function::Create(fwdTy, llvm::Function::InternalLinkage,
                            "_TPAo", &IGM.Module);
-  fwd->setAttributes(attrs);
+
+  auto initialAttrs = IGM.constructInitialAttributes();
+  // Merge initialAttrs with attrs.
+  auto updatedAttrs = attrs.addAttributes(IGM.getLLVMContext(),
+                        llvm::AttributeSet::FunctionIndex, initialAttrs);
+  fwd->setAttributes(updatedAttrs);
 
   IRGenFunction subIGF(IGM, fwd);
 

lib/IRGen/IRGenModule.cpp

@@ -43,6 +43,7 @@
 #include "Linking.h"
 
 #include <initializer_list>
+#include <sstream>
 
 using namespace swift;
 using namespace irgen;
@@ -452,6 +453,38 @@ llvm::AttributeSet IRGenModule::getAllocAttrs() {
   return AllocAttrs;
 }
 
+/// Construct initial attributes from options.
+llvm::AttributeSet IRGenModule::constructInitialAttributes() {
+  llvm::AttributeSet attrsUpdated;
+  // Add DisableFPElim. 
+  if (!Opts.DisableFPElim) {
+    attrsUpdated = attrsUpdated.addAttribute(LLVMContext,
+                     llvm::AttributeSet::FunctionIndex,
+                     "no-frame-pointer-elim", "false");
+  }
+
+  // Add target-cpu and target-features if they are non-null.
+  auto *Clang = static_cast<ClangImporter *>(Context.getClangModuleLoader());
+  clang::TargetOptions &ClangOpts = Clang->getTargetInfo().getTargetOpts();
+
+  std::string &CPU = ClangOpts.CPU;
+  if (CPU != "")
+    attrsUpdated = attrsUpdated.addAttribute(LLVMContext,
+                     llvm::AttributeSet::FunctionIndex, "target-cpu", CPU);
+
+  std::vector<std::string> &Features = ClangOpts.Features;
+  if (!Features.empty()) {
+    std::stringstream S;
+    std::copy(Features.begin(), Features.end(),
+              std::ostream_iterator<std::string>(S, ","));
+    // The drop_back gets rid of the trailing space.
+    attrsUpdated = attrsUpdated.addAttribute(LLVMContext,
+                     llvm::AttributeSet::FunctionIndex, "target-features",
+                     StringRef(S.str()).drop_back(1));
+  }
+  return attrsUpdated;
+}
+
 llvm::Constant *IRGenModule::getSize(Size size) {
   return llvm::ConstantInt::get(SizeTy, size.getValue());
 }

lib/IRGen/IRGenModule.h

@@ -578,6 +578,8 @@ private:                            \
   void addLinkLibrary(const LinkLibrary &linkLib);
   void finalize();
 
+  llvm::AttributeSet constructInitialAttributes();
+
   void emitProtocolDecl(ProtocolDecl *D);
   void emitEnumDecl(EnumDecl *D);
   void emitStructDecl(StructDecl *D);

test/ClangModules/objc_ir.swift

@@ -85,23 +85,23 @@ func almostSubscriptable(#as1: AlmostSubscriptable, #a: A) {
   as1.objectForKeyedSubscript(a)
 }
 
-// CHECK: define hidden void @_TF7objc_ir13protocolTypesFT1aCSo7NSMince1bPSo9NSRuncing__T_(%CSo7NSMince*, %objc_object*) {
+// CHECK: define hidden void @_TF7objc_ir13protocolTypesFT1aCSo7NSMince1bPSo9NSRuncing__T_(%CSo7NSMince*, %objc_object*) {{.*}} {
 func protocolTypes(#a: NSMince, #b: NSRuncing) {
   // - (void)eatWith:(id <NSRuncing>)runcer;
   a.eatWith(b)
   // CHECK: [[SEL:%.*]] = load i8*, i8** @"\01L_selector(eatWith:)", align 8
   // CHECK: call void bitcast (void ()* @objc_msgSend to void ([[OPAQUE:%.*]]*, i8*, i8*)*)([[OPAQUE:%.*]]* {{%.*}}, i8* [[SEL]], i8* {{%.*}})
 }
 
-// CHECK-LABEL: define hidden void @_TF7objc_ir6getsetFT1pPSo8FooProto__T_(%objc_object*) {
+// CHECK-LABEL: define hidden void @_TF7objc_ir6getsetFT1pPSo8FooProto__T_(%objc_object*) {{.*}} {
 func getset(#p: FooProto) {
   // CHECK: load i8*, i8** @"\01L_selector(bar)"
   // CHECK: load i8*, i8** @"\01L_selector(setBar:)"
   let prop = p.bar
   p.bar = prop
 }
 
-// CHECK-LABEL: define hidden void @_TF7objc_ir17pointerPropertiesFCSo14PointerWrapperT_(%CSo14PointerWrapper*) {
+// CHECK-LABEL: define hidden void @_TF7objc_ir17pointerPropertiesFCSo14PointerWrapperT_(%CSo14PointerWrapper*) {{.*}} {
 func pointerProperties(obj: PointerWrapper) {
   // CHECK: load i8*, i8** @"\01L_selector(setVoidPtr:)"
   // CHECK: load i8*, i8** @"\01L_selector(setIntPtr:)"

test/DebugInfo/initializer.swift

@@ -7,10 +7,10 @@ protocol Named {
 }
 
 // initializer.Person.init (initializer.Person.Type)() -> initializer.Person
-// CHECK: define hidden %C11initializer6Person* @_TFC11initializer6PersoncfMS0_FT_S0_(%C11initializer6Person*) {
+// CHECK: define hidden %C11initializer6Person* @_TFC11initializer6PersoncfMS0_FT_S0_(%C11initializer6Person*) {{.*}} {
 
 // initializer.Person.__allocating_init (initializer.Person.Type)() -> initializer.Person
-// CHECK: define hidden %C11initializer6Person* @_TFC11initializer6PersonCfMS0_FT_S0_(%swift.type*) {
+// CHECK: define hidden %C11initializer6Person* @_TFC11initializer6PersonCfMS0_FT_S0_(%swift.type*) {{.*}} {
 // CHECK:  call %C11initializer6Person* @_TFC11initializer6PersoncfMS0_FT_S0_(%C11initializer6Person* %3), !dbg ![[ALLOCATING_INIT:.*]]
 
 // CHECK-DAG: ![[ALLOCATING_INIT]]  = !DILocation(line: 0, scope

test/DebugInfo/protocol.swift

@@ -21,7 +21,7 @@ class Point : PointUtils {
 
 }
 
-// CHECK-DAG: define hidden i64 @_TF8protocol4mainFT_VSs5Int64() {
+// CHECK-DAG: define hidden i64 @_TF8protocol4mainFT_VSs5Int64() {{.*}} {
 func main() -> Int64 {
     var pt = Point(_x: 2.5, _y: 4.25)
 // CHECK: [[LOC2D:%[a-zA-Z0-9]+]] = alloca %P8protocol10PointUtils_, align {{(4|8)}}