Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize make_request #61

Closed
ChrisTorresLugo opened this issue Feb 23, 2021 · 2 comments
Closed

Generalize make_request #61

ChrisTorresLugo opened this issue Feb 23, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ChrisTorresLugo
Copy link
Member

Currently, OAuth{1,2}'s make_request uses requests.get() to contact the API. The filtered stream endpoint requires the use of POST to establish the rules that the stream will be filtered on. Other endpoints in the future might require POST or other methods. To get around this issue, I'll be changing make_requests to use requests.requests(method={"GET", "POST",etc}) and will update all the endpoints to pass the corresponding method to make_request.

@ChrisTorresLugo ChrisTorresLugo added the enhancement New feature or request label Feb 23, 2021
@ChrisTorresLugo ChrisTorresLugo added this to the Basic functionality milestone Feb 23, 2021
@ChrisTorresLugo ChrisTorresLugo self-assigned this Feb 23, 2021
@mr-devs
Copy link
Member

mr-devs commented Feb 23, 2021

awesome, thanks Chris!

@mr-devs
Copy link
Member

mr-devs commented Jul 20, 2021

Addressed in #74.

@mr-devs mr-devs closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants