-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json name paths not included #182
Comments
This still might be unsupported at the commonjs resolution layer, but your madgerc might have a bug (may or may not fix it): |
Thanks for the correction. Unfortunately it seems to have the same output.
|
Thanks for confirming! Assuming that's a valid import (curious why you need to qualify that import with the package name), there must be support for that missing in the node-filing-cabinet package. That package's commonjs resolution algorithm relies on the 'resolve' package. Is there something that we're not supplying there to make this work? You can hack filing-cabinet in your node_modules folder to see what a fix could be. |
Sorry to revive this thread, but I'm wondering if there's been any development regarding this issue? I'm facing the same problem. Here's my masgerc file:
and here's my jsconfig file:
|
If this bug do exist, it's similar to #158 . I reckon we should solve them in a same PR. |
Paths using the name of my root directory package.json aren't included in dependency calculations
package.json:
Upon calling
madge --orphans --basedir ./ ./
ormadge --orphans ./
it lists a file as an orphan:
src/services/Logger.js
This file isn't an orphan, however its dependant is using the package name in the import:
import Logger from 'myproject/src/services/Logger'
.madgerc:
The text was updated successfully, but these errors were encountered: