Add a release mechanism for alarm windows when it is expired in case …

…of OOM. (apache#11336)
panshuling321 · Sep 15, 2023 · e448feb · e448feb
1 parent 1943ce0
commit e448feb
Show file tree

Hide file tree

Showing 3 changed files with 136 additions and 80 deletions.
diff --git a/docs/en/changes/changes.md b/docs/en/changes/changes.md
@@ -10,6 +10,7 @@
 * Support Kafka Monitoring.
 * [Breaking Change] Elasticsearch storage merge all management data indices into one index `management`, 
   including `ui_template，ui_menu，continuous_profiling_policy`.
+* Add a release mechanism for alarm windows when it is expired in case of OOM.
 
 #### UI
 

diff --git a/...lugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java b/...lugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java
@@ -198,8 +198,14 @@ public void moveTo(LocalDateTime targetTime) {
      */
     public List<AlarmMessage> check() {
         List<AlarmMessage> alarmMessageList = new ArrayList<>(30);
+        List<AlarmEntity> expiredEntityList = new ArrayList<>();
 
         windows.forEach((alarmEntity, window) -> {
+            if (window.isExpired()) {
+                expiredEntityList.add(alarmEntity);
+                return;
+            }
+
             Optional<AlarmMessage> alarmMessageOptional = window.checkAlarm();
             if (alarmMessageOptional.isPresent()) {
                 AlarmMessage alarmMessage = alarmMessageOptional.get();
@@ -218,6 +224,7 @@ public List<AlarmMessage> check() {
             }
         });
 
+        expiredEntityList.forEach(windows::remove);
         return alarmMessageList;
     }
 
@@ -383,6 +390,17 @@ private boolean isMatch() {
             return isMatch == 1;
         }
 
+        public boolean isExpired() {
+            if (this.values != null) {
+                for (Map<String, Metrics> value : this.values) {
+                    if (value != null) {
+                        return false;
+                    }
+                }
+            }
+            return true;
+        }
+
         private void init() {
             values = new LinkedList<>();
             for (int i = 0; i < period; i++) {