Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate models internal api to passport.xyz #3104

Open
4 tasks
larisa17 opened this issue Dec 5, 2024 · 1 comment
Open
4 tasks

Migrate models internal api to passport.xyz #3104

larisa17 opened this issue Dec 5, 2024 · 1 comment

Comments

@larisa17
Copy link
Collaborator

larisa17 commented Dec 5, 2024

Data models api are reached via private.gitcoin.co.

  • add the new record & (public) hosted zone for models api running on passport.xyz ( eg: zone name: private.passport.xyz / internal.passport.xyz)
  • add the required record for the internal ALB ( eg record name: alb.private.passport.xyz / alb.internal.passport.xyz )
  • update all apps using the Models API endpoint
  • remove old record after the above implementation is released in production
@larisa17 larisa17 converted this from a draft issue Dec 5, 2024
@nutrina nutrina changed the title Migrate modes internal api to passport.xyz Migrate models internal api to passport.xyz Dec 16, 2024
@nutrina
Copy link
Collaborator

nutrina commented Dec 16, 2024

Drop the configuration of the endpoints in 1P, and instead read the from the output of the core infra.
Currently this applies to:

  • the model scores which call the model APIs over the private ALB - this needs to be updated
  • embed API in the scorer - this is WIP, this should be properly implemented from the start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Prioritized
Development

No branches or pull requests

2 participants