Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix references to some constants in some places which only exist when hschottm/xls_export is installed #13

Open
MDevster opened this issue Jun 8, 2022 · 2 comments
Open

fix references to some constants in some places which only exist when hschottm/xls_export is installed #13

MDevster opened this issue Jun 8, 2022 · 2 comments
Assignees
@cmette
Labels
bug Something isn't working

Comments

@MDevster
Copy link

MDevster commented Jun 8, 2022

Hint from @fritzmg in #12
@MDevster MDevster added the bug Something isn't working label Jun 8, 2022
@fritzmg
Copy link

fritzmg commented Jun 8, 2022

Well this is actually already fixed with my PR ;). What remains is: there are references to some constants in some places which only exist when hschottm/xls_export is installed.

@MDevster MDevster changed the title fix the usage of the global namespace everywhere some code styling improvements Jun 8, 2022
@MDevster
Copy link
Author

MDevster commented Jun 8, 2022

@fritzmg i change the title ;)

@MDevster MDevster changed the title some code styling improvements fix references to some constants in some places which only exist when hschottm/xls_export is installed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmette cmette

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fritzmg @MDevster @cmette