Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from_dict() and from_pandas() from instance method to class method. #443

Closed
khoroshevskyi opened this issue Apr 6, 2023 · 0 comments
Closed

Change from_dict() and from_pandas() from instance method to class method. #443

khoroshevskyi opened this issue Apr 6, 2023 · 0 comments
Assignees
@nsheff @vreuter
Labels
brainstorming

Comments

@khoroshevskyi
Copy link
Member

Referring to the comment: pepkit/pephubclient#15 (comment)

We should rethink how we initializing peppy Project from dict and from peppy.
Now we are creating empty project, and then re-initiating class variables in two methods: from_dict(), from_pandas().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsheff nsheff

@vreuter vreuter

Labels
brainstorming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nsheff @vreuter @khoroshevskyi