Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Available MLST scheme list is out of date #168

Closed
eam12 opened this issue Mar 9, 2023 · 4 comments
Closed

Available MLST scheme list is out of date #168

eam12 opened this issue Mar 9, 2023 · 4 comments
Assignees

Comments

@eam12
Copy link

eam12 commented Mar 9, 2023

The list of MLST schemes available (https://github.com/tseemann/mlst/blob/master/db/scheme_species_map.tab) is out of date and so does not work with the --mlst-scheme flag for some scheme names. For example, senterica is now senterica_achtman_2.

@apetkau
Copy link
Member

apetkau commented Mar 9, 2023

Hello @eam12 . Thanks for reporting. Which version of the mlst software do you have installed? As in mlst --version?

The --mlst-scheme option in StarAMR is passed directly to the mlst software, as seen below:

command = ['mlst']
if mlst_scheme is not None:
command.extend(['--scheme', mlst_scheme])

So the valid schemes to use depends on which version of mlst you have installed.

@eam12
Copy link
Author

eam12 commented Mar 9, 2023

I have mlst version 2.23.0 installed. If I specify the updated scheme name (e.g. senterica_achtman_2) it runs perfectly, but the --help menu tells users to look at mlst's scheme_species_map.tab file to get a list of available scheme names. This file is out of date (e.g. still lists senterica, not senterica_achtman_2 . It would be great if the --help menu directed users to an updated list of mlst scheme names. Maybe https://github.com/tseemann/mlst/blob/master/db/pubmlst? Small thing, I know, but would be very helpful!

--mlst-scheme MLST_SCHEME
                        Specify scheme name, visit https://github.com/tseemann/mlst/blob/master/db/scheme_species_map.tab for supported scheme genus available. [None]

@apetkau
Copy link
Member

apetkau commented Mar 9, 2023

Ah, okay. Thanks. Yes, maybe changing the help documentation to point to a different location to get a list of schemes would be helpful (I did not realize that file was out of date).

Note by default schemes should be auto-detected if you don't specify anything.

@apetkau
Copy link
Member

apetkau commented Aug 2, 2023

Fixed in #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants