Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: phacility/phabricator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2ddc770fd881de7a5bbe613de49d1456e8c978ae
Choose a base ref
...
head repository: phacility/phabricator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0167f357b7233ec23d70985911254681b1c2e6d7
Choose a head ref
  • 5 commits
  • 22 files changed
  • 1 contributor

Commits on Sep 15, 2018

  1. Remove "mailKey" from "PhabricatorRepositoryCommit" 

    Summary: Ref T13197. Ref T13065. This continues the gradual purge of dedicated "mailKey" columns in favor of shared infrastructure.

Test Plan:
  - Ran migration.
  - Visually inspected database.
  - Grepped for `mailKey`.
  - Added some comments, saw the daemons generate corresponding mail.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13197, T13065

Differential Revision: https://secure.phabricator.com/D19670
    epriestley committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    40d5d5c View commit details
    Browse the repository at this point in the history

  2. Allow Drydock logs to be associated with RepositoryOperation objects 

    Summary: Ref T13197. See PHI873. I want to give RepositoryOperation objects access to Drydock logging like leases, resources, and blueprints currently have. This just does the schema/query changes, no actual UI or new logging yet.

Test Plan: Ran storage upgrade, poked around the UI looking for anything broken.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13197

Differential Revision: https://secure.phabricator.com/D19671
    epriestley committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    10f219f View commit details
    Browse the repository at this point in the history

  3. Add Drydock logs to the RepositoryOperation UI 

    Summary:
Depends on D19671. Ref T13197. See PHI873.

Expose logs in the RepositoryOperation UI. Nothing writes the logs yet, so these interfaces are currently always empty.

Test Plan:
{F5887102}

{F5887103}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13197

Differential Revision: https://secure.phabricator.com/D19672
    epriestley committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    92bcf85 View commit details
    Browse the repository at this point in the history

  4. Write a trivial log when starting a repository operation 

    Summary:
Depends on D19672. Ref T13197. See PHI873. This writes a trivial log when we begin acting on a working copy and makes it look reasonable in the UI.

This is mostly just to prove that logging works properly.

Test Plan: {F5887697}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13197

Differential Revision: https://secure.phabricator.com/D19673
    epriestley committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    a7e060f View commit details
    Browse the repository at this point in the history

  5. Provide a convenient way to log arbitrary text in Drydock without nee… 

    …ding structured log classes

Summary: Depends on D19673. Ref T13197. See PHI873.

Test Plan:
Added some code like this:

```
$operation->logText('Nice convenient text logging.');
```

...then got:

{F5887712}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13197

Differential Revision: https://secure.phabricator.com/D19674
    epriestley committed Sep 15, 2018
    Configuration menu
    Copy the full SHA
    0167f35 View commit details
    Browse the repository at this point in the history
Loading