Thanks for taking the time to help make harp better. Here are some guidlines that will highly increase the chances of your fix or feature request from being accepted.
If you find a bug you would like fixed. Open up a ticket with a detailed description of the bug and the expected behaviour. If you would like to fix the problem yourself please do the following steps.
- Fork it.
- Create a branch (
git checkout -b fix-for-that-thing) - Commit a failing test (
git commit -am "adds a failing test to demonstrate that thing") - Commit a fix that makes the test pass (
git commit -am "fixes that thing") - Push to the branch (
git push origin fix-for-that-thing) - Open a Pull Request
Please keep your branch up to date by rebasing upstream changes from master.
If you wish to add new functionality to harp, please provide @sintaxi and @kennethormandy a harp application that demonstrates deficiency in current design or desired additional behaviour. Its best if you explaing the problem you are trying to solve, not just the solution you want. You may also submit a pull request with the steps above.