You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing #39, I noticed a minor usability issue that can occur when using the "Collapse recognized text" feature in conjunction with a low (200 or 300 px) max image side length. Expanding the collapsed text can cause the other pages to be shifted rightwards slightly.
Here's an example; notice how when I expand the Page 1 text, pages 2 and 3 move position to the right a bit:
Screen.Recording.2024-12-18.at.11.28.45.PM.mov
It would be nicer if those pages did not shift at all. At worst, this could cause the rightmost page to reflow into the row below, which could be confusing.
This happens because I'm setting the max-width of the container to the max dimension of the page image, which for notes in portrait orientation is the height of the image and not the width. So the container is allowed to be as wide as the image is tall. Unfortunately I don't have a simple workaround for this because I want to preserve compatibility with horizontal notes (though I know they don't currently work correctly, per #27), and I haven't found a good way to have different behaviors for horizontal vs. vertical notes.
Maybe there's some easy way to grab the width of the note image and set the page container to that value (rather than just the max dimension)?
Fortunately when the image size limit is set higher, this stops being an issue because the width of the recognized text stops exceeds the width of the image.
I think this is a relatively minor issue but I did want to document it here for future reference.
The text was updated successfully, but these errors were encountered:
While testing #39, I noticed a minor usability issue that can occur when using the "Collapse recognized text" feature in conjunction with a low (200 or 300 px) max image side length. Expanding the collapsed text can cause the other pages to be shifted rightwards slightly.
Here's an example; notice how when I expand the Page 1 text, pages 2 and 3 move position to the right a bit:
Screen.Recording.2024-12-18.at.11.28.45.PM.mov
It would be nicer if those pages did not shift at all. At worst, this could cause the rightmost page to reflow into the row below, which could be confusing.
This happens because I'm setting the max-width of the container to the max dimension of the page image, which for notes in portrait orientation is the height of the image and not the width. So the container is allowed to be as wide as the image is tall. Unfortunately I don't have a simple workaround for this because I want to preserve compatibility with horizontal notes (though I know they don't currently work correctly, per #27), and I haven't found a good way to have different behaviors for horizontal vs. vertical notes.
Maybe there's some easy way to grab the width of the note image and set the page container to that value (rather than just the max dimension)?
Fortunately when the image size limit is set higher, this stops being an issue because the width of the recognized text stops exceeds the width of the image.
I think this is a relatively minor issue but I did want to document it here for future reference.
The text was updated successfully, but these errors were encountered: