Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship defaults in /etc/xdg/pqivrc instead? #246

Open
tleydxdy opened this issue Oct 4, 2024 · 2 comments
Open

Ship defaults in /etc/xdg/pqivrc instead? #246

tleydxdy opened this issue Oct 4, 2024 · 2 comments
Labels
enhancement help wanted An issue in need of someone to implement a change

Comments

@tleydxdy
Copy link

tleydxdy commented Oct 4, 2024

Hi, I wonder if it's preferable to ship the defaults in /etc/xdg/pqivrc instead of hard-coding it in the source (perhaps hardcoding the most basic commands like quit() makes sense).

What prompted this for me is that the default binds a lot of keys and especially lots of keys to the same function. Personally I get really confused when I accidentally hit some key and it does something surprising to me (e.g. I unbond all the keys in mpv that I don't use). But doing so in pqiv is quite tedious and would also break if a new default bind is added.

I think that changing this would also have a few side benefits. It would serves as a reference on how the config format works, and it also makes the defaults self-documenting on the user's machine, instead of requiring the man page to be synced or dedicated commands that prints out these information.

I understand that this is quite a big change, and I'm willing to work on it. I just want to see if this is desirable or not.

@phillipberndt
Copy link
Owner

How about a "drop all existing key bindings" instruction to put at the top of your config? That sounds like an unobstrusive, simple change. And IIUC it would give you what you're looking for?!

@tleydxdy
Copy link
Author

tleydxdy commented Oct 6, 2024

Yes, that would solve the primary issue. Actually, it would probably also enable shipping a default config while being backwards compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted An issue in need of someone to implement a change
Projects
None yet
Development

No branches or pull requests

2 participants