-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what is the input of conditional DDIM decoder? #66
Comments
The word input is a bit ambiguous because there are actually "two" inputs:
|
Many thanks for your reply! |
Moreover, another question is why not need a reconstruction loss to restrict the output of your ddim decoder to ensure the reconstruction of original image? Only the denoising loss is sufficient, why? I can't think of the logic. |
Another question is i noticed in your code that in your DDIM decoder, the condition, z_sem, only used in ResBlock, together with timestep. But in Attention Module, you only use self-attn instead of cross-attn, can i ask the reason here? |
Diffusion autoencoders or even plain DDIM can definitely reconstruct the image.
This is the property of DDIM itself. An intuition is that DDIM is an ODE, and an ODE can be thought as an invertible mapping (so you have the way to go from the input and back, hence reconstruction). I refer you to read more from the DDIM paper (Song et al, 2020).
You can definitely add conditioning signals to the attention modules as well for sure. Is it worth it or not? It's hard to tell without experiments. But the high-level motivation is Attention is attention: "you are working with the inputs" not really adding something new to it. Convolution, in this case, is a better choice for a layer that "adding something new". |
Thank you so so much for your reply! |
I really appreciate your work!
But I'm confused about the input of your conditional DDIM decoder.
In your paper, you said 'For training, the stochastic subcode x_T is not needed.' So whether the input is your original image add a certain amount of noise? And the loss function is between the adding noise and the predicted noise?
Thanks for your patience!
The text was updated successfully, but these errors were encountered: