Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all handlers from core in a new package handler? #138

Open
decebals opened this issue Jun 10, 2015 · 1 comment
Open

Move all handlers from core in a new package handler? #138

decebals opened this issue Jun 10, 2015 · 1 comment
Labels

Comments

@decebals
Copy link
Member

A new package core.handler and move all handlers (*Handler.java, route.*Handler.java) in this package.

@gitblit
Copy link
Collaborator

gitblit commented Jun 10, 2015

I agree, the core package is a little fat. Another alternative would be moving *Handler.java into core.route? We already have that and they are directly related - a Route has a url, method, and a Handler. That would add 5-6 classes to core.route perhaps making it too fat. If we a create a new package that moves 5-6 classes out of core and 5-6 classes out of core.route. I'm fine with whatever you think is best.

Unrelated, but looking at the Route constructor I'm struck by feeling the signature is backwards:

public Route(String uriPattern, String requestMethod, RouteHandler routeHandler)

I think everywhere else we specify the order as METHOD URL (.e.g. GET /webjars/jquery...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants