Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The embedded Jetty implementation should use HTTP2 #487

Open
Wavesonics opened this issue Dec 28, 2018 · 6 comments
Open

The embedded Jetty implementation should use HTTP2 #487

Wavesonics opened this issue Dec 28, 2018 · 6 comments

Comments

@Wavesonics
Copy link
Contributor

We can do this by setting our own Jetty instance that we configure, but I can't see a reason to not enable HTTP2 by default for Jetty, can anyone else?

This is a good example of setting Jetty up correctly for it:
https://github.com/fstab/http2-examples/blob/master/jetty-http2-server-example/src/main/java/de/consol/labs/h2c/examples/server/Http2Server.java

@Wavesonics
Copy link
Contributor Author

Oh, here is one potential reason:

// In order to run this, you need the alpn-boot-XXX.jar in the bootstrap classpath

Might be solvable though in a way that makes sense.

@Wavesonics
Copy link
Contributor Author

I guess more broadly, are there any plans to move to Servlet 4.0 to really leverage some of HTTP/2's new features?

@decebals
Copy link
Member

In this post you can see that I'm OK to switch from Servlet 3.x to Servlet 4.0 if this move brings something valuable on the table.

@Wavesonics
Copy link
Contributor Author

Ah got ya. Ya unless I'm misunderstanding things as well, to really take advantage of server push, Pippo would need a way of parsing the intended HTML output, and enumerating the resources that were going to be needed, That might take some work.

However just re-using HTTP connections would help reduce overhead a lot. I just finished tuning my application to be able to run on a 512MB dyno on Heroku, and boy was it tough to get under that limit. Anything we can do to shrink the footprint of the http server would be a big win.

@decebals
Copy link
Member

Ah got ya. Ya unless I'm misunderstanding things as well, to really take advantage of server push, Pippo would need a way of parsing the intended HTML output, and enumerating the resources that were going to be needed, That might take some work.

Already done. See #490 (comment).

@Wavesonics
Copy link
Contributor Author

Wow great work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants