Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprojects do not respect --decisions-file (at least for NPM) #167

Open
nkoterba opened this issue Aug 3, 2015 · 3 comments
Open

Subprojects do not respect --decisions-file (at least for NPM) #167

nkoterba opened this issue Aug 3, 2015 · 3 comments

Comments

@nkoterba
Copy link

nkoterba commented Aug 3, 2015

Have a directory with:

--- package.json
+-- doc
    --- dependency_decisions.yml
+-- src
     +--- module1
          --- package.json 

My dependency_decisions.yml file excludes npm "devDependencies":

- - :ignore_group
  - devDependencies
  - :who: 
    :why: 
    :when: 2015-07-30 01:49:51.659344000 Z

However, when I run the following command, the "devDependencies" are not ignored.

license_finder report --subprojects=./src/module1 --decisions-file=./doc/dependency_decisions.yml

The above command, when executed, will list all the dependencies in src/module, including devDependencies. It appears that --subprojects is not respecting the decisions file.

@flavorjones
Copy link
Contributor

Thanks for reporting this! I haven't reproduced this yet, but I totally believe it's happening, looking at the code. I'll dig in.

@h000780
Copy link

h000780 commented Oct 8, 2021

I have the same problem.
When I run the following command,the "devDependencies" are not ignored.

license_finder --project-path=plugins/questionnaire --decisions-file=license_finder/doc/dev-decisions.yml

There is only one option(previous one) effected.
Could you help me, thank you very much!

@xtreme-shane-lattanzio
Copy link
Contributor

@h000780 Is your issue related to #888? Just trying to understand whats going on and its hard without clean repro steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants