Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases only on minor version of plotly.js #1062

Closed
dmt0 opened this issue Jul 24, 2020 · 2 comments · Fixed by #1070
Closed

Releases only on minor version of plotly.js #1062

dmt0 opened this issue Jul 24, 2020 · 2 comments · Fixed by #1070

Comments

@dmt0
Copy link
Contributor

dmt0 commented Jul 24, 2020

Since patch versions of plotly.js only contain bugfixes and should not break RCE, I'm considering locking only minor versions in package.json, e.g.: "plotly.js": "1.54.x". This way we won't have to make a new release on each patch version bump.

What do you think @nicolaskruchten?
@nicolaskruchten
Copy link
Contributor

works for me

@dmt0
Copy link
Contributor Author

dmt0 commented Jul 24, 2020

Great, will do that on next plotly.js version bump.

@dmt0 dmt0 mentioned this issue Sep 8, 2020
Merged
@dmt0 dmt0 closed this as completed in #1070 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Plotly.js 1.55.x upgrade + version bump plotly/react-chart-editor
2 participants
@nicolaskruchten @dmt0