Timeseries hang

[nicolaskruchten]

To replicate: +Trace, +Trace, set type to Timeseries, click on anything else, wait... browser locks up

[nicolaskruchten]

Notes:

• also happens in the opposite order, oddly: +Trace, set type to Timeseries (ok), +Trace (hang)

[nicolaskruchten]

@VeraZab input needed!

This infinite loop is actually fairly straightforward... There are two ifs here https://github.com/plotly/react-plotly.js-editor/blob/master/src/components/fields/TraceSelector.js#L180 , one which turns the rangeslider on and one which turns it off. If you have two traces, one of which is a timeseries and one which is a scatter, each of their TraceSelectors steps into one of the branches and things bounce back and forth.

I assume your intention here was to capture situations where a single trace switches from one type to another, not to capture inter-trace interactions... but there is in fact a path dependence problem here. If we create a timeseries, then a scatter, we would expect the rangeslider to stay on, right? If we then remove the timeseries, would we expect it to disappear? If so, presumably that's not the case if we had two timeseries and removed one of them. So... is the rule something like "if there is at least one timeseries/ohlc/candlestick then force the rangeslider on always"? Or something like "rangesliders are only allowed if one trace is timeseries/ohlc/candlestick"? Neither of those seems satisfactory.

I'm thinking we should try to do an onChange type thing on the trace selector, and if it's switching to one of timeseries/ohlc/candlestick then force the rangeslider on, but nothing else. If someone turns it off, ok. If someone turns it on for a scatter trace, ok.

Thoughts?

[nicolaskruchten]

FWIW the current workspace resets the rangeslider to true for timeseries and false for others, on change, but lets you turn it on and off for non-financial traces, but not off for financial traces.

[nicolaskruchten]

Digging more into the workspace, I see that the type there (in the JSON editor) is not timeseries but scatter, and there's nothing to do with autobinx or autobiny in the trace object... Can you fill me in about what I'm missing here?

[nicolaskruchten]

@VeraZab see comment in #260 before answering here :)

[VeraZab]

ok, we can remove the timeseries trace type. Rangesliders aren't in yet, and there would have been other interactions to test out by turning it on/off, changing trace types. autobinx and autobiny would have come into play then.

[nicolaskruchten]

You'll have to explain autobinx and autobiny to me sometime... They are not keys in the trace object for any type other than histogram as far as the documentation goes, so why do they come into play here?