Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FontPicker to provide default fonts #60

Closed
bpostlethwaite opened this issue Nov 13, 2017 · 3 comments
Closed

FontPicker to provide default fonts #60

bpostlethwaite opened this issue Nov 13, 2017 · 3 comments
Assignees
@nicolaskruchten

Comments

@bpostlethwaite
Copy link
Member

Create a FontSelector that provides default fonts
@bpostlethwaite
Copy link
Member Author

Once implemented you can remove the hardcoded default fonts from lab/src/components/CustomPanels

@bpostlethwaite
Copy link
Member Author

@nicolaskruchten this one may help with the issues you have assigned yourself. A simple wrapper around a dropdown that adds the DEFAULT_FONTS by... default. That way we can ⚡ the imports of DEFAULT_FONTS into the DefaultEditor and also CustomPanels in the Lab.

We can make it more fancy like the workspace version incrementally.

@bpostlethwaite
Copy link
Member Author

hmmm this was ported over from workspace already https://github.com/plotly/react-plotly.js-editor/blob/master/src/components/widgets/FontSelector.js

@nicolaskruchten nicolaskruchten self-assigned this Nov 24, 2017
@nicolaskruchten nicolaskruchten mentioned this issue Nov 24, 2017
Merged
@nicolaskruchten nicolaskruchten mentioned this issue Nov 24, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolaskruchten nicolaskruchten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaskruchten @bpostlethwaite