Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoverlabel config #721

Closed
nicolaskruchten opened this issue Aug 30, 2018 · 3 comments · Fixed by #738
Closed

hoverlabel config #721

nicolaskruchten opened this issue Aug 30, 2018 · 3 comments · Fixed by #738
Assignees

Comments

@nicolaskruchten
Copy link
Contributor

This exists in layout and in data but right now it looks like bgcolor etc aren't populated in fulldata?

@nicolaskruchten
Copy link
Contributor Author

Blocked by plotly/plotly.js#2964

@nicolaskruchten
Copy link
Contributor Author

OK, not blocked. Let's work around this at the editor level...

Here's what we need:

  1. ColorPicker needs to be able to handle null or missing values by showing some text saying "this color is computed from other parts of the figure but you can 'click here' to override it" at which point it shows the normal picker and forces a value into the field
  2. We add this capability to the editor for both the trace and layout-level variants, and tie its visibility to hoverlabel.font or something so that it shows up even when the value isn't in fullData, and then the 'empty state' kicks in.

@dmt0
Copy link
Contributor

dmt0 commented Sep 7, 2018

Would be great to know exactly from which "other parts of the figure" do they actually get colors, so I could prepopulate them with whatever is visually there, and not just black/white.
bgcolor is clearly from marker.color, bordercolor and font are white, but where did white come from?

@dmt0 dmt0 mentioned this issue Sep 7, 2018
@dmt0 dmt0 closed this as completed in #738 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants