Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some Components PureComponents #763

Open
nicolaskruchten opened this issue Oct 10, 2018 · 2 comments
Open

Make some Components PureComponents #763

nicolaskruchten opened this issue Oct 10, 2018 · 2 comments

Comments

@nicolaskruchten
Copy link
Contributor

Would we get any performance lift from make some Components into PureComponents ?
@dmt0
Copy link
Contributor

dmt0 commented Oct 30, 2018

In React 16.6 functional components can become pure as well: https://reactjs.org/docs/react-api.html#reactmemo

@dmt0
Copy link
Contributor

dmt0 commented Apr 9, 2019 •
edited
Loading

Investigated React.memo. Unfortunately most of our widgets have state so that's not an option. PureComponents would be a sensible optimization though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaskruchten @dmt0