Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not include development scripts in the inst dir #446

Open
eitsupi opened this issue Oct 28, 2023 · 4 comments
Open

Should not include development scripts in the inst dir #446

eitsupi opened this issue Oct 28, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented Oct 28, 2023

There are many files not related to users now.
We should move these files out of the inst folder.

@eitsupi eitsupi added the enhancement New feature or request label Oct 28, 2023
@eitsupi eitsupi added this to the 1st CRAN Release milestone Oct 28, 2023
@eitsupi eitsupi self-assigned this Oct 29, 2023
@eitsupi eitsupi assigned sorhawell and unassigned eitsupi Dec 22, 2023
@eitsupi
Copy link
Collaborator Author

eitsupi commented Dec 22, 2023

@sorhawell I think these files are actually only used by you, so can I ask you to update them?

@sorhawell
Copy link
Collaborator

I will move them to dev.

@eitsupi are you brewing on some new task format?

Maybe it is a pity these dev functions are not being promoted more. @etiennebacher had issues with rust and make "cache" (rust target dir + previous built binaries) did not work across branches etc. I think it is possible to use the Makefile but the environment variables have to be set just right, and sometimes by accident the previous compilation is lost. It is likely so because the Makefile first serves our CI and contains GOTCHAS because of CRAN rules and cross compilation etc.

With load_polars / build_polars / check_polars it just a one liner from the R terminal and I never lost an opportunity to reuse the target files/ previous built binaries again ... and then the 2 secs! for spawning a new R process saved also :)

I could add to Makefile opinionated load / install / check procedures focused on speed.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Dec 23, 2023

are you brewing on some new task format?

It's on my TODO list but I've been so busy lately I haven't had time to do it.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Dec 23, 2023

@sorhawell I opened a PR #617
Tasks can have environment variables set per taskfile or per individual task, so there is no need to worry about environment variables in R.

r-polars/Taskfile.yml

Lines 3 to 6 in c1c72d6

env:
NOT_CRAN: "true"
LIBR_POLARS_BUILD: "true"
RPOLARS_FULL_FEATURES: "true"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants